Sponsoring request for gnome-user-share 0.40 with BlueZ 4.x patch

Bug #280715 reported by Baptiste Mille-Mathias on 2008-10-09
6
Affects Status Importance Assigned to Milestone
gnome-user-share (Ubuntu)
Undecided
Unassigned

Bug Description

gnome-user-share (0.40-0ubuntu1) intrepid; urgency=low

  * New Upstream Release:
    - ConsoleKit support (only activate file sharing when session is active)
    - Add Notification to reveal and open files received over Bluetooth
    - Make the httpd configuration file support multiple Apache MPMs
    - move the configuration to Freedesktop compliant location
  * debian/control.in:
    - Add libnotify-dev to Build-Depends
  * debian/patches/01_apache-config.patch: dropped, applied upstream

 -- Baptiste Mille-Mathias <email address hidden> Thu, 09 Oct 2008 13:41:45 +0200

description: updated
Chris Coulson (chrisccoulson) wrote :

Baptiste,

I think you need to alter the Maintainer field in the control file to be "<email address hidden>", as per the Ubuntu Policy Manual. The existing maintainer should be added to the field "XSBC-Original-Maintainer".

James Westby (james-w) wrote :

Hi,

"- move the configuration to Freedesktop compliant location"

does that involve any migration code in the package? Does
it refer to configuration in /etc/ or in the user's home dir?

Thanks,

James

James Westby (james-w) wrote :

Also, is this covered by the GNOME freeze exception?

Thanks,

James

Hello,

Regarding the configuration, it is the user configuration. As I wrote the feature I can say the user configuration is moved from ~/.gnome2/user-share to ~/.config/user-share if gnome-user-share when it is started.

For the Freeze I need to check that with Sebastien Bacher.

regards
--
Baptiste

Chris,

Thanks for pointing me this, I've corrected the maintainer field.
I hope I didn't forget something

James Westby (james-w) wrote :

Hi,

Thanks for working on this. It looks pretty good, but I have a couple
of questions/comments.

  * You based your work on your 0.31-3ubuntu1~ppa1 PPA package, so
     the changelog has changed a bit too much from what was in Intrepid.
     I can fix this up when sponsoring though.

  * The config migration code just looks for the presence of the old config
     dir and tries to rename it. In the case where a homedir is shared between
     hardy and Intrepid, this migrate the user the first time they run Intrepid.
     Then when they go back to hardy they will lose their settings, but if they
     create the dir again, the next time they go back to Intrepid it will try and
     rename again, and fail. I assume this won't crash the app? Will it just
     give a warning, or nothing?

  * You state in the title of the bug that this has the bluez 4.x patch, but it
     seems that patch is already in the Inrepid version, is that correct?

Thanks,

James

Hi James,

The migration code doesn't make the application crash, I've just check.
For the Bluez patch, I've talked with upstream developer, and it is necessary apparently to add this patch to make gnome-user-share works with bluez 4.x.

Regards

James Westby (james-w) wrote :

Hello Baptiste,

Thanks for testing the migration code.

As for the bluez patch I realise that it's needed, I was just confused why
you put it in the title of this report when as far as I can see the package
already in the archives has the patch.

I'm working on sponsoring this now.

Thanks,

James

Thanks James sincerely for the time you dedicate to this work.

Regards

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-user-share - 0.40-0ubuntu1

---------------
gnome-user-share (0.40-0ubuntu1) intrepid; urgency=low

  * New Upstream Release (LP: #280715):
    - ConsoleKit support (only activate file sharing when session is active)
    - Add Notification to reveal and open files received over Bluetooth
    - Make the httpd configuration file support multiple Apache MPMs
    - move the configuration to Freedesktop compliant location
  * debian/control.in:
    - Add libnotify-dev to Build-Depends
  * debian/patches/01_apache-config.patch: dropped, applied upstream

 -- Baptiste Mille-Mathias <email address hidden> Thu, 09 Oct 2008 13:41:45 +0200

Changed in gnome-user-share:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers