Context menu glitch

[Andrew Bennetts]

Sufficiently fast repeated right-clicking on a highlighted URL in
a gnome-terminal causes the context menu to repeat some items. See
attached screenshot.

http://bugzilla.gnome.org/show_bug.cgi?id=157153: http://bugzilla.gnome.org/show_bug.cgi?id=157153

[Andrew Bennetts (spiv)]

Created an attachment (id=671)
Screenshot of wacky context menu.

[Sebastien Bacher (seb128)]

I've opened a bug upstream for this:
http://bugzilla.gnome.org/show_bug.cgi?id=157153

Perhaps that's a general gtk+ issue. The menus are built in a asynchronous way,
this can
happen when you click really fast and I'm not sure that's really easy to fix ...

[Andrew Bennetts (spiv)]

I don't know if this is related, but I think it might be.

I just had a crash in gnome-terminal when right-clicking on a link.
I missed the link slightly on the first click, and clicked again quite
quickly on the actual link. The menu's window appeared, but then
gnome-terminal blew up before it rendered anything in it.

I've seen this once before (and filled out the bug-buddy report, although
I don't know that they go anywhere). I suspect code that is racy enough to
show duplicate menu items is also racy enough to have segfaults.

gdb info from bug-buddy:

Backtrace was generated from '/usr/bin/gnome-terminal'

(no debugging symbols found)...Using host libthread_db library
"/lib/tls/i686/cmov/libthread_db.so.1".
(no debugging symbols found)...(no debugging symbols found)...(no debugging
symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...[Thread debugging using libthread_db enabled]
[New Thread 1088322144 (LWP 5769)]
[New Thread 1101118384 (LWP 5773)]
[Thread debugging using libthread_db enabled]
[New Thread 1088322144 (LWP 5769)]
[New Thread 1101118384 (LWP 5773)]
(no debugging symbols found)...(no debugging symbols found)...(no debugging
symbols found)...[Thread debugging using libthread_db enabled]
[New Thread 1088322144 (LWP 5769)]
[New Thread 1101118384 (LWP 5773)]
(no debugging symbols found)...(no debugging symbols found)...(no debugging
symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symbols found)...(no debugging symbols found)...(no
debugging symbols found)...(no debugging symbols found)...(no debugging symbols
found)...(no debugging symb...

[Andrew Bennetts (spiv)]

To add further info, I just encountered the doubled menu items again,
and my guess would be that it's caused right-clicking while it's
tearing down the old context menu.

i.e. I suspect the crucial sequence of events is:
  - context menu visible
  - right-click on terminal to dismiss it
  - while the old context menu is still visible (even though it's in
    the process of being closed), right-click again

Obviously, this is hard to do intentionally without just clicking like
crazy :) (but I have done it accidentally surprisingly often!)

[Sebastien Bacher (seb128)]

I had the crash too while trying to reproduce the bug.
I've opened a bug upstream with a complete backtrace:
http://bugzilla.gnome.org/show_bug.cgi?id=157151

[Sebastien Bacher (seb128)]

fixed in the upstream CVS, will be fixed in the next release

[Sebastien Bacher (seb128)]

fixed in this upload:

 gnome-terminal (2.9.3-0ubuntu1) hoary; urgency=low
 .
   * New upstream release.