terminal settings messed up after upgrade due to forced profile change

Bug #532511 reported by Martin Pitt
34
This bug affects 5 people
Affects Status Importance Assigned to Milestone
gnome-terminal (Ubuntu)
Fix Released
High
Chris Coulson
Lucid
Fix Released
High
Chris Coulson

Bug Description

Binary package hint: gnome-terminal

After today's dist-upgrade I restarted my desktop and ended up with totally unusable terminals. I got black text on almost-black background, huge font size, the scrollbar and menu bar were back, etc.

I found out that the reason for this was that the default profile was set to "Ambience" now, automatically. Can we please _not_ change the theme by default if the user customized it? This is a direct violation of the "golden rule"..

I suppose this is a bad interaction between 02_rename_default_profile.patch and 04_change_fallback_profile.patch ?

$ LANG= gconftool -R /apps/gnome-terminal

 /apps/gnome-terminal/profiles:
  /apps/gnome-terminal/profiles/Ambiance:
   default_size_columns = 80
   background_type = transparent
   background_color = #30300A0A2424
   scroll_on_output = false
   visible_name = Ambiance
   scrollback_lines = 512
   scroll_background = true
   use_system_font = false
   background_darkness = 0.94999998807907104
   silent_bell = false
   allow_bold = true
   delete_binding = escape-sequence
   login_shell = false
   use_skey = true
   word_chars = -A-Za-z0-9,./?%&#:_=+@~
   default_show_menubar = true
   icon =
   title = Terminal
   bold_color_same_as_fg = true
   use_theme_colors = false
   bold_color = #000000000000
   custom_command =
   scrollbar_position = right
   default_size_rows = 24
   cursor_shape = block
   palette = #2E2E34343636:#CCCC00000000:#4E4E9A9A0606:#C4C4A0A00000:#34346565A4A4:#757550507B7B:#060698209A9A:#D3D3D7D7CFCF:#555557575353:#EFEF29292929:#8A8AE2E23434:#FCFCE9E94F4F:#72729F9FCFCF:#ADAD7F7FA8A8:#3434E2E2E2E2:#EEEEEEEEECEC
   scroll_on_keystroke = true
   title_mode = replace
   update_records = true
   exit_action = close
   use_custom_command = false
   cursor_blink_mode = system
   background_image =
   backspace_binding = ascii-del
   foreground_color = #FFFFFFFFFFFF
   font = Monospace 9
   scrollback_unlimited = false
  /apps/gnome-terminal/profiles/Default:
   default_size_columns = 80
   background_type = solid
   background_color = #FFFFFFFFDDDD
   scroll_on_output = false
   visible_name = Vorgabe
   scrollback_lines = 512
   scroll_background = true
   alternate_screen_scroll = true
   use_system_font = false
   background_darkness = 1
   silent_bell = true
   allow_bold = true
   delete_binding = escape-sequence
   login_shell = false
   use_skey = true
   word_chars = -A-Za-z0-9,./?%&#:_=+@~
   default_show_menubar = false
   icon =
   title = Terminal
   bold_color = #000000000000
   bold_color_same_as_fg = true
   use_theme_colors = true
   custom_command =
   scrollbar_position = hidden
   default_size_rows = 24
   cursor_shape = block
   palette = #2E2E34343636:#CCCC00000000:#4E4E9A9A0606:#C4C4A0A00000:#34346565A4A4:#757550507B7B:#060698209A9A:#D3D3D7D7CFCF:#555557575353:#EFEF29292929:#8A8AE2E23434:#FCFCE9E94F4F:#72729F9FCFCF:#ADAD7F7FA8A8:#3434E2E2E2E2:#EEEEEEEEECEC
   scroll_on_keystroke = true
   update_records = true
   title_mode = replace
   exit_action = close
   use_custom_command = false
   cursor_blink_mode = system
   background_image =
   backspace_binding = ascii-del
   foreground_color = #000000000000
   scrollback_unlimited = false
   font = Monospace 9
 /apps/gnome-terminal/global:
  confirm_window_close = true
  use_menu_accelerators = false
  use_mnemonics = true
  active_encodings = [UTF-8,current,ISO-8859-15]
  profile_list = [Ambiance,Default]
  default_profile = Default
 /apps/gnome-terminal/keybindings:
  switch_to_tab_4 = <Alt>4
  paste = <Ctrl><Shift>v
  switch_to_tab_6 = <Alt>6
  switch_to_tab_7 = <Alt>7
  switch_to_tab_8 = <Alt>8
  switch_to_tab_9 = <Alt>9
  help = F1
  close_tab = <Ctrl><Shift>w
  new_window = <Ctrl><Shift>n
  switch_to_tab_5 = <Alt>5
  zoom_in = <Ctrl>plus
  prev_tab = <Control>Page_Up
  new_tab = <Ctrl><Shift>t
  full_screen = F11
  set_terminal_title = (kein Wert zugewiesen)
  reset = (kein Wert zugewiesen)
  toggle_menubar = (kein Wert zugewiesen)
  switch_to_tab_10 = <Alt>0
  switch_to_tab_11 = (kein Wert zugewiesen)
  switch_to_tab_12 = (kein Wert zugewiesen)
  reset_and_clear = (kein Wert zugewiesen)
  close_window = <Ctrl><Shift>q
  save_contents = disabled
  new_profile = (kein Wert zugewiesen)
  move_tab_left = <Ctrl><Shift>Page_Up
  zoom_normal = <Ctrl>0
  zoom_out = <Ctrl>minus
  detach_tab = (kein Wert zugewiesen)
  next_tab = <Control>Page_Down
  copy = <Ctrl><Shift>c
  move_tab_right = <Ctrl><Shift>Page_Down
  switch_to_tab_1 = <Alt>1
  switch_to_tab_3 = <Alt>3
  switch_to_tab_2 = <Alt>2

ProblemType: Bug
Architecture: amd64
Date: Fri Mar 5 10:31:00 2010
DistroRelease: Ubuntu 10.04
EcryptfsInUse: Yes
Package: gnome-terminal 2.29.6-0ubuntu2
ProcEnviron:
 PATH=(custom, user)
 LANG=de_DE.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-15.22-generic
SourcePackage: gnome-terminal
Uname: Linux 2.6.32-15-generic x86_64

Revision history for this message
Martin Pitt (pitti) wrote :
Changed in gnome-terminal (Ubuntu):
assignee: nobody → Chris Coulson (chrisccoulson)
tags: added: regression-potential
Revision history for this message
Martin Pitt (pitti) wrote :

Oh, before filing this bug report I manually flipped the default profile back to "Default" (the /apps/gnome-terminal/global/default_profile key). I'm pretty sure it was "Ambience" after the upgrade (at least that's what the terminal "Profiles.." dialog showed). If necessary I can dig out my older gconf settings from my backup.

Changed in gnome-terminal (Ubuntu Lucid):
importance: Undecided → High
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

Those are my gconf settings (snippet from ~/.gconf/%gconf-tree.xml) from yesterday's backup.

Revision history for this message
Martin Pitt (pitti) wrote :

My gconf tree only has changes for "Default", but it doesn't have a custom gconf key for /apps/gnome-terminal/global/default_profile. So I assume I got the new default "Ambience" from the schema?

Revision history for this message
Oliver Grawert (ogra) wrote :

confirming, i see the same after the theme upgrade

Revision history for this message
Martin Pitt (pitti) wrote :

Instead of creating a new profile and switching users to it, can we change the default profile in the schema instead?

For that to work, we need to

 * fix g-t to not set user-specific keys unless you change them (it does right now)

 * change the migration patches to unset user specific keys if they are equal to the (old) default, to fix the first problem for upgrades.

Is that feasible?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I'm taking a slightly different route with this now. I'm going to drop all the changes to the profile, and instead make it possible to control the visual appearance of the terminal from the GTK theme. It's already possible to control the background / text colours from the GTK theme, but controlling transparency recquires a small patch to gnome-terminal to expose this property. I've already got a working prototype here now, but it just needs a little bit of refining tomorrow.

This will then just behave exactly like any other change in the default theme (new installs / upgrades) and is a much nicer solution than what we have currently

Changed in gnome-terminal (Ubuntu Lucid):
status: Triaged → In Progress
Changed in gnome-terminal (Ubuntu Lucid):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-terminal - 2.29.6-0ubuntu5

---------------
gnome-terminal (2.29.6-0ubuntu5) lucid; urgency=low

  * Revert the previous changes to add a new profile, as changing
    the default profile on upgrade is suboptimal, and there are better
    ways to implement the visual changes
    - Removed patches:
      + 02_rename_default_profile.patch
      + 03_add_new_profiles_on_upgrade.patch
      + 04_change_fallback_profile.patch
    - Delete debian/gnome-terminal-ambiance.schemas
    - Delete ebian/gnome-termina-data.gconf-defaults
    - debian/rules:
      + Don't install custom schema
  * Add debian/patches/02_add_transparency_properties.patch:
    - This patch allows the background transparency to be controlled from
      the GTK theme (using "TerminalScreen::background-darkness"). In
      addition to this, the background colour and text colour are already
      themable from the GTK theme (by setting the "text[NORMAL]" and
      "base[NORMAL]" colours for the TerminalScreen class)
  * debian/gnome-terminal-data.postinst:
    - Fix up the system gconf defaults when upgrading from a previous
      unstable version which had the extra profile. Users upgrading from
      this will probably still need to remove the "Ambiance" profile
      manually from their configuration though (there's not an easy way
      to do this automatically, and it only affects users upgrading
      from previous unstable versions)
  * This fixes LP: #532511 and LP: #542144
 -- Chris Coulson <email address hidden> Tue, 23 Mar 2010 21:41:22 +0000

Changed in gnome-terminal (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers