color scheme Solarized Dark is incorrect

Bug #1768178 reported by popstas on 2018-05-01
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-terminal (Ubuntu)
Undecided
Unassigned

Bug Description

Original Solarized Dark looks different. Thereis the pull request on Github that fixes that - https://github.com/GNOME/gnome-terminal/pull/6

I'm not author of patch and don't checked it, but there is project that change color scheme to correct, it described here - https://github.com/Anthony25/gnome-terminal-colors-solarized/tree/master/colors/dark

Here is built-in palette collected with gsettings get:
['#2E3436',
'#CC0000',
'#4E9A06',
'#C4A000',
'#3465A4',
'#75507B',
'#06989A',
'#D3D7CF',
'#555753',
'#EF2929',
'#8AE234',
'#FCE94F',
'#729FCF',
'#AD7FA8',
'#34E2E2',
'#EEEEEC']

Here is correct palette:
['#070736364242',
'#DCDC32322F2F',
'#858599990000',
'#B5B589890000',
'#26268B8BD2D2',
'#D3D336368282',
'#2A2AA1A19898',
'#EEEEE8E8D5D5',
'#00002B2B3636',
'#CBCB4B4B1616',
'#58586E6E7575',
'#65657B7B8383',
'#838394949696',
'#6C6C7171C4C4',
'#9393A1A1A1A1',
'#FDFDF6F6E3E3']

I asked the question about long codes - https://github.com/Anthony25/gnome-terminal-colors-solarized/issues/76, but anyway it matches original scheme perfectly.

I created bug at launchpad because Gnome restricted creating bugs for non-gnome developers in their guide https://wiki.gnome.org/Apps/Terminal/ReportingBugs and point to distribution bug tracker.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: gnome-terminal 3.28.1-1ubuntu1
ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
Uname: Linux 4.15.0-20-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Tue May 1 07:49:18 2018
InstallationDate: Installed on 2018-04-29 (1 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180426)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=ru_RU.UTF-8
 SHELL=/usr/bin/zsh
SourcePackage: gnome-terminal
UpgradeStatus: No upgrade log present (probably fresh install)

popstas (popstas) wrote :
Egmont Koblinger (egmont-gmail) wrote :

> Here is built-in palette collected with gsettings get:
> ['#2E3436',
> '#CC0000',
> [...]

Could you please elaborate, what are the exact steps you took that gave this result? What steps did you perform in gnome-terminal's Preferences dialog, what additional scripts did you run (if any, e.g. Anthony25's one that you linked), and what gsettings command exactly gave this answer?

Please note that Anthony25's script pre-dates gnome-terminal shipping Solarized out of the box, and is unnecessary since then.

> Here is correct palette:
> ['#070736364242',
> '#DCDC32322F2F',
> [...]

Indeed this is the correct one, and this is the one present in gnome-terminal's source, which your linked patch changes to a different one. [Note that #121234345656 is equivalent to #123456, and represented in gnome-terminal's source as COLOR (0x12, 0x34, 0x56).]

(gnome-terminal has been shipping Solarized for 4 years now, I find it pretty unlikely that after 4 years you're the first to spot that it's broken. I would bet that it's something you messed up on your side.)

Please uncheck the "Show bold text in bright colors" checkbox at the bottom of the Color settings page, and demonstrate with screenshots if you still don't get the expected result, thanks!

popstas (popstas) wrote :

Oh, sorry, of course, I missed that background color scheme and palette scheme are dedicated and selected only first scheme, but not palette scheme (was selected Tango).

Confirm that built-in scheme is correct.

Egmont Koblinger (egmont-gmail) wrote :

> I missed that background color scheme and palette scheme are dedicated and selected only first scheme, but not palette scheme (was selected Tango).

This is indeed misleading and we're thinking about changing the behavior. Ideally you'd just select "Solarized dark" at one place, and this would set the fg/bg and palette colors, and even disable the aforementioned "show bold in bright". It's unclear though for us how this could be done in a way that doesn't at the same time introduce a usability regression for those who prefer traditional (non-solarized) color schemes: they'd still want to select fg/bg and palette independently from each other according to their personal preferences.

popstas (popstas) wrote :

Are you mean new abstraction, third place, preset for background, palette and other? I think it will more intuitive if all settings will be hidden to "Advanced settings" section.

Jetbrains implemented something like this in their IDE's - https://i.imgur.com/ig89M4G.png

More simple way: add link to documentation describing complex scheme details.

Egmont Koblinger (egmont-gmail) wrote :

> Are you mean new abstraction, third place, preset for background, palette and other?

We don't know yet how the user interface would look like.

Egmont Koblinger (egmont-gmail) wrote :

Submitted https://git.gnome.org/browse/gnome-terminal/commit/?id=e8ee9f786 to make it more obvious that we indeed define the Solarized palette correctly.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers