Use mainstream theme solution for gnome-terminal, drop patch

Bug #1726555 reported by Egmont Koblinger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu theme
Won't Fix
Undecided
Unassigned
gnome-terminal (Ubuntu)
Won't Fix
Undecided
Unassigned
ubuntu-themes (Ubuntu)
Won't Fix
Undecided
Unassigned

Bug Description

Ubuntu adds a patch called "0001-Add-style-classes-and-CSS-names-to-some-of-our-widge.patch" to gnome-terminal, and in turn Ambiance and Radiance themes' apps/gnome-terminal.css relies on this to get the desired look for the notebook widget.

Beginning with gnome-terminal 3.20.3 / 3.22.1 this should no longer be necessary. It's just an additional burden to carry this patch, plus an unnecessary complication for those who wish to manually compile gnome-terminal for whatever reason.

gnome-terminal.css should ideally be modified to use the CSS names provided by mainstream gnome-terminal, and once done, the gnome-terminal patch can be dropped.

Upstream references:
https://bugzilla.gnome.org/show_bug.cgi?id=765590
https://bugzilla.gnome.org/show_bug.cgi?id=772134#c6
https://bugzilla.gnome.org/show_bug.cgi?id=788044

Tags: artful
affects: light-themes (Ubuntu) → ubuntu-themes (Ubuntu)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thank you for reporting this bug to Ubuntu.

Ubuntu 17.10 (artful) reached end-of-life on July 19, 2018.

See this document for currently supported Ubuntu releases:
https://wiki.ubuntu.com/Releases

We appreciate that this bug may be old and you might not be interested in discussing it any more. But if you are then please upgrade to the latest Ubuntu version and re-test. If you then find the bug is still present in the newer Ubuntu version, please add a comment here telling us which new version it is in.

Changed in ubuntu-themes:
status: New → Won't Fix
Changed in gnome-terminal (Ubuntu):
status: New → Won't Fix
Changed in ubuntu-themes (Ubuntu):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.