don't ignore OobsResult in a callback function

Bug #1411610 reported by Vlad Orlov on 2015-01-16
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-system-tools (Debian)
Fix Released
Unknown
gnome-system-tools (Ubuntu)
Undecided
Unassigned
Trusty
Medium
Brian Murray
Utopic
Medium
Brian Murray

Bug Description

[Impact]

Users don't receive any info about the errors in the backends (liboobs and system-tools-backends) when they run users-admin tool (unless they run it from the terminal).

It's already fixed in Debian and Ubuntu 15.04, but the package remains unpatched in 14.04 and 14.10.

The attached patch makes users-admin show the message dialog with the description of the error that happened.

[Test Case]

You'll need unpatched versions of liboobs (3.0.0-1) and system-tools-backends (2.10.2-1ubuntu1) installed.
Run users-admin from the terminal. You'll see a warning message in the terminal:

Liboobs-WARNING **: There was an unknown error communicating asynchronously with the backends: Launch helper exited with unknown return code 255

But the users-admin GUI won't show this message - that's the bug.

[Regression Potential]

I consider the regression risk to be low here. The patch has been already tested by me and gnome-system-tools maintainer in Debian (see the corresponding Debian bug report).

Changed in gnome-system-tools (Debian):
status: Unknown → Fix Released

The attachment "Patch - don't ignore OobsResult in a callback function." seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Brian Murray (brian-murray) wrote :

Could you add this information to the bug report so that we can proceed with fixing this in Utopic and Trusty? Thanks!

https://wiki.ubuntu.com/StableReleaseUpdates/#SRU_Bug_Template

Changed in gnome-system-tools (Ubuntu):
status: New → Fix Released
Changed in gnome-system-tools (Ubuntu Trusty):
status: New → Triaged
Changed in gnome-system-tools (Ubuntu Utopic):
status: New → Triaged
Changed in gnome-system-tools (Ubuntu Trusty):
importance: Undecided → Medium
Changed in gnome-system-tools (Ubuntu Utopic):
importance: Undecided → Medium
summary: - patch - don't ignore OobsResult in a callback function
+ don't ignore OobsResult in a callback function
Vlad Orlov (monsta) wrote :

Brian, I've changed the description to match SRU Bug Template.

description: updated
Changed in gnome-system-tools (Ubuntu Utopic):
assignee: nobody → Brian Murray (brian-murray)
Changed in gnome-system-tools (Ubuntu Trusty):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Changed in gnome-system-tools (Ubuntu Utopic):
status: Triaged → In Progress
Brian Murray (brian-murray) wrote :

I've uploaded fixes for this bug to the Trusty and Utopic -proposed queues, thanks!

Hello Monsta, or anyone else affected,

Accepted gnome-system-tools into utopic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-system-tools/3.0.0-3ubuntu5.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-system-tools (Ubuntu Utopic):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in gnome-system-tools (Ubuntu Trusty):
status: In Progress → Fix Committed
Brian Murray (brian-murray) wrote :

Hello Monsta, or anyone else affected,

Accepted gnome-system-tools into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-system-tools/3.0.0-3ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Vlad Orlov (monsta) wrote :

Brian, I've tested the packages in both Trusty and Utopic, looks good to me.

tags: added: verification-done
removed: verification-needed

The verification of the Stable Release Update for gnome-system-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-system-tools - 3.0.0-3ubuntu5.1

---------------
gnome-system-tools (3.0.0-3ubuntu5.1) utopic; urgency=medium

  [ Vlad Orlov ]
  * dont-ignore-oobsresult.patch: new patch. Don't ignore OobsResult in a
    callback function, show the message dialog instead (LP: #1411610).
 -- Brian Murray <email address hidden> Fri, 23 Jan 2015 13:15:15 -0800

Changed in gnome-system-tools (Ubuntu Utopic):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-system-tools - 3.0.0-3ubuntu4.1

---------------
gnome-system-tools (3.0.0-3ubuntu4.1) trusty; urgency=medium

  [ Vlad Orlov ]
  * dont-ignore-oobsresult.patch: new patch. Don't ignore OobsResult in a
    callback function, show the message dialog instead (LP: #1411610).
 -- Brian Murray <email address hidden> Fri, 23 Jan 2015 12:57:45 -0800

Changed in gnome-system-tools (Ubuntu Trusty):
status: Fix Committed → Fix Released
Vlad Orlov (monsta) wrote :

Thank you!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.