Snap mounts should be hidden from System Monitor

Bug #1749007 reported by Ads20000 on 2018-02-12
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
gnome-system-monitor (Ubuntu)
Low
Andrea Azzarone
libgtop2 (Ubuntu)
Low
Unassigned
Bionic
Undecided
Unassigned

Bug Description

* Impact
snaps mount at listed in the system monitor but they are an implementation detail and not interesting there. We already filter them out of the Disks UI, we should do the same in the system monitor

* Test case
- have a snap installed (wshich is true in the default installation of Ubuntu)
- open gnome-system-monitor
- check the filesystem tabs content, snaps mounts shouldn't be listed

* Regression potential
Check that the system mounted partitions are still correctly listed

------

As per https://community.ubuntu.com/t/snaps-in-system-monitor/3961 the snap mounts in System Monitor should be hidden just as they're hidden from GNOME Disks. Perhaps they should be grouped under a dropdown of / (though this would require developing a new feature)?

Ads20000 (ads20000) wrote :
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-system-monitor (Ubuntu):
status: New → Confirmed
Sebastien Bacher (seb128) wrote :

Could be a nice improvement to look at but for after feature freeze rather

Changed in gnome-system-monitor (Ubuntu):
importance: Undecided → Low
assignee: nobody → Andrea Azzarone (azzar1)
Andrea Azzarone (azzar1) on 2018-03-26
Changed in gnome-system-monitor (Ubuntu):
status: Confirmed → In Progress
Sebastien Bacher (seb128) wrote :

That's being discussed upstream on https://gitlab.gnome.org/GNOME/libgtop/issues/38

Andrea Azzarone (azzar1) wrote :

It is going to take some time to merge the patch upstream. For the moment the patch in the attached debdiff should make the work.

The attachment "libgtop2.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Sebastien Bacher (seb128) wrote :

the patch looks fine but it's a bit weird to add the new argument to the function to the begin of the arguments and not the end, though the API is not public so it shouldn't really matter. It looks fine to me for a SRU so I'm going to sponsor it this week

description: updated
Changed in libgtop2 (Ubuntu):
importance: Undecided → Low
status: New → In Progress
Sebastien Bacher (seb128) wrote :

tweaked the version and fixed the email address and uploaded

Changed in libgtop2 (Ubuntu):
status: In Progress → Fix Committed

Hello Ads20000, or anyone else affected,

Accepted libgtop2 into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libgtop2/2.38.0-2ubuntu0.18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libgtop2 (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Ads20000 (ads20000) wrote :

I've followed the instructions at https://wiki.ubuntu.com/Testing/EnableProposed with pinning and /bionic-proposed and get 'E: Unable to locate package libgtop2' :( Could someone who knows the proper procedure update that article or what am I doing wrong? :)

Sebastien Bacher (seb128) wrote :

You maybe tried before the package was actually built?

You can also try by downloading the debs on https://launchpad.net/ubuntu/+source/libgtop2/2.38.0-2ubuntu0.18.04.1/+build/14822012

$ wget https://launchpad.net/ubuntu/+source/libgtop2/2.38.0-2ubuntu0.18.04.1/+build/14822012/+files/libgtop2-common_2.38.0-2ubuntu0.18.04.1_all.deb https://launchpad.net/ubuntu/+source/libgtop2/2.38.0-2ubuntu0.18.04.1/+build/14822012/+files/libgtop-2.0-11_2.38.0-2ubuntu0.18.04.1_amd64.deb
$ sudo dpkg -i *.deb
$ gnome-system-monitor

but that's testing the deb version of gnome-system-monitor, the snap is going to be rebuilt to use the change...

mouad (zeronoid) wrote :

It's work but I installed the standard gnome-system-monitor not the snap.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libgtop2 - 2.38.0-2ubuntu0.18.04.1

---------------
libgtop2 (2.38.0-2ubuntu0.18.04.1) bionic; urgency=medium

  * debian/patches/05-mountlist-ignore-snap-squashfs.patch: Ignore
    squashfs mounted in /snap (LP: #1749007).

 -- Andrea Azzarone <email address hidden> Thu, 19 Apr 2018 16:05:53 +0200

Changed in libgtop2 (Ubuntu):
status: Fix Committed → Fix Released
tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Changed in libgtop2 (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for libgtop2 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers