Undo doesn't work: gnome-sudoku crashed with TypeError in set_value(): unorderable types: int() < NoneType()

Bug #1272716 reported by Vassili Platonov on 2014-01-25
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
gnome-sudoku (Ubuntu)
Medium
Unassigned
Trusty
Medium
Unassigned

Bug Description

Impact:
using "undo" sometime hits an error

Test Case:
- run gnome-sudoku
- start an easy game
- enter a number somewhere
- click on undo

-> it should undo and not trigger an error dialog

Regression potential:
check that undo keeps working correctly

Vassili Platonov (vassilip) wrote :
information type: Private → Public
tags: removed: need-duplicate-check
Changed in gnome-sudoku (Ubuntu):
importance: Undecided → Medium
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-sudoku (Ubuntu):
status: New → Confirmed
Jane Atkinson (irihapeti) wrote :

Same behaviour. Choosing Undo causes Apport window to appear.

gnome-sudoku crashed in all versions of ubuntu based on 14.04 32 and 64
bits xubunt and lubuntu included

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

summary: - gnome-sudoku crashed with TypeError in set_value(): unorderable types:
- int() < NoneType()
+ Undo doesn't work: gnome-sudoku crashed with TypeError in set_value():
+ unorderable types: int() < NoneType()
tags: added: utopic
Changed in gnome-sudoku (Ubuntu):
status: Confirmed → Fix Committed
Sebastien Bacher (seb128) wrote :

@Bryan: thanks, I've backported/uploaded that commit (and confirmed it fixes the issue in the "undo with 1 number of the grid" which is described in the upstream description)

description: updated
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-sudoku - 1:3.10.2-0ubuntu4

---------------
gnome-sudoku (1:3.10.2-0ubuntu4) utopic; urgency=medium

  * debian/patches/git_working_undo.patch:
    - "This fixes undo when only one number is on the board." (lp: #1272716)
 -- Sebastien Bacher <email address hidden> Tue, 03 Jun 2014 11:29:26 +0200

Changed in gnome-sudoku (Ubuntu):
status: Fix Committed → Fix Released

Hello Vassili, or anyone else affected,

Accepted gnome-sudoku into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnome-sudoku/1:3.10.2-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
tags: added: verification-done
removed: verification-needed
Vassili Platonov (vassilip) wrote :

Yes, it works:

$ apt-cache policy gnome-sudoku
gnome-sudoku:
  Установлен: 1:3.10.2-0ubuntu3
  Кандидат: 1:3.10.2-0ubuntu3
  Таблица версий:
 *** 1:3.10.2-0ubuntu3 0
        500 http://archive.ubuntu.com/ubuntu/ trusty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     1:3.10.2-0ubuntu2 0
        500 http://archive.ubuntu.com/ubuntu/ trusty/main i386 Packages

Great work, tnx!

Chris J Arges (arges) on 2014-06-10
Changed in gnome-sudoku (Ubuntu Trusty):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-sudoku - 1:3.10.2-0ubuntu3

---------------
gnome-sudoku (1:3.10.2-0ubuntu3) trusty; urgency=medium

  * debian/patches/git_working_undo.patch:
    - "This fixes undo when only one number is on the board." (lp: #1272716)
 -- Sebastien Bacher <email address hidden> Tue, 03 Jun 2014 11:29:26 +0200

Changed in gnome-sudoku (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-sudoku has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Changed in gnome-sudoku (Ubuntu Trusty):
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.