Use ODRS for reviews

[Robert Ancell]

[Impact]
The Ubuntu review server is being retired which will cause all Ubuntu package reviews to stop working. We are switching to using the Open Desktop Review Service (https://odrs.gnome.org/). This plugin has existed for sometime in the GNOME Software source, so it is well tested. This change will allow Snap packages to be reviewed (new feature).

[Test Case]
1. Open GNOME Software
2. Select a popular app (e.g. Firefox)

[Expected Result]
Reviews are shown for this package. They will be different to the previous reviews. You are able to create reviews for both .deb and snap apps.

[Regression Potential]
There is a risk of new bugs encountered in the ODRS plugin. This has been enabled in Disco without major issue and has been used in other distributions for many releases.

[Sebastien Bacher (seb128)]

Robert uploaded to the cosmic SRU queue

[Steve Langasek (vorlon)]

An upload of gnome-software to cosmic-proposed has been rejected from the upload queue for the following reason: "reuploading with different -v option to avoid listing LP: #1799614 which is *un*fixed in this version".

[Steve Langasek (vorlon)]

Hello Robert, or anyone else affected,

Accepted gnome-software into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.30.2-0ubuntu10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robert Ancell (robert-ancell)]

Tested gnome-software 3.30.2-0ubuntu10 in Ubuntu 18.10. Able to see reviews for snaps and debs and write reviews.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.30.2-0ubuntu10

---------------
gnome-software (3.30.2-0ubuntu10) cosmic; urgency=medium

  * debian/rules:
    - Switch from deprecated Ubuntu reviews to ODRS (LP: #1815708)
  * debian/patches/0025-snap-Use-new-media-API.patch:
  * debian/control:
    - Disable for now, still blocked on snapd-glib update

 -- Robert Ancell <email address hidden> Thu, 14 Feb 2019 11:52:46 +1300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Brian Murray (brian-murray)]

Hello Robert, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robert Ancell (robert-ancell)]

Tested gnome-software 3.28.1-0ubuntu4.18.04.9 and able to see and enter reviews.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.28.1-0ubuntu4.18.04.9

---------------
gnome-software (3.28.1-0ubuntu4.18.04.9) bionic; urgency=medium

  * debian/rules:
    - Disable ubuntu-reviews plugin (use ODRS instead)
  * debian/patches/0028-Added-u2f-devices-to-interfaces-UI.patch:
    - Allow connections on the u2f-devices interface (LP: #1738164)
  * debian/patches/0029-snap-Use-ODRS-for-reviews.patch:
    - Review snaps using ODRS review server (LP: #1815708)

 -- Robert Ancell <email address hidden> Wed, 27 Feb 2019 16:16:54 +1300