gnome-software can't handle composite CAB files

Bug #1798470 reported by Mario Limonciello on 2018-10-17
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Medium
Robert Ancell
Bionic
Medium
Robert Ancell
Cosmic
Medium
Robert Ancell

Bug Description

[Impact]

Double clicking a composite CAB file containing multiple firmware files displays an error message in gnome-software.

This prevents installing composite firmware CAB files via a GUI unless they come from LVFS.

[Test Case]

 * Double click a composite CAB file
 * Make sure that it display in gnome software

[Regression Potential]

 * Regression potential is low. The new code paths are only run when processing a CAB file with multiple payloads.

[Other info]

This patch is available here: https://gitlab.gnome.org/GNOME/gnome-software/commit/77248099f966cfbaa45542e2838b4b84a18e738f

Related branches

Changed in gnome-software (Ubuntu):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Bionic):
assignee: nobody → Robert Ancell (robert-ancell)
Robert Ancell (robert-ancell) wrote :

Change queued up for gnome-software 3.28.1-0ubuntu4.18.04.5 SRU

Changed in gnome-software (Ubuntu Bionic):
status: New → Fix Committed
importance: Undecided → Medium
Changed in gnome-software (Ubuntu):
status: New → Fix Committed
no longer affects: gnome-software (Ubuntu Dd-series)
Changed in gnome-software (Ubuntu Cosmic):
importance: Undecided → Medium

Hello Mario, or anyone else affected,

Accepted gnome-software into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.30.2-0ubuntu7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-cosmic
Mario Limonciello (superm1) wrote :

$ gnome-software --version
gnome-software 3.30.2
$ xdg-open DellUsbCDockFirmwareUpdateLinux_00.00.07.cab

Now does the right thing

tags: added: verification-done-cosmic
removed: verification-needed-cosmic
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.30.2-0ubuntu7

---------------
gnome-software (3.30.2-0ubuntu7) cosmic; urgency=medium

  * debian/patches/0001-Use-correct-boolean-type-for-GsPluginJob-interactive.patch:
    - Fix crashes in 32 bit architectures (LP: #1798236)

gnome-software (3.30.2-0ubuntu6) cosmic; urgency=medium

  * debian/patches/0001-lib-Allow-opening-CAB-files-that-resolve-more-than-o.patch:
    - Support composite CAB files (LP: #1798470)

 -- Robert Ancell <email address hidden> Thu, 18 Oct 2018 11:14:33 +1300

Changed in gnome-software (Ubuntu Cosmic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Hello Mario, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
Mario Limonciello (superm1) wrote :

I've upgraded on a bionic machine to 3.28.1-0ubuntu4.18.04.5.

xdg-open FirmwareUpdateLinux_00.00.07.cab opens a composite CAB file in gnome-software now.

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: added: verification-done
removed: verification-needed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers