Snap search results not in the same order as command line
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| gnome-software (Ubuntu) |
Medium
|
Robert Ancell | ||
| Xenial |
Medium
|
Unassigned | ||
| Bionic |
Medium
|
Robert Ancell | ||
| Cosmic |
Medium
|
Robert Ancell |
Bug Description
[Impact]
When searching in GNOME Software, the Snap results are not returned in the same order as the command line. This is due to classic snaps being considered a lower quality than strict snaps.
[Test Case]
1. Open GNOME Software
2. Search for "sky"
Expected result:
Snaps matching "sky" are returned, with the same order as the command line (Skype is first)
Observed result:
While mostly in the same order, some snaps are not (Skype is the last snap in the list, in eighth position).
[Regression Potential]
The fix is to set the "match value" of each Snap GsApp to be the order the results are returned in. This field is checked before the "kudo" field which is populated based on the confinement used.
Related branches
- Ubuntu Desktop: Pending requested 2018-11-08
-
Diff: 1805 lines (+1274/-5) (has conflicts)19 files modifieddebian/changelog (+65/-5)
debian/control (+13/-0)
debian/control.in (+8/-0)
debian/gbp.conf (+7/-0)
debian/patches/0001-Set-reboot-notifications-as-urgent-to-avoid-them-tim.patch (+27/-0)
debian/patches/0001-lib-Allow-opening-CAB-files-that-resolve-more-than-o.patch (+11/-0)
debian/patches/0001-snap-plugin-segfault.patch (+32/-0)
debian/patches/0003-Sort-snaps-before-other-apps.patch (+14/-0)
debian/patches/0006-packagekit-Disable-updates.patch (+31/-0)
debian/patches/0011-Support-snap-channels.patch (+158/-0)
debian/patches/0014-Add-a-basic-permissions-system.patch (+53/-0)
debian/patches/0020-Show-verified-developers.patch (+217/-0)
debian/patches/0021-snap-Use-wide-scope-when-searching.patch (+70/-0)
debian/patches/0022-Delay-startup-of-GNOME-Software-to-allow-the-Shell-t.patch (+25/-0)
debian/patches/0023-Revert-Revert-flatpak-Use-list-of-related-apps-for-i.patch (+114/-0)
debian/patches/0024-flatpak-Check-if-a-related-app-is-installed-even-whe.patch (+37/-0)
debian/patches/0025-flatpak-Include-related-refs-to-the-app-s-runtime-on.patch (+192/-0)
debian/patches/0026-shell-search-provider-implement-XUbuntuCancel.patch (+176/-0)
debian/patches/series (+24/-0)
Changed in gnome-software (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Cosmic): | |
status: | New → Fix Committed |
Changed in gnome-software (Ubuntu Bionic): | |
status: | New → Fix Committed |
Changed in gnome-software (Ubuntu Xenial): | |
status: | New → Won't Fix |
Changed in gnome-software (Ubuntu Bionic): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in gnome-software (Ubuntu Cosmic): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Launchpad Janitor (janitor) wrote : | #1 |
Changed in gnome-software (Ubuntu Cosmic): | |
status: | Fix Committed → Fix Released |
Hello Robert, or anyone else affected,
Accepted gnome-software into bionic-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
tags: | added: verification-needed verification-needed-bionic |
Will Cooke (willcooke) wrote : | #3 |
Running gnome-software from proposed:
apt-cache policy gnome-software
gnome-software:
Installed: 3.28.1-
Candidate: 3.28.1-
Version table:
*** 3.28.1-
500 http://
100 /var/lib/
3.
500 http://
3.
500 http://
Opened g-s, searched for "Sky", and Skype was the top result, as is expected.
Passed.
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
tags: |
added: verification-done removed: verification-needed |
Robert Ancell (robert-ancell) wrote : | #4 |
Will - can you confirm this is still fixed in 3.28.1-
Chris Halse Rogers (raof) wrote : | #5 |
Hello Robert, or anyone else affected,
Accepted gnome-software into bionic-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
tags: |
added: verification-needed verification-needed-bionic removed: verification-done verification-done-bionic |
Will Cooke (willcooke) wrote : | #6 |
I have:
$ apt-cache policy gnome-software
gnome-software:
Installed: 3.28.1-
Candidate: 3.28.1-
Version table:
*** 3.28.1-
500 http://
100 /var/lib/
3.
500 http://
3.
500 http://
I redid the tests and I can confirm that everything is as expected. "Sky" generates the same results in the same order from cli and from G-S.
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
Launchpad Janitor (janitor) wrote : | #7 |
This bug was fixed in the package gnome-software - 3.28.1-
---------------
gnome-software (3.28.1-
* Re-released to generate correct .changes file
gnome-software (3.28.1-
* debian/rules:
* debian/
- Build with PackageKit autoremove support (LP: #1552792)
* debian/control:
* debian/
- Stop cancelling snapd authorization triggers error notification
(LP: #1785240)
gnome-software (3.28.1-
* debian/
* debian/
* debian/
- Disable the Flatpak changes - SRU testing showed they broke downgrades
gnome-software (3.28.1-
* debian/
* debian/
* debian/
- Pull related flatpak refs (LP: #1754864)
* debian/
- Fix snap search result ordering (LP: #1798228)
* debian/
- Stop reboot notification from timing out (LP: #1719797)
* debian/
- Support composite CAB files (LP: #1798470)
-- Robert Ancell <email address hidden> Wed, 21 Nov 2018 12:29:27 +1300
Changed in gnome-software (Ubuntu Bionic): | |
status: | Fix Committed → Fix Released |
The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.
This bug was fixed in the package gnome-software - 3.30.2-0ubuntu5
---------------
gnome-software (3.30.2-0ubuntu5) cosmic; urgency=medium
* debian/ patches/ 0003-Sort- snaps-before- other-apps. patch:
- Fix snap search result ordering (LP: #1798228)
-- Robert Ancell <email address hidden> Wed, 17 Oct 2018 14:05:06 +1300