Snap search results not in the same order as command line
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gnome-software (Ubuntu) |
Fix Released
|
Medium
|
Robert Ancell | ||
Xenial |
Won't Fix
|
Medium
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Robert Ancell | ||
Cosmic |
Fix Released
|
Medium
|
Robert Ancell |
Bug Description
[Impact]
When searching in GNOME Software, the Snap results are not returned in the same order as the command line. This is due to classic snaps being considered a lower quality than strict snaps.
[Test Case]
1. Open GNOME Software
2. Search for "sky"
Expected result:
Snaps matching "sky" are returned, with the same order as the command line (Skype is first)
Observed result:
While mostly in the same order, some snaps are not (Skype is the last snap in the list, in eighth position).
[Regression Potential]
The fix is to set the "match value" of each Snap GsApp to be the order the results are returned in. This field is checked before the "kudo" field which is populated based on the confinement used.
Related branches
- Ubuntu Desktop: Pending requested
-
Diff: 1805 lines (+1274/-5) (has conflicts)19 files modifieddebian/changelog (+65/-5)
debian/control (+13/-0)
debian/control.in (+8/-0)
debian/gbp.conf (+7/-0)
debian/patches/0001-Set-reboot-notifications-as-urgent-to-avoid-them-tim.patch (+27/-0)
debian/patches/0001-lib-Allow-opening-CAB-files-that-resolve-more-than-o.patch (+11/-0)
debian/patches/0001-snap-plugin-segfault.patch (+32/-0)
debian/patches/0003-Sort-snaps-before-other-apps.patch (+14/-0)
debian/patches/0006-packagekit-Disable-updates.patch (+31/-0)
debian/patches/0011-Support-snap-channels.patch (+158/-0)
debian/patches/0014-Add-a-basic-permissions-system.patch (+53/-0)
debian/patches/0020-Show-verified-developers.patch (+217/-0)
debian/patches/0021-snap-Use-wide-scope-when-searching.patch (+70/-0)
debian/patches/0022-Delay-startup-of-GNOME-Software-to-allow-the-Shell-t.patch (+25/-0)
debian/patches/0023-Revert-Revert-flatpak-Use-list-of-related-apps-for-i.patch (+114/-0)
debian/patches/0024-flatpak-Check-if-a-related-app-is-installed-even-whe.patch (+37/-0)
debian/patches/0025-flatpak-Include-related-refs-to-the-app-s-runtime-on.patch (+192/-0)
debian/patches/0026-shell-search-provider-implement-XUbuntuCancel.patch (+176/-0)
debian/patches/series (+24/-0)
Changed in gnome-software (Ubuntu Cosmic): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in gnome-software (Ubuntu Cosmic): | |
status: | New → Fix Committed |
Changed in gnome-software (Ubuntu Bionic): | |
status: | New → Fix Committed |
Changed in gnome-software (Ubuntu Xenial): | |
status: | New → Won't Fix |
Changed in gnome-software (Ubuntu Bionic): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
Changed in gnome-software (Ubuntu Cosmic): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
This bug was fixed in the package gnome-software - 3.30.2-0ubuntu5
---------------
gnome-software (3.30.2-0ubuntu5) cosmic; urgency=medium
* debian/ patches/ 0003-Sort- snaps-before- other-apps. patch:
- Fix snap search result ordering (LP: #1798228)
-- Robert Ancell <email address hidden> Wed, 17 Oct 2018 14:05:06 +1300