Snap search results not in the same order as command line

[Robert Ancell]

[Impact]
When searching in GNOME Software, the Snap results are not returned in the same order as the command line. This is due to classic snaps being considered a lower quality than strict snaps.

[Test Case]
1. Open GNOME Software
2. Search for "sky"

Expected result:
Snaps matching "sky" are returned, with the same order as the command line (Skype is first)

Observed result:
While mostly in the same order, some snaps are not (Skype is the last snap in the list, in eighth position).

[Regression Potential]
The fix is to set the "match value" of each Snap GsApp to be the order the results are returned in. This field is checked before the "kudo" field which is populated based on the confinement used.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.30.2-0ubuntu5

---------------
gnome-software (3.30.2-0ubuntu5) cosmic; urgency=medium

  * debian/patches/0003-Sort-snaps-before-other-apps.patch:
    - Fix snap search result ordering (LP: #1798228)

 -- Robert Ancell <email address hidden> Wed, 17 Oct 2018 14:05:06 +1300

[Brian Murray (brian-murray)]

Hello Robert, or anyone else affected,

Accepted gnome-software into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.28.1-0ubuntu4.18.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Will Cooke (willcooke)]

Running gnome-software from proposed:

 apt-cache policy gnome-software
gnome-software:
  Installed: 3.28.1-0ubuntu4.18.04.5
  Candidate: 3.28.1-0ubuntu4.18.04.5
  Version table:
 *** 3.28.1-0ubuntu4.18.04.5 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.28.1-0ubuntu4.18.04.4 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     3.28.1-0ubuntu4 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

Opened g-s, searched for "Sky", and Skype was the top result, as is expected.

Passed.