Many JsonArray critical warnings on command line

Bug #1790563 reported by Robert Ancell on 2018-09-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Low
Unassigned
Xenial
Low
Robert Ancell

Bug Description

[Impact]
Running GNOME Software gives many JsonArray warnings on the command line:
Json-CRITICAL **: json_object_get_array_member: assertion 'node != NULL' failed
Json-CRITICAL **: json_array_get_length: assertion 'array != NULL' failed
This is due to the code not handling there being no plugs defined in the interface table (which is valid when it is empty).

[Test Case]
1. Run GNOME Software from the command line
$ killall gnome-software
$ gnome-software

Expected result:
No JsonArray critical warnings are show.

Observed result:
Many JsonArray critical warnings are show.

[Regression Potential]
Risk of additional checks breaking expected behaviour.

Changed in gnome-software (Ubuntu):
status: New → Fix Released
importance: Undecided → Low
Changed in gnome-software (Ubuntu Xenial):
importance: Undecided → Low
status: New → Fix Committed
assignee: nobody → Robert Ancell (robert-ancell)
summary: - Many JsonArray warnings on command line
+ Many JsonArray critical warnings on command line

An upload of gnome-software to xenial-proposed has been rejected from the upload queue for the following reason: "Since this upload includes the same change for 'new media API' as others, I would feel much safer if we set a minimal version depenency to libsnapd-glib-dev (>= 1.45) - since it seems there was more than one snapd-glib version in xenial.".

Hello Robert, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-xenial
Robert Ancell (robert-ancell) wrote :

Tested gnome-software 3.20.5-0ubuntu0.16.04.12 and it no longer shows the critical warnings.

tags: added: verification-done-xenial
removed: verification-needed verification-needed-xenial
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.12

---------------
gnome-software (3.20.5-0ubuntu0.16.04.12) xenial; urgency=medium

  * debian/patches/0001-Fix-potential-crash-when-icons-are-missing.patch:
    - Fix crash loading icons (LP: #1778135)
  * debian/patches/0020-Add-a-basic-permissions-system.patch:
    - Fix crash when have plugs with multiple slots available (LP: #1778160)
  * debian/patches/0021-Add-a-Snap-plugin.patch
    - Fix some command line warnings (LP: #1790563)
    - Use new snapd media API (LP: #1799614)
    - Allow connections on the u2f-devices interface (LP: #1738164)
  * debian/patches/0053-Don-t-reject-unexpected-state-changes-external-event.patch:
    - Fix snaps not being shown correctly after install from command line
      (LP: #1754655)
  * debian/patches/0054-Show-verified-developers.patch:
    - Show verified developers (LP: #1789336)

 -- Robert Ancell <email address hidden> Wed, 17 Apr 2019 14:39:52 +1200

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers