Snaps without icons not showing

Bug #1763736 reported by frenchy82 on 2018-04-13
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Medium
Robert Ancell
Xenial
Medium
Robert Ancell
Artful
Medium
Unassigned
Bionic
Medium
Robert Ancell

Bug Description

[Impact]
Snaps that do not provide icons do not show in GNOME Software. They do show on the snapcraft.io website using a default icon.

[Test Case]
1. Open GNOME Software
2. Search for "communitheme"

Expected result:
Community Theme snap shows, using an appropriate icon.

Observed result (2 May 2018):
Community Theme snap does not show. Note that if the snap is updated in the store this behaviour will change - so will have to check another snap.

[Regression Potential]
The fix adds the default icon to snaps that do not have one. This will cause more snaps to show, which could expose new bugs.

Didier Roche (didrocks) wrote :

Adding rls-bb-incoming to inspect the difference between 16.04 and bionic. Happy to modify the snap as needed.

tags: added: rls-bb-incoming
summary: - communitheme not present in gnome software
+ communitheme not present in gnome software on bionic, but it is on 16.04
summary: - communitheme not present in gnome software on bionic, but it is on 16.04
+ communitheme snap not present in gnome software on bionic, but it is on
+ 16.04

I've confirmed this on bionic, the snap is not found in the search.

Changed in gnome-software (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Robert Ancell (robert-ancell)
Robert Ancell (robert-ancell) wrote :

The short answer is the snap package doesn't have an icon set in the store. Set that and it will show.

The longer answer is in 16.04 we use the "package-x-generic" icon, but that doesn't seem to work anymore, I think due to GNOME Software having changed the way it uses themes.

The generic icon support was dropped by upstream in the 18.04 version, so we need to distro patch it back in.

I'll also look at using the new icon the store uses:
https://assets.ubuntu.com/v1/6fbb3483-snapcraft-default-snap-icon.svg

Changed in gnome-software (Ubuntu Artful):
status: New → Won't Fix
importance: Undecided → Medium
Changed in gnome-software (Ubuntu Xenial):
importance: Undecided → Medium
status: New → Triaged
Changed in gnome-software (Ubuntu Bionic):
status: Confirmed → Triaged
Changed in gnome-software (Ubuntu Xenial):
status: Triaged → Fix Committed
Changed in gnome-software (Ubuntu Bionic):
status: Triaged → Fix Committed
Robert Ancell (robert-ancell) wrote :

I'm not sure why it seems to show for you in 16.04 but not for me, but I'm going to propose we change the icon anyway.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.28.1-0ubuntu2

---------------
gnome-software (3.28.1-0ubuntu2) bionic; urgency=medium

  * debian/patches/0017-snap-Use-default-icon-if-none-provided.patch:
    - Fix snaps without icons not showing (LP: #1763736)
  * debian/patches/0018-snap-Make-snaps-purchasable.patch:
    - Support purchasable snaps (LP: #1547135)
  * debian/patches/0001-snap-Scale-embedded-snap-icons-to-64x64.patch:
  * debian/patches/0001-snap-Only-load-icons-once.patch:
    - Fix snap icon sizes and stop duplicate loading

 -- Robert Ancell <email address hidden> Mon, 16 Apr 2018 15:32:27 +1200

Changed in gnome-software (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in gnome-software (Ubuntu Xenial):
assignee: nobody → Robert Ancell (robert-ancell)
description: updated
summary: - communitheme snap not present in gnome software on bionic, but it is on
- 16.04
+ Snaps without icons not showing

Hello frenchy82, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-xenial
frenchy82 (cartes) wrote :

As you can see in the attached file, Community Theme snap is found in the store search.

Thanks for that

tags: added: verification-done-xenial
removed: verification-needed-xenial
frenchy82 (cartes) wrote :

Tested with gnome software 3.20-5 0ubuntu0.16.04.11 from proposed

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.11

---------------
gnome-software (3.20.5-0ubuntu0.16.04.11) xenial; urgency=medium

  * debian/patches/0019-Support-channels.patch:
    - Make snap channel selection list scrollable (LP: #1768779)
  * debian/patches/0020-Add-a-basic-permission-system.patch
  * debian/patches/0021-Add-a-Snap-plugin.patch
    - Correctly handle snap install/remove failures (LP: #1762427)
    - Fix snaps without icons not showing (LP: #1763736)
    - Add basic system for connecting/disconnecting snap interfaces
      (LP: #1597314)
    - Alphabetically sort channel branch names (LP: #1769556)
  * debian/patches/0050-snap-Support-channels.patch:
    - Fix incorrect default install version being shown (LP: #1767445)

 -- Robert Ancell <email address hidden> Tue, 08 May 2018 12:02:36 +1200

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers