Report fwupd version in user agent

Bug #1750030 reported by Mario Limonciello on 2018-02-16
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Medium
Unassigned
Xenial
High
Robert Ancell

Bug Description

[Impact]
Some firmware updates fail require a recent version of fwupd to work. Upstream has requested we update the user agent sent in HTTP requests so that they can stop sending firmware to clients that may not work.

[Test Case]
Check with the fwupd server that the correct user agent is being sent.

[Regression Potential]
Low. The fix is simply to add to the user-agent string used in HTTP requests.

There are some situations that LVFS shouldn't be offering firmware to certain machines.
Upstream is going to use the user agent for filtering these firmware offerings and it would be good if gnome-software can report the user agent.

The following has been added to the gnome 3.20 tree:
https://gitlab.gnome.org/GNOME/gnome-software/commit/9bf4ecef4daa2d31827810d672458768c3c2a2b3

Can this please be backported to xenial?

Bionic can already report this as part of 3.26 gnome-software.

Changed in gnome-software (Ubuntu):
status: New → Fix Released
Changed in gnome-software (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → High
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Xenial):
status: Triaged → Fix Committed
Changed in gnome-software (Ubuntu):
importance: Undecided → Medium
description: updated
Łukasz Zemczak (sil2100) wrote :

Is this really Fix Released in bionic? The gitlab link pasted above seems to be 3 days old and I don't see the fix being mentioned in the last gnome-software version. Does the same apply for artful?

An upload of gnome-software to xenial-proposed has been rejected from the upload queue for the following reason: "Rejected due to various formalities. Please address the questions left on each of the bugs affected and re-upload. Thank you!".

Mario Limonciello (superm1) wrote :

@lukasz,

Thanks for looking closely. I double checked upstream more closely and it's in 3.27.4 not 3.26. So you're right it needs to be brought into bionic separately (or gnome-software in bionic needs to move to 3.27.x)
https://gitlab.gnome.org/GNOME/gnome-software/commit/269337e27a044d2b0543bf06a5dd725ad3cff383

Changed in gnome-software (Ubuntu):
status: Fix Released → Triaged
Mario Limonciello (superm1) wrote :

Thanks Robert.

I guess please re-upload for xenial then.

Changed in gnome-software (Ubuntu):
status: Triaged → Fix Released
Robert Ancell (robert-ancell) wrote :

Confirmed with upstream, this fix is already in bionic (3.26.6, currently 3.27.90 in proposed).

Hello Mario, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-xenial
Robert Ancell (robert-ancell) wrote :

Spoke with fwupd upstream and they have seen requests for this version.

tags: added: verification-done-xenial
removed: verification-needed verification-needed-xenial
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.10

---------------
gnome-software (3.20.5-0ubuntu0.16.04.10) xenial; urgency=medium

  * debian/patches/0020-Add-a-Snap-plugin.patch:
  * debian/patches/0015-Don-t-reject-unexpected-state-changes-external-event.patch:
    - Correctly launch snaps with multiple apps (LP: #1661590)
    - Fix snaps not being shown correctly after install from command line
      (LP: #1754655)

gnome-software (3.20.5-0ubuntu0.16.04.9) xenial; urgency=medium

  * debian/patches/0001-Make-app-name-sorting-case-insensitive.patch:
  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Show snaps in categories (LP: #1665126)
  * debian/patches/0001-trivial-Include-the-fwupd-version-in-the-useragent.patch:
    - Report fwupd version in user agent (LP: #1750030)
  * debian/patches/0050-snap-Support-channels.patch:
    - Support channels (LP: #1750288)
  * debian/README.source:
    - Update git repository to point to gitlab.gnome.org

 -- Robert Ancell <email address hidden> Wed, 28 Mar 2018 17:04:55 +1300

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers