/usr/bin/gnome-software:11:gs_plugin_snap_set_app_pixbuf_from_data:load_icon:gs_plugin_refine_app:gs_plugin_loader_run_refine:gs_plugin_loader_search_thread_cb

Bug #1708140 reported by errors.ubuntu.com bug bridge on 2017-08-02
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
High
Unassigned
Xenial
High
Unassigned
Zesty
High
Unassigned
Artful
High
Unassigned

Bug Description

[Impact]
errors.ubuntu.com [1] is showing crashes in the icon caching code. Inspection and testing of this code doesn't show any reason why this code path can occur.

[Test Case]
1. Check errors.ubuntu.com for crash reports in the icon cache code

Expected result:
Errors do not occur.

Observed result:
Errors occur.

[Regression Potential]
Some risk of introducing new bugs in the icon handling code. The code is similar to what has been released into Artful, but needed to be modified to work with the older version of gnome-software in Xenial (the Zesty change is the same as Artful).

[1] https://errors.ubuntu.com/problem/3a1f24323eae90094dc223360e9f0e56deb5e56d

Robert Ancell (robert-ancell) wrote :

The code seems to be doing:

g_autofree gchar *data = NULL;
gsize data_len;

if (g_file_get_contents (cache_fn, &data, &data_len, &local_error) &&
    gs_plugin_snap_set_app_pixbuf_from_data (app, data, data_len, &local_error))

And entering gs_plugin_snap_set_app_pixbuf_from_data with data set to NULL.

That suggests that g_file_get_contents has returned TRUE but set data to NULL.

Robert Ancell (robert-ancell) wrote :

This appears to be occurring in all currently released versions.

Robert Ancell (robert-ancell) wrote :

I didn't manage to work out why this is happening, but gnome-software 3.25.4 replaced this code with the AsIcon code and it doesn't seem to be occuring anymore. This change was backporter to 3.22 and 3.20 and should hopefully fix this issue.

Changed in gnome-software (Ubuntu Artful):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Zesty):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Xenial):
status: New → Fix Committed
importance: Undecided → High
Changed in gnome-software (Ubuntu Zesty):
importance: Undecided → High
Changed in gnome-software (Ubuntu Artful):
importance: Undecided → High
status: Fix Committed → Fix Released
description: updated

Hello errors.ubuntu.com, or anyone else affected,

Accepted gnome-software into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.22.7-0ubuntu3.17.04.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-zesty
Łukasz Zemczak (sil2100) wrote :

Hello errors.ubuntu.com, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed-xenial
Jean-Baptiste Lallement (jibel) wrote :

There is not a single crash reported against Zesty for any version including this SRU. Marking as verification-done

tags: added: verification-done-zesty
removed: verification-needed-zesty
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.22.7-0ubuntu3.17.04.7

---------------
gnome-software (3.22.7-0ubuntu3.17.04.7) zesty; urgency=medium

  * debian/patches/0001-snap-Use-title-field-if-available.patch:
    - Use new title field from snapd (LP: #1555569)
  * debian/patches/0001-snap-Remove-size-limit-on-snap-responses.patch:
  * debian/patches/0002-snap-Fix-failures-to-read-from-snapd.patch:
    - Fix icons larger than 65kB not loading (LP: #1704888)
  * debian/patches/0001-snap-Mark-non-app-snaps-as-runtimes.patch:
    - Stop 'core' snap showing as an app (LP: #1704904)
  * debian/patches/0001-snap-Fix-crash-when-fail-to-use-icon-from-cache.patch:
    - Add to debian/patches/series - was not enabled in last release
  * debian/patches/0001-snap-Replace-libsoup-icon-loading-code-with-AsIcon.patch:
    - Fix crash loading cached icons (LP: #1708140)
  * debian/patches/0001-snap-Run-before-hardcoded-popular-plugin.patch:
  * debian/patches/0018-Make-gs_app_list_filter_duplicates-not-change-app-or.patch:
  * debian/patches/0019-snap-Use-first-featured-snap-as-featured-app.patch:
  * debian/patches/0020-snap-Only-feature-snaps.patch:
  * debian/patches/0021-Don-t-randomize-editors-picks.patch:
    - Only show snaps in "Editor's picks" (LP: #1705953)
    - Show snap in "Featured" section (LP: #1706478)

gnome-software (3.22.7-0ubuntu3.17.04.6) zesty; urgency=medium

  * 0001-snap-Fix-crash-when-fail-to-use-icon-from-cache.patch:
    - Fix crash when failing to load icons from cache (LP: #1702122)

 -- Robert Ancell <email address hidden> Thu, 24 Aug 2017 13:46:31 +1200

Changed in gnome-software (Ubuntu Zesty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

According to errors.u.c there is no occurrence of this crash for gnome-software 3.20.5-0ubuntu0.16.04.6 in xenial-proposed.

https://errors.ubuntu.com/?release=Ubuntu%2016.04&package=gnome-software&period=month&version=3.20.5-0ubuntu0.16.04.6

However, this version introduced a new crash which may potentially be a regression (https://errors.ubuntu.com/problem/b8d914cec850474446873c5a60feba99b1d498d9 and bug 1716633)

Marking as verification-failed until it is investigated by the maintainer of the package.

tags: added: verification-failed-xenial
removed: verification-needed-xenial
Robert Ancell (robert-ancell) wrote :

I've investigated in the other bug and don't consider it a blocker - @jibel can you change this to verification-done if you are happy with this?

Given that this SRU contains several important fixes and that the new defect is not a regression but rather an incomplete fix of this crash, I'm marking this SRU a verification-done.

@Robert please submit another SRU for 1716633

tags: added: verification-done verification-done-xenial
removed: verification-failed-xenial verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.6

---------------
gnome-software (3.20.5-0ubuntu0.16.04.6) xenial; urgency=medium

  * debian/patches/0001-Add-gs_app_set_local_file.patch:
  * debian/patches/0017-Add-an-APT-plugin.patch:
    - Fix being unable to load .deb files (LP: #1708936)
  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Fix icons larger than 65kB not loading (LP: #1704888)
    - Stop 'core' snap showing as an app (LP: #1704904)
    - Use new title field from snapd (LP: #1555569)
  * debian/patches/0045-Don-t-generate-popular-apps-from-Ubuntu-reviews.patch:
  * debian/patches/0046-snap-Use-first-featured-snap-as-featured-app.patch
  * debian/patches/0047-snap-Only-feature-snaps.patch
  * debian/patches/0048-Don-t-randomize-editors-picks.patch
    - Only show snaps in "Editor's picks" (LP: #1705953)
    - Show snap in "Featured" section (LP: #1706478)
  * debian/patches/0049-snap-Replace-libsoup-icon-loading-code-with-AsIcon.patch
    - Fix crash loading cached icons (LP: #1708140)

 -- Robert Ancell <email address hidden> Thu, 24 Aug 2017 12:19:14 +1200

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers