Doesn't download snap icons greater than 65kB

Bug #1704888 reported by Robert Ancell on 2017-07-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
High
Unassigned
Xenial
High
Robert Ancell
Yakkety
High
Unassigned
Zesty
High
Robert Ancell
Artful
High
Unassigned

Bug Description

[Impact]
Due to a hard-coded limitation in the gnome-software snap support it is unable to download icons greater than 65kB in size (e.g. pin-town).

[Test Case]
1. Install pin-town from the command line (sudo snap install pin-town
2. Open GNOME Software
3. Go to installed apps

Expected result:
pin-town is shown

Observed result:
pin-town is not shown (due to failure to download icon).

[Regression Potential]
Solution is to backport snapd code from gnome-software 3.24. This has a risk of introducing new bugs. The code has been used in 17.10.

Changed in gnome-software (Ubuntu Yakkety):
status: New → Won't Fix
Changed in gnome-software (Ubuntu Xenial):
importance: Undecided → High
Changed in gnome-software (Ubuntu Yakkety):
importance: Undecided → Critical
Changed in gnome-software (Ubuntu Zesty):
importance: Undecided → High
Changed in gnome-software (Ubuntu Artful):
importance: Undecided → High
Changed in gnome-software (Ubuntu Yakkety):
importance: Critical → High
Changed in gnome-software (Ubuntu Artful):
status: New → Fix Released
Changed in gnome-software (Ubuntu Zesty):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Xenial):
assignee: nobody → Robert Ancell (robert-ancell)
Changed in gnome-software (Ubuntu Zesty):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Xenial):
status: New → Fix Committed
description: updated

Hello Robert, or anyone else affected,

Accepted gnome-software into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.22.7-0ubuntu3.17.04.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-zesty
Jean-Baptiste Lallement (jibel) wrote :

following the steps in the description, pin-town is not shown in the list of installed software. I tried on Artful too and it is not shown either. Both use snapd 2.27.3.

tags: added: verification-failed-zesty
removed: verification-needed-zesty
Jean-Baptiste Lallement (jibel) wrote :

Ah, after yet another killall gnome-software and restart, it is displayed in the list of installed apps with an icon. marking as verification-done

tags: added: verification-done-zesty
removed: verification-failed-zesty
Łukasz Zemczak (sil2100) wrote :

Hello Robert, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed-xenial
Jean-Baptiste Lallement (jibel) wrote :

SRU verification for Xenial:
I have reproduced the problem with gnome-software 3.20.5-0ubuntu0.16.04.5 in xenial-updates and have verified that the version of gnome-software 3.20.5-0ubuntu0.16.04.6 in -proposed fixes the issue.

Marking as verification-done

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.22.7-0ubuntu3.17.04.7

---------------
gnome-software (3.22.7-0ubuntu3.17.04.7) zesty; urgency=medium

  * debian/patches/0001-snap-Use-title-field-if-available.patch:
    - Use new title field from snapd (LP: #1555569)
  * debian/patches/0001-snap-Remove-size-limit-on-snap-responses.patch:
  * debian/patches/0002-snap-Fix-failures-to-read-from-snapd.patch:
    - Fix icons larger than 65kB not loading (LP: #1704888)
  * debian/patches/0001-snap-Mark-non-app-snaps-as-runtimes.patch:
    - Stop 'core' snap showing as an app (LP: #1704904)
  * debian/patches/0001-snap-Fix-crash-when-fail-to-use-icon-from-cache.patch:
    - Add to debian/patches/series - was not enabled in last release
  * debian/patches/0001-snap-Replace-libsoup-icon-loading-code-with-AsIcon.patch:
    - Fix crash loading cached icons (LP: #1708140)
  * debian/patches/0001-snap-Run-before-hardcoded-popular-plugin.patch:
  * debian/patches/0018-Make-gs_app_list_filter_duplicates-not-change-app-or.patch:
  * debian/patches/0019-snap-Use-first-featured-snap-as-featured-app.patch:
  * debian/patches/0020-snap-Only-feature-snaps.patch:
  * debian/patches/0021-Don-t-randomize-editors-picks.patch:
    - Only show snaps in "Editor's picks" (LP: #1705953)
    - Show snap in "Featured" section (LP: #1706478)

gnome-software (3.22.7-0ubuntu3.17.04.6) zesty; urgency=medium

  * 0001-snap-Fix-crash-when-fail-to-use-icon-from-cache.patch:
    - Fix crash when failing to load icons from cache (LP: #1702122)

 -- Robert Ancell <email address hidden> Thu, 24 Aug 2017 13:46:31 +1200

Changed in gnome-software (Ubuntu Zesty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.6

---------------
gnome-software (3.20.5-0ubuntu0.16.04.6) xenial; urgency=medium

  * debian/patches/0001-Add-gs_app_set_local_file.patch:
  * debian/patches/0017-Add-an-APT-plugin.patch:
    - Fix being unable to load .deb files (LP: #1708936)
  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Fix icons larger than 65kB not loading (LP: #1704888)
    - Stop 'core' snap showing as an app (LP: #1704904)
    - Use new title field from snapd (LP: #1555569)
  * debian/patches/0045-Don-t-generate-popular-apps-from-Ubuntu-reviews.patch:
  * debian/patches/0046-snap-Use-first-featured-snap-as-featured-app.patch
  * debian/patches/0047-snap-Only-feature-snaps.patch
  * debian/patches/0048-Don-t-randomize-editors-picks.patch
    - Only show snaps in "Editor's picks" (LP: #1705953)
    - Show snap in "Featured" section (LP: #1706478)
  * debian/patches/0049-snap-Replace-libsoup-icon-loading-code-with-AsIcon.patch
    - Fix crash loading cached icons (LP: #1708140)

 -- Robert Ancell <email address hidden> Thu, 24 Aug 2017 12:19:14 +1200

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers