Snaps without icons don't show as installed

Bug #1697565 reported by Robert Ancell
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Medium
Unassigned
Zesty
Fix Released
Medium
Unassigned
Artful
Fix Released
Medium
Unassigned

Bug Description

[Impact]
Snaps without icons don't show in the installed tab. They do show in search, because the icon is sourced from the store.

[Test Case]
1. Open GNOME Software
2. Install a snap without an icon in the snap, but does have one in the store (e.g. moon-buggy)
3. Close GNOME Software
4. Open GNOME Software
5. Click "installed" tab

Expected result:
Installed snap is shown

Observed result:
Snap is not shown

[Regression Potential]
The code was refactored to download the store information for installed snaps. This means the store icon shows if the installed snap didn't have one. There is some risk of new bugs being caused by the refactoring.

Changed in gnome-software (Ubuntu Artful):
importance: Undecided → Medium
Changed in gnome-software (Ubuntu Zesty):
importance: Undecided → Medium
Changed in gnome-software (Ubuntu Yakkety):
importance: Undecided → Medium
Changed in gnome-software (Ubuntu Xenial):
importance: Undecided → Medium
Changed in gnome-software (Ubuntu Yakkety):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Artful):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Xenial):
status: New → Fix Committed
Changed in gnome-software (Ubuntu Zesty):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.24.3-0ubuntu4

---------------
gnome-software (3.24.3-0ubuntu4) artful; urgency=medium

  * debian/patches/0001-snap-Fix-icons-not-being-converted-to-pixbufs.patch:
    - Fix snaps without icons not showing reliably (LP: #1697565)
  * debian/patches/0001-snap-Mark-snaps-as-sandboxed.patch:
  * debian/patches/0001-snap-Backport-fixes-from-master.patch:
    - Show featured snaps (LP: #1663097)

 -- Robert Ancell <email address hidden> Thu, 15 Jun 2017 16:55:26 +1200

Changed in gnome-software (Ubuntu Artful):
status: Fix Committed → Fix Released
description: updated
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Marking Wont Fix in Yakkety since that's about to go end of life.

Changed in gnome-software (Ubuntu Yakkety):
status: Fix Committed → Won't Fix
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted gnome-software into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.22.7-0ubuntu3.17.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Change of SRU verification policy

As part of a recent change in the Stable Release Update verification policy we would like to inform that for a bug to be considered verified for a given release a verification-done-$RELEASE tag needs to be added to the bug where $RELEASE is the name of the series the package that was tested (e.g. verification-done-xenial). Please note that the global 'verification-done' tag can no longer be used for this purpose.

Thank you!

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Um, I wasn't able to verify the original bug because both moon-buggy and hello-snaps did show up in Installed with the current zesty version (3.22.7-0ubuntu3.17.04.2)

But there were two improvements in the new SRU (3.22.7-0ubuntu3.17.04.5) so I'm going to mark this as verified.
- moon-buggy now shows an icon in Software instead of the generic package icon
- With 17.04.2, the Software app got stuck with high CPU when installation of the first snap reached 99%. The snap did install though and I had no problems after completely killing gnome-software. I did not experience this issue with the 17.04.5 SRU.

tags: added: verification-done-zesty xenial zesty
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.22.7-0ubuntu3.17.04.5

---------------
gnome-software (3.22.7-0ubuntu3.17.04.5) zesty; urgency=medium

  * debian/patches/0001-snap-Fix-icons-not-being-converted-to-pixbufs.patch:
    - Fix snaps without icons not showing reliably (LP: #1697565)
  * debian/patches/0001-snap-Backport-fixes-from-master.patch:
    - Show featured snaps (LP: #1663097)
  * debian/patches/0017-Use-snap-name-field-for-app-name.patch:
    - Dropped, merged into above patch

gnome-software (3.22.7-0ubuntu3.17.04.4) zesty; urgency=medium

  * debian/patches/0006-Add-an-APT-plugin.patch:
    - Handle multiple debconf connections (LP: #1688721)
  * debian/patches/0018-Limit-search-entry-to-100-characters.patch:
    - Limit search entry in case of accidental input (LP: #1692398)

gnome-software (3.22.7-0ubuntu3.17.04.3) zesty; urgency=medium

  * debian/patches/0002-Add-an-APT-plugin.patch:
    - Fix crash when debconf socket fails (LP: #1689425)

 -- Robert Ancell <email address hidden> Fri, 16 Jun 2017 13:42:12 +1200

Changed in gnome-software (Ubuntu Zesty):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-xenial
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

I see no improvement with 3.20.5-0ubuntu0.16.04.5 in xenial. I tried with openscad-plars and it is not listed in the installed packages. However moon-buggy is listed but it has an icon, so it is not a good example for this test case.

Marking as verification-failed for xenial

tags: added: verification-failed-xenial
removed: verification-needed-xenial
description: updated
Revision history for this message
Robert Ancell (robert-ancell) wrote :

@jibel can you re-check that moon-buggy was showing before this update?

There's currently three cases:

1. moon-buggy has a store icon but not an icon in the snap - this is the bug that was fixed. On my Xenial system I can't see this before the update and I can afterwards.
2. openscad-plars has neither a store icon or an icon in the snap - this currently shows with a generic icon in artful but not in xenial (I think there might be a themeing issue picking the default icon in xenial - being investigated).
3. pin-town has both a store icon and a snap icon (works in all cases).

Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

okay, it was not clear from the test case. So case 1 is solved with the version of gnome-software in proposed. And I didn't notice any regression. I'm marking this report as verificatio-done

tags: added: verification-failed-done
removed: verification-failed-xenial
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks Jean-Bapiste!

tags: added: verification-done-xenial
removed: verification-failed-done
description: updated
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Case 2 (no snap or store icon) is being tracked in bug 1706488

no longer affects: gnome-software (Ubuntu Yakkety)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.5

---------------
gnome-software (3.20.5-0ubuntu0.16.04.5) xenial; urgency=medium

  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Fix crash when failing to load icons from cache (LP: #1702122)

gnome-software (3.20.5-0ubuntu0.16.04.4) xenial; urgency=medium

  * Rebase on stable 3.20.5 release (LP: #1703461).
  * debian/patches/*.patch:
    - Convert Ubuntu changes into patches
  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Fix snaps without icons not showing reliably (LP: #1697565)
    - Show featured snaps (LP: #1663097)

 -- Robert Ancell <email address hidden> Wed, 12 Jul 2017 16:24:08 +1200

Changed in gnome-software (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.