Connection switches in Bluetooth menu are not functioning

Bug #918208 reported by Timo Kluck on 2012-01-18
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Undecided
Unassigned
Oneiric
Undecided
Unassigned

Bug Description

[Impact]
The device connection switches in the gnome-shell bluetooth menu can be toggled but don't work: their status is independent from the actual connection status.

[Development Fix]
This is a known bug with a trivial patch, and it has already been fixed in master:
https://bugzilla.gnome.org/show_bug.cgi?id=662384

[Stable Fix]
It would be nice if the trivial fix could be incorporated into the Ubuntu's 3.2.1 package.

[Test Case]
Enable bluetooth. Connect to an external device. In the gnome-shell bluetooth menu, toggle the device's "connected" switch. Open System Settings>Bluetooth. Confirm that the toggle status is the same.

[Regression Potential]
The regression potential is minimal: the change is very local and would not affect anything outside of the function _buildDeviceSubMenu in ui/status/bluetooth.js. No new objects are created.
The possible regression impact would be limited to the bluetooth device menu. The function _buildDeviceSubMenu also takes care of options such as "Send files..." (for obex devices) and "Sound settings" (for headphones). If anything were to go wrong, these are the things that are most likely to be affected.
(Of course, there is also the "general" regression potential for things going wrong with packaging, upgrading, etc).

[Original Report]
The device connection switches in the gnome-shell bluetooth menu can be toggled but don't work: their status is independent from the actual connection status.

This is a known bug with a trivial patch, and it has already been fixed in master:
https://bugzilla.gnome.org/show_bug.cgi?id=662384

It would be nice if the trivial fix could be incorporated into the Ubuntu's 3.2.1 package.

Related branches

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.2.2.1-0ubuntu1

---------------
gnome-shell (3.2.2.1-0ubuntu1) precise; urgency=low

  [ Jeremy Bicha ]
  * New upstream release
    - Fix broken gnome-shell-extension-tool (LP: #853882)
    - Fixes lots of crashes and some memory leaks
    - extensions.gnome.org should now work with Webkit-based browsers
  * Dropped upstream patches:
    - 05-NetworkMenu-don-t-query-DBus-properties-of-removed-o.patch
    - 06-NetworkMenu-fix-regression-in-access-point-removed.patch

  [ Timo Kluck ]
  * debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch:
    - Fix bluetooth panel switch moving independently from actual
      connection status (LP: #918208)
 -- Jeremy Bicha <email address hidden> Mon, 23 Jan 2012 12:03:42 -0500

Changed in gnome-shell (Ubuntu):
status: New → Fix Released
Jeremy Bicha (jbicha) on 2012-01-25
description: updated
Timo Kluck (tkluck) on 2012-01-25
description: updated
Bryce Harrington (bryce) on 2012-01-27
description: updated
Timo Kluck (tkluck) on 2012-01-28
description: updated

Hello Timo, or anyone else affected,

Accepted gnome-shell into oneiric-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in gnome-shell (Ubuntu Oneiric):
status: New → Fix Committed
tags: added: verification-needed
Timo Kluck (tkluck) wrote :

It seems like the new gnome-shell package creates a new binary package gnome-shell-common. It is not in the -proposed repo yet, and I don't see any mention of it at the oneiric-proposed part of

https://launchpad.net/ubuntu/+source/gnome-shell

(except for "Note: Some binary packages for this source are not yet published in the repository.", but that seems to refer to the i386 build).

This currently prevents me from installing the updated version.

Jeremy Bicha (jbicha) wrote :

Timo, the missing gnome-shell-common should be fixed now, or at least within a few hours.

Timo Kluck (tkluck) wrote :

I can confirm that the new gnome-shell packages in oneiric-proposed work and fix this bug.

Martin Pitt (pitti) on 2012-02-01
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.2.2.1-0ubuntu0.1

---------------
gnome-shell (3.2.2.1-0ubuntu0.1) oneiric-proposed; urgency=low

  [ Jeremy Bicha ]
  * New upstream release (LP: #921343)
    - Fix broken gnome-shell-extension-tool (LP: #853882)
    - Fixes lots of crashes and some memory leaks
    - extensions.gnome.org should now work with Webkit-based browsers
  * Split common files and translations to gnome-shell-common. Add
    appropriate Breaks/Replaces.
  * 02_rpath-bluetooth-applet.patch:
    - Add an RPATH so that the compilation doesn't fail when g-ir-scanner
      tries to analyze libgnome-shell.so linked against
  * 04_remove-glx-dependency-on-armel.patch: Refactored
  * 07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch
    - Fix the logic for connecting to the current wifi strength,
      prevents the network icon from becoming stale (from upstream git)
  * 08-polkit-Find-the-best-user-to-authenticate-as.patch:
    - When picking a user to authenticate with, try the current user
      first, then root and if all else fails the first user that is allowed to
      authenticate. (from upstream git)
  * 09-respect-NoDisplay-semantics-for-app-menu.patch:
    - Respect NoDisplay semantics for applications menu. This avoids duplicate
      menu entries when menu-xdg is installed. Closes: #649559

  [ Timo Kluck ]
  * 10-bluetooth-fix-connection-from-gs-menu.patch:
    - Fix bluetooth panel switch moving independently from actual
      connection status (LP: #918208)
 -- Jeremy Bicha <email address hidden> Mon, 23 Jan 2012 14:25:45 -0500

Changed in gnome-shell (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers