Lockscreen entry can't be hidden via escape

[Marco Trevisan (Treviño)]

[ Impact ]

On the lockcreen hitting the Escape key should reset the lockscreen to the clock view, this is broken since GNOME 46, especially when animations are disabled.

[ Test case ]

1. Lock the screen
2. Press any key, the password field should be visible
3. Press Escape
4. The lockscreen clock should be shown

Repeat the same disabling the animations from Accessibility settings

[ Regression potential ]

An authentication transaction isn't cancelled by pressing escape.

[Steve Langasek (vorlon)]

Hello Marco, or anyone else affected,

Accepted gnome-shell into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/47.0-2ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted gnome-shell (47.0-2ubuntu3) for oracular have finished running.
The following regressions have been reported in tests triggered by the package:

update-notifier/unknown (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/oracular/update_excuses.html#gnome-shell

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Marco Trevisan (Treviño) (3v1n0)]

Fix verified using oracular, both using animations and not (since they may change the behavior of this bug):

marco@oracular:~$ apt-cache policy gnome-shell
gnome-shell:
  Installato: 47.0-2ubuntu3
  Candidato: 47.0-2ubuntu3
  Tabella versione:
 *** 47.0-2ubuntu3 100
        100 http://us.archive.ubuntu.com/ubuntu oracular-proposed/main amd64 Packages

Lockscreen works as expected and using Escape key toggles the view. At the same time, there's no regression on unlocking after a round of toggles.

[Daniel van Vugt (vanvugt)]

The fix seems to be missing from Salsa (ubuntu/latest). So not 'Fix Committed' for Plucky.

[Marco Trevisan (Treviño) (3v1n0)]

I've pushed the tag, but I was expecting it being synchronized from the oracular queue.

And in fact it has been:

gnome-shell (47.0-2ubuntu2) oracular; urgency=medium

  * d/p/ubuntu/secure-mode-extension: Return null on invalid extension.
    The upstream code checks whether the returned extension is null, not
    undefined, so we may end up returning an accepted values that will fail
    later when parsing the extension content (LP: #2083615)

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 03 Oct 2024 16:55:49 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 47.0-2ubuntu3

---------------
gnome-shell (47.0-2ubuntu3) oracular; urgency=medium

  * d/p: Fix toggling lockscreen view using Escape (LP: #2084308)

 -- Marco Trevisan (Treviño) <email address hidden> Sat, 12 Oct 2024 04:57:30 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 47.0-2ubuntu3.1

---------------
gnome-shell (47.0-2ubuntu3.1) plucky; urgency=medium

  * No-change upload to plucky

gnome-shell (47.0-2ubuntu3) oracular; urgency=medium

  * d/p: Fix toggling lockscreen view using Escape (LP: #2084308)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 22 Oct 2024 11:38:25 +0200