Value in Yaru-dark/gnome-shell/gnome-shell.css not used

Bug #1878998 reported by rquint
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Yaru Theme
New
Unknown
gnome-shell (Ubuntu)
Fix Released
Low
Unassigned
yaru-theme (Ubuntu)
Won't Fix
Low
Unassigned

Bug Description

The value for selected-color at line 153 in the gnome-shell.css files for Yaru and Yaru-dark is ignored by the shell. (Selected text should change color from dark grey to white.)
---
ProblemType: Bug
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
DisplayManager: gdm3
DistroRelease: Ubuntu 20.04
InstallationDate: Installed on 2019-10-17 (214 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Release amd64 (20191017)
Package: yaru-theme
PackageArchitecture: amd64
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 5.4.0-29.33-generic 5.4.30
RelatedPackageVersions: mutter-common 3.36.1-3ubuntu3
Tags: focal
Uname: Linux 5.4.0-29-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: sudo vboxsf
_MarkForUpload: True

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

That part of the file relates to StEntry, which is for shell widgets only. Gnome Shell ignoring the dark theme for its own widgets is already covered by bug 1842886 so I think that needs fixing first.

affects: gnome-shell (Ubuntu) → yaru-theme (Ubuntu)
affects: yaru-theme (Ubuntu) → gnome-shell (Ubuntu)
Revision history for this message
rquint (richard-quint) wrote :

I think this is a different issue. Up to 19.10, whether you used the default or Yaru-dark themes, when you selected the text in an entry box (e.g., rename, command, etc.) or were presented with some default text already highlighted, the text color was white as opposed to unselected text which was dark. This changed in 20.04. The colors were set in the StEntry portion of the css files. I don't know enough about Gnome Shell, but there may be some other change in 20.04 that affects behaviour in addition to bug 1842886.

I'm attaching a combined screen shot showing what I tried to describe in VirtualBox installations of the 19.10 and 20.04 versions of Ubuntu with Gnome Tweaks showing that the default themes are running in both.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK we can separate this bug again, but:

1. Please run 'apport-collect 1878998' to complete the bug report process. It will attach more info about the machine; and

2. I still think bug 1842886 is masking this and may need fixing first.

Changed in gnome-shell (Ubuntu):
status: New → Incomplete
Changed in yaru-theme (Ubuntu):
status: New → Incomplete
summary: - Value in gnome-shell.css not used
+ Value in Yaru-dark/gnome-shell/gnome-shell.css not used
Revision history for this message
rquint (richard-quint) wrote : Dependencies.txt

apport information

tags: added: apport-collected focal
description: updated
Revision history for this message
rquint (richard-quint) wrote : GsettingsChanges.txt

apport information

Revision history for this message
rquint (richard-quint) wrote : ProcCpuinfoMinimal.txt

apport information

Revision history for this message
rquint (richard-quint) wrote : ShellJournal.txt

apport information

Changed in gnome-shell (Ubuntu):
status: Incomplete → New
Changed in yaru-theme (Ubuntu):
status: Incomplete → New
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell (Ubuntu):
status: New → Confirmed
Changed in yaru-theme (Ubuntu):
status: New → Confirmed
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Hi Daniel,

in gnome-shell selected text inside a StEntry is supposed to have orange background and white text, regardless the variant (light or dark), so I don't expect this issue to be related to bug 1842886, unless I am missing something here.
We have the same issue reported in Yaru's github repo and I worked a little on it without being able to have a selected foreground color work yet.

no longer affects: gnome-shell (Ubuntu)
Changed in yaru:
status: Unknown → New
Revision history for this message
Carlo Lobrano (c-lobrano) wrote :

Sorry, I didn't mean that the bug is surely due to Yaru theme :)

As reported in this bug, Yaru sets the proper color in gnome-shell css, which is in-sync with upstream gnome-shell, so I suppose it should be honored, but since I don't know the internals of gnome-shell, I can't say that it is 100% a gnome-shell bug either.

Changed in yaru-theme (Ubuntu):
importance: Undecided → Low
Changed in gnome-shell (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
Changed in yaru-theme (Ubuntu):
status: Confirmed → Won't Fix
Changed in gnome-shell (Ubuntu):
status: Confirmed → In Progress
Jeremy Bícha (jbicha)
Changed in gnome-shell (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (5.1 KiB)

This bug was fixed in the package gnome-shell - 42.0-2ubuntu1

---------------
gnome-shell (42.0-2ubuntu1) jammy; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/patches: Cherry-pick upstream fixes targetting 42.1
  * debian/patches: Compute system ackground color from theme (LP: #1965727)
  * ubuntu/configure-login-screen.patch: Use bg color for initial system bg
    (LP: #1965727)
  * debian/patches: Ensure St.Entry's `selected-color` CSS property is honored
    (LP: #1878998)
  * ubuntu/support-loading-Yaru-variants: Handle dark/light variants better
  * d/p/main-Avoid-meta-finalize: Leak gjs context only on ubiquity sessions
    (LP: #1964458)
  * d/p/use-favorites-strings: Only apply this to ubuntu session
  * debian/patches: Do not hang and crash if fingerprint service fails to start
    (LP: #1962566)
  * debian: Use gnomebluetooth-3.0 as dependency and revert patches disabling it
    (LP: #1738838, #1968364, #1964600)

  [ Jeremy Bicha ]
  * Use libgweather4 instead of old libgweather (LP: #1964600)
  * Add patch to work around meson issue (Debian 1008189)
  * releasing package gnome-shell version 42.0-2
  * debian/control.in: Recommend power-profiles-daemon for power mode feature

  [ Daniel van Vugt ]
  * main-Avoid-meta-finalize.patch: Leak GJS to work around LP: #1964458

  [ Gunnar Hjalmarsson ]
  * Revert "dash: Use pin instead of favorites"

  [ Jeremy Bicha ]
  * Remaining changes with debian:
    - Replace gnome-backgrounds dep with ubuntu-wallpapers and Suggests
      gnome-themes-standard-data, gnome-backgrounds
    - Add some Recommends:
      + ubuntu-session (| gnome-session) to have the ubuntu session available
      + xserver-xorg-legacy
      + yaru-theme-gnome-shell for the default ubuntu theming
      + gnome-remote-desktop to provide remote desktop support by default
    - Moved some Recommends to Suggests:
      + chrome-gnome-shell
    - Update debian/gbp.conf with Ubuntu settings
    - gnome-shell-common.prerm: Remove deprecated ubuntu theme alternative
    - ubuntu/desktop_detect.patch:
      + add caching for desktop detection to avoid querying the current
        desktop env variable as iterate through the list each time. For the
        time of the Shell process, we can expect this env variable to stay
        stable.
    - ubuntu/smarter_alt_tab.patch:
      + quick alt-tab (without showing up the switcher) switch only between
        the last window of the last 2 applications to be focused instead of
        raising all windows of those apps.
    - ubuntu/lightdm-user-switching.patch:
      + Allow user switching when using LightDM.
    - ubuntu/lock_on_suspend.patch
      + Respect Ubuntu's lock-on-suspend setting.
    - ubuntu/background_login.patch
      + Change default background color as we modified the default GDM color
        for our ubuntu session.
    - ubuntu/gdm_alternatives.patch
      + Add support for GDM3 theme alternatives
    - optional-hot-corner.patch
      + enable patch proposed by upstream developer already in package (but
        not in series) to add a settings for optional hot corner activation.
    - main-show-an-error-message-on-gnome-shell-crash.patch,
      global-m...

Read more...

Changed in gnome-shell (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.