Do Not Disturb setting does not persist across login sessions

[Jeremy Coghill]

[ Impact ]

Selecting do not disturb from settings does not persist across login sessions.

[ Test case ]

- Set Do Not Disturb in settings or from top bar to prevent pop-up notification banners from appearing, which it does.
- logout and log back in
- expect pop-up notifications to continue to be blocked and only displayed in the top bar

[ Regresion potential ]

Togglingg the do not disturb toggle doesn't work anymore

Description: Ubuntu 20.04 LTS
Release: 20.04
gnome-control-center:
  Installed: 1:3.36.1-1ubuntu5
  Candidate: 1:3.36.1-1ubuntu5
  Version table:
 *** 1:3.36.1-1ubuntu5 500
        500 http://ca.archive.ubuntu.com/ubuntu focal/main amd64 Packages
        100 /var/lib/dpkg/status

- Do Not Disturb is reset to disabled on each new login

ProblemType: BugDistroRelease: Ubuntu 20.04
Package: gnome-control-center 1:3.36.1-1ubuntu5
ProcVersionSignature: Ubuntu 5.4.0-24.28-generic 5.4.30
Uname: Linux 5.4.0-24-generic x86_64
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: ubuntu:GNOME
Date: Sun Apr 19 14:42:49 2020
ExecutablePath: /usr/bin/gnome-control-center
InstallationDate: Installed on 2019-07-24 (270 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
ProcEnviron:
 LANGUAGE=en_CA:en
 PATH=(custom, user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_CA.UTF-8
 SHELL=/bin/bashSourcePackage: gnome-control-center
UpgradeStatus: Upgraded to focal on 2020-03-19 (30 days ago)

[Gunnar Hjalmarsson (gunnarhj)]

Thanks for your report! I can confirm it. When "Do Not Disturb" is enabled, this dconf value is set:

$ gsettings get org.gnome.desktop.notifications show-banners
false

But something always sets it to "true" at login. (That something is reasonably not gnome-control-center, btw, since it's not launched automatically at login.)

The feature was preceded by long discussions:

https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/56

https://gitlab.gnome.org/GNOME/gnome-shell/issues/239

I have a feeling that the behavior is intentional, even if I didn't find any explicit statement in that direction.

[Jeremy Coghill (buck10)]

I have a feeling you are right that it may not be gnome-control-center doing this as setting the default value of show-banners in /usr/share/glib2.0/schemas to false ends up being ignored at login.

It is unclear to me what the desired behaviour is from those discussions, but my expectation is that an exposed user setting will stay set until I unset it.

[Sebastien Bacher (seb128)]

Could you report it upstream on https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues ? They are better placed to tell how the feature is supposed to be working

[Sebastien Bacher (seb128)]

Thinking about it, it's probably rather a gnome-shell issue. gnome-control-center is only a frontend and not active/doing anything unless you open/use it so it can't be responsible for resetting the value at login

[Jeremy Coghill (buck10)]

Done (https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/961). Hopefully I submitted it correctly.

[Sebastien Bacher (seb128)]

Thanks, it looks right indeed

[Sebastien Bacher (seb128)]

The issue was in gnome-shell and a fix has been commited to git now

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.36.3-1ubuntu2

---------------
gnome-shell (3.36.3-1ubuntu2) groovy; urgency=medium

  * d/p/shell-mime-sniffer-Ignore-invalid-file-content-type.patch:
    - gnome-shell-sniffer, don't crash when opening files with invalid content
      type (LP: #1865300)

 -- Marco Trevisan (Treviño) <email address hidden> Fri, 05 Jun 2020 20:14:47 +0200

[Timo Aaltonen (tjaalton)]

Hello Jeremy, or anyone else affected,

Accepted gnome-shell into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.36.3-1ubuntu1~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Jeremy Coghill (buck10)]

Hi, I have now installed gnome-shell/focal-proposed,now 3.36.3-1ubuntu1~20.04.2 amd64 [installed] and the patch works as expected. The setting of Do Not Disturb persists across login sessions.

Thanks

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.36.3-1ubuntu1~20.04.2

---------------
gnome-shell (3.36.3-1ubuntu1~20.04.2) focal; urgency=medium

  * No change backport to focal

gnome-shell (3.36.3-1ubuntu2) groovy; urgency=medium

  * d/p/shell-mime-sniffer-Ignore-invalid-file-content-type.patch:
    - gnome-shell-sniffer, don't crash when opening files with invalid content
      type (LP: #1865300)

gnome-shell (3.36.3-1ubuntu1~20.04.1) focal; urgency=medium

  * No change backport to focal (LP: #1881973)

gnome-shell (3.36.3-1ubuntu1) groovy; urgency=medium

  * Merge with debian, including new upstream release:
    - Fix app icon aspect ratio in the panel (LP: #1872026)
    - Ensure that Do not disturb is persistent across sessions (LP: #1873692)
    - Fix Theme node crashes (LP: #1877774, LP: #1877760)
  * debian/patches: Refresh
  * Remaining changes with debian:
    - Replace gnome-backgrounds dep with ubuntu-wallpapers and Suggests
      gnome-themes-standard-data, gnome-backgrounds
    - Add some Recommends:
      + ubuntu-session (| gnome-session) to have the ubuntu session available
      + xserver-xorg-legacy
      + yaru-theme-gnome-shell for the default ubuntu theming
    - Update debian/gbp.conf with Ubuntu settings
    - gnome-shell-common.prerm: Remove deprecated ubuntu theme alternative
    - ubuntu/desktop_detect.patch:
      + add caching for desktop detection to avoid querying the current
        desktop env variable as iterate through the list each time. For the
        time of the Shell process, we can expect this env variable to stay
        stable.
    - ubuntu/smarter_alt_tab.patch:
      + quick alt-tab (without showing up the switcher) switch only between
        the last window of the last 2 applications to be focused instead of
        raising all windows of those apps.
    - ubuntu/lightdm-user-switching.patch:
      + Allow user switching when using LightDM.
    - ubuntu/lock_on_suspend.patch
      + Respect Ubuntu's lock-on-suspend setting.
    - ubuntu/background_login.patch
      + Change default background color as we modified the default GDM color
        for our ubuntu session.
    - ubuntu/gdm_alternatives.patch
      + Add support for GDM3 theme alternatives
    - optional-hot-corner.patch
      + enable patch proposed by upstream developer already in package (but
        not in series) to add a settings for optional hot corner activation.
    - main-show-an-error-message-on-gnome-shell-crash.patch,
      global-make-possible-to-set-debug-flags-dynamically.patch,
      main-increase-the-granularity-of-backtraces-in-SHELL_DEBU.patch,
      main-add-backtrace-crashes-all-and-backtrace-all.patch,
      sessionMode-add-support-for-debugFlags-parameter.patch:
      + Improve debug JS tracing for crash reports
    - st-scroll-view-Handle-the-case-where-scrollbars-are-NULL.patch:
      + Fix crash on theme changes
    - ubuntu/search-call-XUbuntuCancel-method-on-providers-when-no-dat.patch:
      + stop searches when requested from UI
    - magnifier-Show-cursor-when-magnifier-is-enabled-and-scale.patch:
      + Show monitor scaled cursor when magnifier is enabled
    - Break gnome-shell-extension-desktop...

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.