Ticks in gdm do not show

Bug #1798747 reported by Didier Roche on 2018-10-19
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Medium
Didier Roche
Cosmic
Undecided
Didier Roche

Bug Description

[Impact]
At the login screen (gdm) the a11y menu has a number of options, such as large text, screen reader etc. If you turn on screen reader you can then hover over the menu items and they will be read to you.

If you hover over an option that is enabled, the screen reader will tell you, for example:

Screen reader. TICKED

The entry in the menu item should have a tick next to it.

This is what happens using the default GNOME theme.

[Test Case]
1. Install new version from proposed
2. Reboot your laptop
3. Check the accessibility menu in the login screen (GDM) and ensure you have ticks near the label
4. Login and check there is no regression.
5. For bonus point, you can try GDM using vanilla gnome-shell theme by sudo update-alternatives --config gdm3.css + a reboot and GNOME Shell vanilla session (apt install gnome-session + select GNOME session on login screen)

[Regression Potential]
The new function exposed to gjs is calling realpath and is idempotent: it returns the filename given as a parameter on any error, or the realpath() result if there is any result, not changing the fundamental logic.
If there was a regression, the Shell wouldn't even load.
By checking the 5. point, we are checking we didn't impact gresources.

From https://github.com/ubuntu/yaru/issues/917.

Didier Roche (didrocks) on 2018-10-19
Changed in gnome-shell (Ubuntu):
assignee: nobody → Didier Roche (didrocks)
status: New → In Progress
Adolfo Jayme (fitojb) on 2018-10-21
Changed in gnome-shell (Ubuntu):
importance: Undecided → Medium
Iain Lane (laney) wrote :

uploaded for SRU & disco!

Changed in gnome-shell (Ubuntu Cosmic):
status: New → In Progress
assignee: nobody → Didier Roche (didrocks)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.30.1-2ubuntu2

---------------
gnome-shell (3.30.1-2ubuntu2) disco; urgency=medium

  [ Didier Roche ]
  * debian/patches/ubuntu/background_login.patch:
    - match Yaru theme in the ubuntu session instead of our previous GDM
      background (LP: #1789356)
  * debian/patches/ubuntu/resolve_alternate_theme_path.patch:
    - ensure we resolve finale theme file path to correctly load assets
      under gdm (LP: #1798747)

  [ Marco Trevisan (Treviño) ]
  * debian/patches/st-button-Ignore-pointer-emulated-touch-events.patch:
    - Don't emit two click events on touch under X11 (LP: #1745888)

 -- Iain Lane <email address hidden> Wed, 07 Nov 2018 11:05:30 +0000

Changed in gnome-shell (Ubuntu):
status: In Progress → Fix Released

Hello Didier, or anyone else affected,

Accepted gnome-shell into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.30.1-2ubuntu1.18.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Iain Lane (laney) wrote :

Verified fixed in cosmic with 3.30.1-2ubuntu1.

"ticks" confused me for a bit - they are sliders rather than checkboxes.

Thanks!

tags: added: verification-done verification-done-cosmic
removed: verification-needed verification-needed-cosmic
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell - 3.30.1-2ubuntu1.18.10.1

---------------
gnome-shell (3.30.1-2ubuntu1.18.10.1) cosmic; urgency=medium

  [ Didier Roche ]
  * debian/patches/ubuntu/background_login.patch:
    - match Yaru theme in the ubuntu session instead of our previous GDM
      background (LP: #1789356)
  * debian/patches/ubuntu/resolve_alternate_theme_path.patch:
    - ensure we resolve finale theme file path to correctly load assets
      under gdm (LP: #1798747)

  [ Marco Trevisan (Treviño) ]
  * debian/patches/st-button-Ignore-pointer-emulated-touch-events.patch:
    - Don't emit two click events on touch under X11 (LP: #1745888)

  [ Iain Lane ]
  * Update Vcs-Git for SRU to cosmic

 -- Iain Lane <email address hidden> Wed, 07 Nov 2018 12:16:25 +0000

Changed in gnome-shell (Ubuntu Cosmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers