gnome-shell crashed with SIGABRT: assertion failed "window->display->focus_window != window" in meta_window_unmanage

Bug #1791574 reported by Rocko
50
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Mutter
Fix Released
Unknown
gnome-shell (Ubuntu)
Fix Released
Medium
Marco Trevisan (Treviño)
mutter (Ubuntu)
Fix Released
High
Marco Trevisan (Treviño)
Bionic
Fix Released
High
Marco Trevisan (Treviño)
Disco
Fix Released
High
Marco Trevisan (Treviño)

Bug Description

[ Description ]

GNOME Shell crashes when interacting with some "take-input" windows such as the jetbrains products (you can snap install the 2008 versions which are affected), see https://gitlab.gnome.org/GNOME/mutter/issues/308

[ Test case ]
 Run this script:
 $ wget -O - https://gitlab.gnome.org/3v1n0/mutter/snippets/453/raw | python3

 - The shell should not crash when the windows are closed.

[ Regression potential ]

The patch introduces changes to the window focus handling, so a window might not be properly focused in some cases.

[ Notes to the SRU team ]

This fix is still in process of being released to eoan / disco too.

====

https://errors.ubuntu.com/problem/9b0e145ca11443bc44b35a2050317dd51f5ab5c5
Upstream issue: https://gitlab.gnome.org/GNOME/mutter/issues/308

Originally reported as bug 1422253 and fixed in 18.04, but that crash (fixed) was due to a different condition.

Test case: https://gitlab.gnome.org/3v1n0/mutter/snippets/453

---

gnome-shell crashed and restarted while I was using it.

ProblemType: CrashDistroRelease: Ubuntu 18.10
Package: gnome-shell 3.30.0-1ubuntu1
Uname: Linux 4.19.0-041900rc3-generic x86_64
ApportVersion: 2.20.10-0ubuntu9
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Mon Sep 10 12:39:16 2018
DisplayManager: gdm3
EcryptfsInUse: Yes
ExecutablePath: /usr/bin/gnome-shell
ExecutableTimestamp: 1536081658
InstallationDate: Installed on 2017-08-16 (389 days ago)
InstallationMedia: Ubuntu 17.04 "Zesty Zapus" - Release amd64 (20170412)
ProcCmdline: /usr/bin/gnome-shell
ProcCwd: /home/rocko
ProcEnviron:
 LANGUAGE=en_AU:en
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_AU.UTF-8
 SHELL=/bin/bashSignal: 6SourcePackage: gnome-shell
StacktraceTop:
 () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
 g_assertion_message_expr () at /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0
 meta_window_unmanage () at /usr/lib/x86_64-linux-gnu/libmutter-3.so.0
 () at /usr/lib/x86_64-linux-gnu/libmutter-3.so.0
 () at /usr/lib/x86_64-linux-gnu/libmutter-3.so.0
Title: gnome-shell crashed with SIGABRT
UpgradeStatus: Upgraded to cosmic on 2018-08-15 (25 days ago)
UserGroups: adm bumblebee cdrom dip kvm lpadmin plugdev sambashare sudo

Related branches

Revision history for this message
Rocko (rockorequin) wrote :
Revision history for this message
Apport retracing service (apport) wrote :

StacktraceTop:
 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
 __GI_abort () at abort.c:79
 g_assertion_message (domain=<optimized out>, file=<optimized out>, line=<optimized out>, func=0x7f3f72b4b050 <__func__.114921> "meta_window_unmanage", message=<optimized out>) at ../../../../glib/gtestutils.c:2596
 g_assertion_message_expr (domain=domain@entry=0x7f3f72b3fb30 "mutter", file=file@entry=0x7f3f72b48dbd "core/window.c", line=line@entry=1498, func=func@entry=0x7f3f72b4b050 <__func__.114921> "meta_window_unmanage", expr=expr@entry=0x7f3f72b49de8 "window->display->focus_window != window") at ../../../../glib/gtestutils.c:2619
 meta_window_unmanage (window=window@entry=0x5631b320e140, timestamp=timestamp@entry=92923) at core/window.c:1498

Revision history for this message
Apport retracing service (apport) wrote : Stacktrace.txt
Revision history for this message
Apport retracing service (apport) wrote : StacktraceSource.txt
Revision history for this message
Apport retracing service (apport) wrote : ThreadStacktrace.txt
Changed in gnome-shell (Ubuntu):
importance: Undecided → Medium
tags: removed: need-amd64-retrace
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks like bug 1422253 is back.

summary: - gnome-shell crashed with SIGABRT
+ gnome-shell crashed with SIGABRT: assertion failed
+ "window->display->focus_window != window" in meta_window_unmanage
information type: Private → Public
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Changed in gnome-shell (Ubuntu):
status: New → Confirmed
description: updated
description: updated
Changed in gnome-shell (Ubuntu):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
status: Confirmed → In Progress
tags: added: rls-cc-incoming
Revision history for this message
Will Cooke (willcooke) wrote :

Not a release blocker. Will be SRUd

tags: added: rls-cc-notfixing
removed: rls-cc-incoming
description: updated
description: updated
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

See related bug 1759161

Changed in gnome-shell (Ubuntu):
status: In Progress → Fix Committed
Changed in mutter (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in mutter (Ubuntu Bionic):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
description: updated
tags: added: fixed-in-3.33.3 fixed-upstream
removed: rls-cc-notfixing
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell (Ubuntu Bionic):
status: New → Confirmed
Changed in mutter:
status: Unknown → Fix Released
description: updated
Iain Lane (laney)
Changed in mutter (Ubuntu Disco):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mutter - 3.32.2+git20190626-1ubuntu1

---------------
mutter (3.32.2+git20190626-1ubuntu1) eoan; urgency=medium

  * Merge with debian (LP: #1834493). Remaining changes:
    + debian/control:
      - Update VCS flags to point to launchpad
      - Update maintainer to ubuntu
    + debian/gbp.conf: update branch to point to ubuntu/master
    + debian/patches/x11-Add-support-for-fractional-scaling-using-Randr.patch:
      - X11: Add support for fractional scaling using Randr

mutter (3.32.2+git20190626-1) experimental; urgency=medium

  * New upstream snapshot release:
    - Don't crash when try to focus unfocusable windows (LP: #1791574)
    - Valgrind use-after-free warning fixes in the native backend
    - renderer/native: add missing eglTerminate in EGLDevice error path
    - Fix Alt+F2 -> restart to work again in X11
    - window: Emit an error and return when trying to activate an unmanaged
      (LP: #1827401)
    - Setting cursor to "none" doesn't hide it under Wayland
    - Fix broken selected text in entries
    - Tests memory fixes

 -- Iain Lane <email address hidden> Thu, 27 Jun 2019 15:58:31 +0100

Changed in mutter (Ubuntu):
status: In Progress → Fix Released
Iain Lane (laney)
Changed in gnome-shell (Ubuntu Bionic):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell (Ubuntu Disco):
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Rocko, or anyone else affected,

Accepted mutter into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mutter/3.32.2+git20190626-1ubuntu1~19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in mutter (Ubuntu Disco):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-disco
tags: added: bionic disco
removed: cosmic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Rocko, or anyone else affected,

Accepted mutter into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mutter/3.32.2+git20190711-2ubuntu1~19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

marco@ubuntu-vmware:~:✗ $ apt-cache policy mutter
mutter:
  Installed: 3.32.2+git20190711-2ubuntu1~19.04.1
  Candidate: 3.32.2+git20190711-2ubuntu1~19.04.1
  Version table:
 *** 3.32.2+git20190711-2ubuntu1~19.04.1 500
        500 http://archive.ubuntu.com/ubuntu disco-proposed/main amd64 Packages
        100 /var/lib/dpkg/status

Test case works properly

tags: added: verification-done verification-done-disco
removed: verification-needed verification-needed-disco
no longer affects: gnome-shell (Ubuntu Bionic)
no longer affects: gnome-shell (Ubuntu Disco)
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for mutter has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.9 KiB)

This bug was fixed in the package mutter - 3.32.2+git20190711-2ubuntu1~19.04.1

---------------
mutter (3.32.2+git20190711-2ubuntu1~19.04.1) disco; urgency=medium

  * No-change backport from disco to eoan.

mutter (3.32.2+git20190711-2ubuntu1) eoan; urgency=medium

  * Merge with debian. Remaining changes:
    + debian/control:
      - Update VCS flags to point to launchpad
      - Update maintainer to ubuntu
    + debian/gbp.conf: update branch to point to ubuntu/master
    + debian/patches/x11-Add-support-for-fractional-scaling-using-Randr.patch:
      - X11: Add support for fractional scaling using Randr

mutter (3.32.2+git20190711-2) experimental; urgency=medium

  * d/p/window-x11-Focus-a-window-in-the-active-workspace-as-take.patch:
    - Fix possible crash on closing Java dialogs (Related to LP: #1834583)
    d/p/metatest-Dispatch-the-destruction-instead-of-sleeping-aft.patch:
    - Tests: don't wait too much after window destruction, causing failures

mutter (3.32.2+git20190711-1ubuntu1) eoan; urgency=medium

  * Merge with debian. Remaining changes:
    + debian/control:
      - Update VCS flags to point to launchpad
      - Update maintainer to ubuntu
    + debian/gbp.conf: update branch to point to ubuntu/master
    + debian/patches/x11-Add-support-for-fractional-scaling-using-Randr.patch:
      - X11: Add support for fractional scaling using Randr

mutter (3.32.2+git20190711-1) experimental; urgency=medium

  * New upstream snapshot up to commit ccab0f470
    - Fix No-input WM_TAKE_FOCUS dialogs causing GNOME Shell to hang
      and ensure we always have a window focused if we have a valid
      focus canididate (LP: #1834583)
    - Don't crash on shell close / reload under X11 when releasing
      surface actor display resources (LP: #1826918)
  * d/p/debian/Revert-meson-Bump-meson-requirement-to-0.50.0.patch:
    - Revert dependency on meson 0.50.0

mutter (3.32.2+git20190626-1ubuntu1~19.04.1) disco; urgency=medium

  * No-change backport from eoan to disco for SRU.

mutter (3.32.2+git20190626-1ubuntu1) eoan; urgency=medium

  * Merge with debian (LP: #1834493). Remaining changes:
    + debian/control:
      - Update VCS flags to point to launchpad
      - Update maintainer to ubuntu
    + debian/gbp.conf: update branch to point to ubuntu/master
    + debian/patches/x11-Add-support-for-fractional-scaling-using-Randr.patch:
      - X11: Add support for fractional scaling using Randr

mutter (3.32.2+git20190626-1) experimental; urgency=medium

  * New upstream snapshot release:
    - Don't crash when try to focus unfocusable windows (LP: #1791574)
    - Valgrind use-after-free warning fixes in the native backend
    - renderer/native: add missing eglTerminate in EGLDevice error path
    - Fix Alt+F2 -> restart to work again in X11
    - window: Emit an error and return when trying to activate an unmanaged
      (LP: #1827401)
    - Setting cursor to "none" doesn't hide it under Wayland
    - Fix broken selected text in entries
    - Tests memory fixes

mutter (3.32.2-1ubuntu1) eoan; urgency=medium

  * Merge with debian. Remaining changes:
    + debian/control:
      - Update VCS flags to point to launchpad
      - Update maintai...

Read more...

Changed in mutter (Ubuntu Disco):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Rocko, or anyone else affected,

Accepted mutter into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mutter/3.28.4-0ubuntu18.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in mutter (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
removed: verification-done
Changed in gnome-shell (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Test case works here with 3.28.4-0ubuntu18.04.2, e.u.c is not much helpful though since it tracks gnome-shell version only (bionic doesn't provide such infos to us yet)

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mutter - 3.28.4-0ubuntu18.04.2

---------------
mutter (3.28.4-0ubuntu18.04.2) bionic; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * d/p/screen-Destroy-window-actors-after-windows-while-unmanagi.patch,
    d/p/screen-Unset-the-active-workspace-and-remove-workspaces-o.patch:
    - Destroy window actors after windows while unmanaging compositor
      (LP: #1832869)
  * d/p/window-Emit-an-error-and-return-when-trying-to-activate-a.patch:
    - window: Emit an error and return when trying to activate an unmanaged
      (LP: #1827401)
  * d/p/stack-Add-a-function-to-get-a-sorted-list-of-focus-candid.patch,
    d/p/test-runner-Add-assert_focused-command.patch,
    d/p/test-runner-Add-dispatch-command.patch,
    d/p/test-runner-Add-sleep-command.patch,
    d/p/tests-Add-accept_focus-command-to-runner-and-client.patch,
    d/p/tests-Add-can_take_focus-command-to-runner-and-client.patch,
    d/p/tests-Verify-focused-window-in-closed-transient-tests.patch,
    d/p/tests-stacking-Add-tests-with-no-input-and-no-take-focus-.patch,
    d/p/window-x11-Accept-any-focusable-window-as-fallback-focus.patch,
    d/p/window-x11-Don-t-double-check-for-unmanaging-windows.patch,
    d/p/window-x11-Focus-the-default-window-with-delay-while-wait.patch,
    d/p/window-x11-Use-any-focusable-window-as-fallback-delayed-f.patch,
    d/p/window-x11-Focus-a-window-in-the-active-workspace-as-take.patch,
    d/p/workspace-Focus-only-ancestors-that-are-focusable.patch:
    - Workspace: Take-Input windows focus fixes (LP: #1791574)
  * debian/libmutter-2-0.symbols: Update with new symbols

  [ Iain Lane ]
  * debian/libmutter-2-0.symbols: Add a tilde. These were added in an Ubuntu
    revision, so they should cause dependencies on the full version - but we
    add a tilde in case of backports.

 -- Iain Lane <email address hidden> Tue, 09 Jul 2019 17:03:10 +0100

Changed in mutter (Ubuntu Bionic):
status: Fix Committed → Fix Released
tags: added: focal
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Still happening in focal. Please use bug 1870822 from now on.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.