Comment 15 for bug 1765304

Revision history for this message
Karl Tomlinson (bugs+launchpad) wrote :

In reply to comment 11:

> It doesn't make much sense since it's adding code for gtk 3.6 which is not the version we are using...

It's adding code for GTK versions 3.6 and newer.
https://developer.gnome.org/gtk3/stable/gtk3-Feature-Test-Macros.html#GTK-CHECK-VERSION:CAPS

I don't know why it is limited to newer GTK 3 versions because input-purpose is not documented as newer than GTK version 3.0
https://developer.gnome.org/gtk3/stable/GtkIMContext.html#GtkIMContext--input-purpose

If this file is compiled for GTK version 2, however, (as implied by the filename and other version checks) then some compile-time check will be required.

In reply to comment 13:

> it's a workaround for gtk 3.6 which is years old

I don't know of any reason to suspect this was intended for 3.6 only.

I don't know why passwords should be special, but it looks like a better (or at least more general) test than the IS_ENTRY heuristic below
https://github.com/ibus/ibus/blob/master/client/gtk2/ibusimcontext.c#L900