/usr/bin/gnome-shell:*** Error in `/usr/bin/gnome-shell': double free or corruption (out): ADDR *** in g_free() from gweather_location_unref()

Bug #1695567 reported by errors.ubuntu.com bug bridge on 2017-06-03
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Undecided
Unassigned
libgweather (Ubuntu)
High
Unassigned
Zesty
High
Unassigned

Bug Description

[Impact]
Backport git patch that fixes memory corruption in libgweather that is causing gnome-shell to crash. This is particularly bad on wayland as it causes the user to lose their sessions

I believe this should also fix bug 1688208 and potentially a couple of other high ranking crashes on errors.ubuntu.com. I have not however found reliable reproducers for those other bugs.

This error has been reported over 700 times on errors.ubuntu.com for Ubuntu GNOME 17.04.

[Test Case]
After update of libgweather
1. Ensure org.gnome.Weather.Application locations is not set (as per default setting)
2. Disable Location Services
3. gnome-shell should not crash

[Regression Potential]
Low, the patch merely fixes a refcounting bug. Given the high impact of this bug, this is an important fix.

[Other Info]
This updates libgweather from 3.24.0 to 3.24.1
https://git.gnome.org/browse/libgweather/log

The guard_against_segfault commit was already present in Ubuntu 17.04.

==== Original bug report ====
The Ubuntu Error Tracker has been receiving reports about a problem regarding gnome-shell. This problem was most recently seen with package version 3.24.2-0ubuntu4, the problem page at https://errors.ubuntu.com/problem/06422e05faafe183b4cb70daa7306dcb4c08c97e contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.
If you do not have access to the Ubuntu Error Tracker you can request it at http://forms.canonical.com/reports/.

Tim (darkxst) on 2017-06-03
Changed in gnome-shell (Ubuntu):
status: New → Invalid
Changed in libgweather (Ubuntu):
status: New → Fix Released
description: updated
Jeremy Bicha (jbicha) on 2017-06-03
Changed in libgweather (Ubuntu Zesty):
status: New → In Progress
no longer affects: gnome-shell (Ubuntu Zesty)
summary: /usr/bin/gnome-shell:*** Error in `/usr/bin/gnome-shell': double free or
- corruption (out): ADDR ***
+ corruption (out): ADDR *** in g_free() from gweather_location_unref()
Jeremy Bicha (jbicha) on 2017-06-06
description: updated
description: updated
Jeremy Bicha (jbicha) on 2017-06-06
Changed in libgweather (Ubuntu Zesty):
importance: Undecided → High
Changed in libgweather (Ubuntu):
importance: Undecided → High

Hello errors.ubuntu.com, or anyone else affected,

Accepted libgweather into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libgweather/3.24.1-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libgweather (Ubuntu Zesty):
status: In Progress → Fix Committed
tags: added: verification-needed

As part of a recent change in the Stable Release Update verification policy we would like to inform that for a bug to be considered verified for a given release a verification-done-$RELEASE tag needs to be added to the bug where $RELEASE is the name of the series the package that was tested (e.g. verification-done-xenial). Please note that the global 'verification-done' tag can no longer be used for this purpose.

Thank you!

Jeremy Bicha (jbicha) wrote :

Before applying this update, I was able to easily crash GNOME Shell in a default clean updated Ubuntu GNOME 17.04. All I had to do with click the system status menu in the top right and enable Location.

After updating to libgweather 3.24.1-0ubuntu0.1, I can't reproduce the crash.

tags: added: verification-done-zesty
removed: verification-needed
Brian Murray (brian-murray) wrote :

I also utilized a database query for the bucket associated with this crash to check the dependencies for the libgweather version of crashes reported in June of 2017. This is the result:

1091 examined.
(u'3.18.2-0ubuntu0.1', 7)
(u'3.24.0-0ubuntu2', 1082)

So the new version does fix the linked crash.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libgweather - 3.24.1-0ubuntu0.1

---------------
libgweather (3.24.1-0ubuntu0.1) zesty; urgency=medium

  * New upstream bugfix release
    - Fix memory corruption that crashes gnome-shell
      (LP: #1695567) (LP: #1688208) Thanks Tim Lunn for triaging!
  * Drop git_guard-against-segfault.patch, applied in new release

 -- Jeremy Bicha <email address hidden> Mon, 05 Jun 2017 23:06:59 -0400

Changed in libgweather (Ubuntu Zesty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for libgweather has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers