hotCorner modification breaks official apps-menu extension

[Matthew D. Mower]

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/6

---

Ubuntu 17.10 x64
Activities Overview Hot Corner disabled using Gnome Tweaks

When hot corners are disabled, the official Gnome Extension "Applications Menu"
 (https://extensions.gnome.org/extension/6/applications-menu/) is broken -- error shows when attempting to enable extensions and clicking menu does nothing. A small fix to the extension was suggested to the developer "Apps-menu crashes when there is no hotcorner"
 (https://bugzilla.gnome.org/show_bug.cgi?id=712625) but his response is that this problem does not fall in his court, at least while "dconf config option for disabling the activities hot corner" (https://bugzilla.gnome.org/show_bug.cgi?id=688320) is still open.

[Sebastien Bacher (seb128)]

Unsure what we can do if upstream is not wanting to update their extension to handle that case well just to make a point, maybe somebody should create a new one including the suggested change?

[Matthew D. Mower (mdmower)]

The issue appears to stem from the Main.layoutManager.hotCorners[] array being empty when hot corners are disabled:
https://git.gnome.org/browse/gnome-shell-extensions/tree/extensions/apps-menu/extension.js?id=01893ca0485806f181d0401b7a6347a4adaa71de#n483

Would it be possible to leave the Main.layoutManager.hotCorners[] array defined and disable the activity overview by substituting no-op functions for actions? This is how the "No Topleft Hot Corner" extension works: https://github.com/HROMANO/nohotcorner/blob/f02c0398fe59202ba01b35ae04f8fe1fb46008e1/extension.js#L7

[Matthew D. Mower (mdmower)]

In fact, I'm not sure if this is this a bug with gnome-shell or with gnome-tweak-tool and the method it uses to disable hot corners.

[Daniel van Vugt (vanvugt)]

Someone could always attempt a proper fix and propose it upstream. If upstream don't have to do the work then they might be more accepting of a fix.

[Denis Gorodnichev (d-g)]

introduced by optional-hot-corner.patch

fix:

diff --git a/extensions/apps-menu/extension.js b/extensions/apps-menu/extension.js
index adc77a4..939a07c 100644
--- a/extensions/apps-menu/extension.js
+++ b/extensions/apps-menu/extension.js
@@ -240,17 +240,21 @@ class ApplicationsMenu extends PopupMenu.PopupMenu {
     }

     open(animate) {
- this._button.hotCorner.setBarrierSize(0);
- if (this._button.hotCorner.actor) // fallback corner
- this._button.hotCorner.actor.hide();
- super.open(animate);
+ if (this._button.hotCorner) {
+ this._button.hotCorner.setBarrierSize(0);
+ if (this._button.hotCorner.actor) // fallback corner
+ this._button.hotCorner.actor.hide();
+ super.open(animate);
+ }
     }

     close(animate) {
         let size = Main.layoutManager.panelBox.height;
- this._button.hotCorner.setBarrierSize(size);
- if (this._button.hotCorner.actor) // fallback corner
- this._button.hotCorner.actor.show();
+ if (this._button.hotCorner) {
+ this._button.hotCorner.setBarrierSize(size);
+ if (this._button.hotCorner.actor) // fallback corner
+ this._button.hotCorner.actor.show();
+ }
         super.close(animate);
     }

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "hotcorner.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Daniel van Vugt (vanvugt)]

Denis,

Please propose your fix to the developers here:

  https://gitlab.gnome.org/GNOME/gnome-shell-extensions

[Daniel van Vugt (vanvugt)]

Also, the upstream bug report ID is gnome-shell-extensions#6

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/6

[Daniel van Vugt (vanvugt)]

Oh, upstream already has a fix proposed:

https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/7

[Daniel van Vugt (vanvugt)]

Note this is not an SRU. The fix needs to land in the latest development release first (19.04).

[Denis Gorodnichev (d-g)]

merge request https://gitlab.gnome.org/GNOME/gnome-shell-extensions/merge_requests/48