Dock location reversed in RTL

Bug #1876937 reported by Yaron on 2020-05-05
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-control-center (Ubuntu)
Low
Marco Trevisan (Treviño)
Focal
Undecided
Unassigned
gnome-shell-extension-ubuntu-dock (Ubuntu)
Low
Unassigned

Bug Description

* Impact

he dock location is horizontally reversed, selecting left puts the dock to the right and vice versa.

* Test Case

Steps to reproduce (Ubuntu 20.04):

1. Switch to an RTL language of your choice

2. Open GNOME Settings

3. Observe the Appearance icon (The default dock location is to the right while the icon shows as if it's to the left)

4. The selection says "Left" (שמאל in Hebrew) yet the dock is aligned to the right, selecting the opposite option moves the dock to the left although I selected "Right" (ימין in Hebrew).

* Regression potential

Check that the position setting does match what the dock is doing

Gunnar Hjalmarsson (gunnarhj) wrote :
affects: gnome-control-center (Ubuntu) → gnome-shell-extension-ubuntu-dock (Ubuntu)
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → Low
affects: gnome-control-center → ubuntu
no longer affects: ubuntu
Changed in gnome-control-center (Ubuntu):
importance: Undecided → Low
description: updated
tags: added: focal rtl
Yaron (sh-yaron) wrote :

@gunnarhj - I thought about that but we need to add a comment and enforce this decision for all the other RTL languages (I'm guessing Arabic, Persian and Urdu mainly).

Sebastien Bacher (seb128) wrote :

It would be better handle at the code level, the dashtodock setting do that

https://github.com/micheleg/dash-to-dock/commit/eb2aaf81

Gunnar Hjalmarsson (gunnarhj) wrote :

Changing the code would indeed be better; my idea was semiserious.

Daniel van Vugt (vanvugt) wrote :

See also bug 1877108

Mmhmh, I think the problem is more in control-center than in the dock, no?

In the sense that the code of the dock just considers a dock set to the "left" in RTL world to be actually to the right. So, while setting may be misleading, I would not invert that but instead I'd change the way it's handled in g-c-c depending on the language.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: New → Won't Fix
Changed in gnome-control-center (Ubuntu):
status: New → In Progress
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.36.3-1ubuntu1

---------------
gnome-control-center (1:3.36.3-1ubuntu1) groovy; urgency=medium

  * New upstream version rebased on Debian (lp: #1884063)

  [ Gunnar Hjalmarsson ]
  * debian/patches/0030-temporarily-revert-alt-char-key.patch:
    - Change po/POTFILES.in too, so dh_translations can create
      gnome-control-center-2.0.pot.
  * d/p/0015-connectivity-add-network-connectivity-checking-toggl.patch:
    - Add "privacy" to Keywords in the .desktop file in line with
      https://gitlab.gnome.org/GNOME/gnome-control-center/-/commit/05f3cb67
      (LP: #1869288)

  [ Marco Trevisan (Treviño) ]
  * d/p/0008-Allow-tweaking-some-settings-for-Ubuntu-Dock.patch:
    - Ensure dock position is respected in RTL (LP: #1876937)
    - Add proper matching the dock monitor ID (LP: #1877108)
  * d/p/0024-display-Allow-fractional-scaling-to-be-enabled.patch:
    - Improve fractional scaling toggling (LP: #1876891, #1876894)
    - Look for proper fractional scaling key in Wayland and X11 (LP: #1871864)
  * d/p/0031-fingerprint-dialog-Don-t-limit-the-number-of-maximum.patch:
    - Don't make flowbox children selectable (LP: #1877441)

 -- Sebastien Bacher <email address hidden> Thu, 18 Jun 2020 13:44:56 +0200

Changed in gnome-control-center (Ubuntu):
status: In Progress → Fix Released
Yaron (sh-yaron) wrote :

Thank you Marco!
Your effort is very important to a large community of RTL Ubuntu users.

This is definitely bringing us one step closer to improving the overall usage experience for those crazy languages speakers :)

description: updated

Hello Yaron, or anyone else affected,

Accepted gnome-control-center into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.36.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-control-center (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Sebastien Bacher (seb128) wrote :

@Yaron, any chance you could try how the update works for you?

Yaron (sh-yaron) wrote :

Yes! This is perfect, thank you!

Sebastien Bacher (seb128) wrote :

Thanks, marking the SRU as verified!

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.36.3-0ubuntu1

---------------
gnome-control-center (1:3.36.3-0ubuntu1) focal; urgency=medium

  * New stable version (lp: #1884063)

  [ Gunnar Hjalmarsson ]
  * debian/patches/0030-temporarily-revert-alt-char-key.patch:
    - Change po/POTFILES.in too, so dh_translations can create
      gnome-control-center-2.0.pot.

  [ Marco Trevisan (Treviño) ]
  * d/p/0008-Allow-tweaking-some-settings-for-Ubuntu-Dock.patch:
    - Ensure dock position is respected in RTL (LP: #1876937)
    - Add proper matching the dock monitor ID (LP: #1877108)
  * d/p/0024-display-Allow-fractional-scaling-to-be-enabled.patch:
    - Improve fractional scaling toggling (LP: #1876891, #1876894)
    - Look for proper fractional scaling key in Wayland and X11 (LP: #1871864)
  * d/p/0031-fingerprint-dialog-Don-t-limit-the-number-of-maximum.patch:
    - Don't make flowbox children selectable (LP: #1877441)

 -- Sebastien Bacher <email address hidden> Tue, 23 Jun 2020 17:50:27 +0200

Changed in gnome-control-center (Ubuntu Focal):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.