Ubuntu dock/launcher is shown on the lock screen

Bug #1769383 reported by Jenka Hanson on 2018-05-05
962
This bug affects 162 people
Affects Status Importance Assigned to Milestone
gnome-shell (Ubuntu)
Status tracked in Disco
Bionic
Undecided
Andrea Azzarone
Cosmic
Undecided
Andrea Azzarone
Disco
High
Andrea Azzarone
gnome-shell-extension-ubuntu-dock (Ubuntu)
Status tracked in Disco
Bionic
High
Andrea Azzarone
Cosmic
High
Andrea Azzarone
Disco
High
Andrea Azzarone

Bug Description

[Impact]
When entering the lock-screen mode, gnome-shell disables all the extensions. It can happen that under certain conditions ubuntu-dock re-enables itself, causing the ubuntu-dock to appear in the lock-screen, exposing sensitive information. One possible way to reproduce this is to enable dash-to-dock and ubuntu-dock at the same time.

[Test Case]
1. Make sure ubuntu-dock is enabled
2. Enable dash-to-dock too
3. Lock the screen
4. Make sure the dock does not appear on the lock screen
5. Make sure there is no warning is the journal

[Possible Regressions]
Even if it's something we don't really support please make sure that you can use dash-to-dock without uninstalling ubuntu-dock.

[Original Bug]

After an update from ubuntu 16.04 to 18.04 the dock is aviable on the lockscreen after user login.
I did not configure this knowingly. Also i can start every application which is available on the dock.
Settings, virtual box, visualstudio code and so on.

After the update to 18.04 i just configure the screen frequency to 144Hz and the night mode on. And attach the dock on bottom.

I later undid these customizations back to configuration before, but the dock is stil aviable on lockscreen.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: gnome-settings-daemon 3.28.1-0ubuntu1
ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
Uname: Linux 4.15.0-20-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Sat May 5 18:30:16 2018
InstallationDate: Installed on 2018-04-08 (27 days ago)
InstallationMedia: Ubuntu 16.04.4 LTS "Xenial Xerus" - Release amd64 (20180228)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-settings-daemon
UpgradeStatus: Upgraded to bionic on 2018-05-01 (3 days ago)
---
ApportVersion: 2.20.9-0ubuntu7
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
DistroRelease: Ubuntu 18.04
InstallationDate: Installed on 2018-04-08 (27 days ago)
InstallationMedia: Ubuntu 16.04.4 LTS "Xenial Xerus" - Release amd64 (20180228)
NonfreeKernelModules: nvidia_modeset nvidia
Package: gnome-shell-extension-ubuntu-dock 0.9.1
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
Tags: bionic
Uname: Linux 4.15.0-20-generic x86_64
UpgradeStatus: Upgraded to bionic on 2018-05-01 (4 days ago)
UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
_MarkForUpload: True

Jenka Hanson (jenia) wrote :
Jenka Hanson (jenia) wrote :
Jenka Hanson (jenia) wrote :
Tom Reynolds (tomreyn) on 2018-05-05
affects: gnome-settings-daemon (Ubuntu) → gnome-shell-extension-ubuntu-dock (Ubuntu)

apport information

tags: added: apport-collected
description: updated

apport information

It is also possible to close running applications or remove the icons from dock.

information type: Private Security → Public Security
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: New → Confirmed
Sebastien Bacher (seb128) wrote :

Do users hitting that issue played with dash-to-dock/gnome-tweaks? Could you attach your journal log after getting the issue?

Changed in gnome-shell (Ubuntu):
importance: Undecided → High
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → High
summary: - Dockbar after login is aviable in lockscreen
+ Ubuntu dock/launcher is shown on the lock screen
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell (Ubuntu):
status: New → Confirmed
Simon P. (simpre) wrote :

I am experiencing this issue too since the upgrade to 18.10. Sometimes in addition to the launcher I can even see an open program! Cannot use the program interface though before going to the unlock screen by pressing super + l and unlocking the system.

I have gnome-tweaks installed, used it only to activate the Yaru theme which was not working after the upgrade (bug 1798984). So I guess that doesn't qualify as play with it.

Simon P. (simpre) wrote :

Seems it was fixed with the last update. At least for me.

Simon P. (simpre) wrote :

No, still there. Lockscreen worked flawless for the last couple of locks, but I just ran into the same bug again.

Sebastien Bacher (seb128) wrote :

can you attach the journal log?

Changed in gnome-shell (Ubuntu):
status: Confirmed → Incomplete
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Confirmed → Incomplete
Bogdan Radu (bog-radu) wrote :

I still see this as well. I also notice that when hovering over the bar after this starts happening, it resizes by a few px.

It also results in things like remmina no longer populating it OR the top bar with its icons.

I do have gnome-tweaks installed, and seems that the resizing issue goes away when I start it up and change the hinting mode.

This happened to me when using Ubuntu Cosmic Cuttlefish with htop and tilix installed beyond the clean install. I was able to open the applications that are available in the dock and noticed the bar resizing when hovering over it.

Later multiple graphical bugs started to happen and in the next boot Xorg was failing to start. Rebooting again solved the login issues.

Plurtu (plurtu) wrote :

Workaround for 18.10 is to change the Dash to Dock setting "Customize opacity - Tune the dash background opacity" to "Fixed".

Ads20000 (ads20000) wrote :

Sebastien, here's the journal output (`journalctl -f` that's produced when I lock my screen on Ubuntu 18.10 and I reproduce this bug): https://paste.ubuntu.com/p/Y3MxnXzqXq/

Didier Roche (didrocks) wrote :

The best way to get it fixed is to be able to disable mod extensions, which is something I'm working on, and you can follow it on https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/2. This will probably be for dingo.

Mike Chaberski (mchaberski) wrote :

This seems like a duplicate of #1716982, but maybe it's a regression after that was fixed. Anyway, commenter ernstp identifies the cause in comment #12 [1]:

> Is it some global variable name conflict between the two extensions? "dockManager" perhaps?

You can edit /<email address hidden>/extension.js to check for a null dockManager in the disable() function. That is, change

    dockManager.destroy()

to

    if (dockManager != null) {
        dockManager.destroy();
    }

and the dock disappears when the screen is locked, as expected.

I'm guessing the problem is that Dash To Dock sets dockManager to null after calling destroy(), and then Ubuntu Dock throws a TypeError when it tries to do the same, so Ubuntu Dock never reaches the ExtensionSystem.disconnect() call.

[1] https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/+bug/1716982/comments/12

Plurtu (plurtu) wrote :

On 18.10 it still happens without Dash to Dock being installed.

I have the same issue in 18.10, I can reliably reproduce it by putting me laptop into sleep mode and waking it back up.

Sebastien Bacher (seb128) wrote :

Andrea, could you have a look?

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Incomplete → New
assignee: nobody → Andrea Azzarone (azzar1)
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: New → Confirmed
Andrea Azzarone (azzar1) wrote :

> The best way to get it fixed is to be able to disable mod extensions, which is something I'm working on, and you can follow it on https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/2. This will probably be for dingo.

The correct link is https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/2

Andrea Azzarone (azzar1) on 2018-11-12
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Confirmed → In Progress
Mike L (mikerl) wrote :

I did a clean install of Cosmic and the bug is present as well for me also.

Mike L (mikerl) wrote :

Land for dingo? What are the possibilities of a backport to both 18.04 and 18.10? Couldn't this be considered a security vulnerability? It can theoretically be used to close someone else's work out without saving, depending on the application.

Download full text (3.8 KiB)

There is not yet a fix for this problem. Do you known any reliable way to
reproduce it?

Il giorno lun 12 nov 2018, 23:50 Mike L <email address hidden> ha
scritto:

> Land for dingo? What are the possibilities of a backport to both 18.04
> and 18.10? Couldn't this be considered a security vulnerability? It can
> theoretically be used to close someone else's work out without saving,
> depending on the application.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1769383
>
> Title:
> Ubuntu dock/launcher is shown on the lock screen
>
> Status in gnome-shell package in Ubuntu:
> Incomplete
> Status in gnome-shell-extension-ubuntu-dock package in Ubuntu:
> In Progress
>
> Bug description:
> After an update from ubuntu 16.04 to 18.04 the dock is aviable on the
> lockscreen after user login.
> I did not configure this knowingly. Also i can start every application
> which is available on the dock.
> Settings, virtual box, visualstudio code and so on.
>
> After the update to 18.04 i just configure the screen frequency to
> 144Hz and the night mode on. And attach the dock on bottom.
>
> I later undid these customizations back to configuration before, but
> the dock is stil aviable on lockscreen.
>
> ProblemType: Bug
> DistroRelease: Ubuntu 18.04
> Package: gnome-settings-daemon 3.28.1-0ubuntu1
> ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
> Uname: Linux 4.15.0-20-generic x86_64
> NonfreeKernelModules: nvidia_modeset nvidia
> ApportVersion: 2.20.9-0ubuntu7
> Architecture: amd64
> CurrentDesktop: ubuntu:GNOME
> Date: Sat May 5 18:30:16 2018
> InstallationDate: Installed on 2018-04-08 (27 days ago)
> InstallationMedia: Ubuntu 16.04.4 LTS "Xenial Xerus" - Release amd64
> (20180228)
> ProcEnviron:
> TERM=xterm-256color
> PATH=(custom, no user)
> XDG_RUNTIME_DIR=<set>
> LANG=de_DE.UTF-8
> SHELL=/bin/bash
> SourcePackage: gnome-settings-daemon
> UpgradeStatus: Upgraded to bionic on 2018-05-01 (3 days ago)
> ---
> ApportVersion: 2.20.9-0ubuntu7
> Architecture: amd64
> CurrentDesktop: ubuntu:GNOME
> DistroRelease: Ubuntu 18.04
> InstallationDate: Installed on 2018-04-08 (27 days ago)
> InstallationMedia: Ubuntu 16.04.4 LTS "Xenial Xerus" - Release amd64
> (20180228)
> NonfreeKernelModules: nvidia_modeset nvidia
> Package: gnome-shell-extension-ubuntu-dock 0.9.1
> PackageArchitecture: all
> ProcEnviron:
> TERM=xterm-256color
> PATH=(custom, no user)
> XDG_RUNTIME_DIR=<set>
> LANG=de_DE.UTF-8
> SHELL=/bin/bash
> ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
> Tags: bionic
> Uname: Linux 4.15.0-20-generic x86_64
> UpgradeStatus: Upgraded to bionic on 2018-05-01 (4 days ago)
> UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
> _MarkForUpload: True
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/gnome-shell/+bug/1769383/+subscriptions
>
> Launchpad-Notification-Type: bug
> Launchpad-Bug: distribution=ubuntu; sourcepackage=gnome-shell;
> component=main; status=Incomplete; importance=High; assignee=None;
>...

Read more...

Anders L. (vithiri) wrote :

This happens on a clean installation of 18.10 here as well, and I'd like to point out that the window miniature previews are clearly visible and in some cases even readable from the lock screen by right clicking the application icons and selecting "All Windows".

Iain Lane (laney) on 2018-11-13
tags: added: rls-cc-incoming rls-dd-incoming
Iain Lane (laney) on 2018-11-13
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
status: New → In Progress
assignee: nobody → Andrea Azzarone (azzar1)
Changed in gnome-shell (Ubuntu Cosmic):
status: New → Incomplete
Mike L (mikerl) wrote :

Unfortunately I have no clue what triggers the bug as of yet.

Kilian Pfeiffer (k1l1) wrote :

I hope you can fix it. This is super annoying for me and also a security issue because I don't always notice that the dock got unresponsive and also the locking does not work properly. I often press 'super+L' and rush away from my desk and then later see that the laptop didn't properly lock.

pdrd (pdrd) wrote :

@azzar1 Did you try out the suggested fix by @mchaberski? The enable() function sets dockManager intially to null and then calls conditionallyenabledock(). But in the disable() function always dockManager.destroy() gets called without a type-check raising a TypeError. I think the null-check should be implemented in any way.

This would explain why the suggested fix by @didrocks is working by disabling mod extensions, because disable() is not getting called anymore.

Maybe someone can try out if the code change fixes the bug for the normal dock, cause i am using dash-to-dock.

Daniel van Vugt (vanvugt) wrote :

Developers can't test and verify a fix until they are able to reproduce the bug. That's what comment #29 is about.

pdrd (pdrd) wrote :

Sorry, i missed comment #29, but there are a lot of bug reports out there, some of them over a year old, which describe the same issue.

My reproduction steps, tested on a virtualbox machine:

1) Fresh-Install Ubuntu 18.0.4.1 LTS
2) Install package 'chrome-gnome-shell'
3) Navigate to https://extensions.gnome.org/extension/307/dash-to-dock, install firefox/chrome extension and install dash-to-dock extension.
4) Restart
5) On next lock the ubuntu-dock reappears and the following journalctl /usr/bin/gnome-shell output is generated:

Nov 15 12:53:15 ubuntu gnome-shell[1143]: Extension "<email address hidden>" had error: TypeError: dockManager is null

The suggested fix is resolving this and a quick look into https://git.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/tree/extension.js?h=ubuntu/bionic exposes, that the issue is a simple missing null-check in the disable() function where dockManager.destroy() is called on a null-instance, which should be added in either way.

Daniel van Vugt (vanvugt) wrote :

This bug is about the default Ubuntu dock. People installing any additional custom extensions such as dash-to-dock should ideally not comment on bugs in Launchpad until after they have removed the extra extensions.

Although it is useful to know if and when some bugs are caused by third party extensions, I don't think this bug falls into that category...?

James Henstridge (jamesh) wrote :

I noticed this behaviour on my Ubuntu 18.10 system. It is running the Wayland session, and I only have the <email address hidden> and <email address hidden> extensions installed (i.e. no upstream dash-to-dock).

I looked in the journal and found the attached GJS stack trace, which seems to be triggered by the disable() call. I haven't been manually enabling/disabling extensions, so don't know why the code path would have been triggered. It might mean some crud was left behind though.

Plurtu (plurtu) wrote :

@jamesh your stack trace is caused by Ubuntu Dock's dynamic transparency which I mentioned before in Comment #17 and can be disabled with the following terminal command:

gsettings set org.gnome.shell.extensions.dash-to-dock transparency-mode FIXED

James Henstridge (jamesh) wrote :

The above stack trace seems to be tied to this other message:

Nov 16 11:41:38 scruffy gnome-shell[5626]: Object Meta.WindowActor (0x560d5092bb00), has been already deallocated — impossible to access it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.

The error seems to be on the disconnect() call in Transparency.disable():

        for (let key of this._trackedWindows.keys())
            this._trackedWindows.get(key).forEach(id => {
                key.disconnect(id);
            });
        this._trackedWindows.clear();

Presumably the remainder of the clean-up performed by this function and its callers is not performed, leaving the shell in an inconsistent state.

I'm still not sure why gnome-shell is trying to disable the extension. Does it disable extensions when locking the screen?

James Henstridge (jamesh) wrote :

Looking at the gnome-shell JS code referenced by the stack trace, it appears it is indeed disabling extensions when locking the screen.

The screenShield.js code handles the lock screen, and pushes and pops a "session mode" of "lock-screen". In sessioMode.js, the "lock-screen" mode is defined with allowExtensions=false. Finally, extensionSystem.js watches session mode changes and calls the various extension enable/disable callbacks as needed.

So somehow ubuntu-dock has a stale window in Transparency._trackedWindows that triggers an exception while trying to disable the dock when locking the screen. It fails to fully disable the dock, so it displays over the top of the lock screen.

pdrd (pdrd) wrote :

@vanvugt: You're absolutely right, but the dockManager-instance is null because of an explicit exception in https://git.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/tree/extension.js?h=ubuntu/bionic to disable ubuntu-dock if dash-to-dock is installed:

let to_enable = true;
let runningExtensions = ExtensionSystem.extensionOrder;
for (let i = 0; i < runningExtensions.length; i++) {
    if (runningExtensions[i] === "<email address hidden>") {
        to_enable = false;
    }
}

So i'm not able to fix this issue in the dash-to-dock repo. May we create a seperate bug report?

Daniel van Vugt (vanvugt) wrote :

Yes, maybe log a new bug with:

  ubuntu-bug gnome-shell-extension-dashtodock

Iain Lane (laney) on 2018-11-20
tags: removed: rls-cc-incoming rls-dd-incoming
Iain Lane (laney) on 2018-11-20
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Bionic):
assignee: nobody → Andrea Azzarone (azzar1)
Changed in gnome-shell (Ubuntu Disco):
assignee: nobody → Andrea Azzarone (azzar1)
Changed in gnome-shell (Ubuntu Cosmic):
assignee: nobody → Andrea Azzarone (azzar1)
Changed in gnome-shell (Ubuntu Bionic):
assignee: nobody → Andrea Azzarone (azzar1)
Andrea Azzarone (azzar1) wrote :
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Bionic):
status: New → In Progress
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-shell (Ubuntu Bionic):
status: New → Confirmed
Andrea Azzarone (azzar1) wrote :

The proposed fix has been merged. It not yet released but I'll take care of it.

Changed in gnome-shell (Ubuntu Bionic):
status: Confirmed → Invalid
Changed in gnome-shell (Ubuntu Cosmic):
status: Incomplete → Invalid
Changed in gnome-shell (Ubuntu Disco):
status: Incomplete → Invalid
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Disco):
status: In Progress → Fix Committed
Andrea Azzarone (azzar1) wrote :

The attachment "ubuntu-dock.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 63ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (63ubuntu2) disco; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/control:
    - Point Vcs-Git and Vcs-Browser to proper locations
  * dash, docking: remove Shell.GenericContainer

  [ Andrea Azzarone ]
  * docking: Fix leaking signal connection
  * extension: Ensure that ubuntu-dock will not re-enable itself during
    lockscreen if dash-to-dock is installed and enabled too. (LP: #1769383)

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 27 Nov 2018 12:28:28 -0500

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Disco):
status: Fix Committed → Fix Released
Andrea Azzarone (azzar1) on 2018-11-30
description: updated
Ads20000 (ads20000) wrote :

I think a lot of my problems were caused by installing Dash to Dock, changing settings, and then removing Dash to Dock. Some of the settings changed in Dash to Dock seem to affect the Ubuntu Dock that Ubuntu reverts to when Dash to Dock is removed. I think running `dconf reset -f /` fixes the problem, but note that this resets every other GNOME configuration you've made! ( https://www.omgubuntu.co.uk/2017/10/how-to-reset-ubuntu-desktop-to-default )

Ads20000 (ads20000) wrote :

Perhaps Andrea's patch resolves this, but even if it doesn't, that should resolve the problem - if you're going to install Dash to Dock, be sure that you won't want to go back again, and consider resetting everything GNOME with `dconf reset -f /` if you do...

Ads20000 (ads20000) wrote :

I take it back, that doesn't resolve the problem xD was worth a shot though!

Øistein Notnæs (oisnot) wrote :

Is this the same bug it's talked about here?

Daniel van Vugt (vanvugt) wrote :

Yes that screenshot shows this bug.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Bionic):
importance: Undecided → High
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
importance: Undecided → High
Hermann (felixedelmann) on 2018-12-07
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
status: In Progress → Fix Released
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
status: Fix Released → In Progress
賴家亨 (laichiaheng) wrote :

I was expected that I could receive the bug fix today, why is it in progress again?

Daniel van Vugt (vanvugt) wrote :

Hermann's change was incorrect. The fix for cosmic was not released.

Nothing has changed.

Saroumane (saroumane) wrote :

Hello,
For the record I reproduce this bug on a fresh new install of Ubuntu 18.10.

As it sounds like a 7-months-old critical security bug, I'm very interested in a reliable workaround.

Should I remove gnome-shell-extension-ubuntu-dock, and install upstream Dash to dock from https://extensions.gnome.org/extension/307/dash-to-dock/ ?

(I already had to remove gnome-shell-extension-appindicator to install the 'almost' bug free upstream app-indicator)

Thanks for your help !

Is this fix released for Ubuntu 18.10?

Dom Hudson (domhudson) wrote :

I don't believe there is a fix yet. Best workaround I've found is to purge the extension and install upstream as shown here https://github.com/micheleg/dash-to-dock/issues/649#issuecomment-424182892

Eric Newberry (ericnewberry) wrote :

I used to encounter this issue frequently on 18.10. However, I have not encountered it since I upgraded gnome-shell to 3.30.1-2ubuntu1.18.10.1 approximately five days ago.

Eric I have this version and I experienced the issue 2 days ago.

Wolf Rogner (war-rsb) wrote :

It is not fixed.

Benjamin Reich (chillfre4k) wrote :

When is the release for bionic and cosmic?

Michael MacEachern (maceach-b) wrote :

Being that it's been 7 months since this has been reported, why has it not been fixed yet? Are we trying to make Ubuntu's security a complete joke? Because that's where we are heading with this. This should have been fixed 7 months ago and top priority. There are people who use Ubuntu in enterprise environments, and considering 18.04 is LTS, it is disgusting that this has not been fixed yet.

Get your act together Canonical.

Yan Li (yanli) wrote :

While I wholeheartedly agree that we urgently need an official fix, I also want to point out that

gsettings set org.gnome.shell.extensions.dash-to-dock transparency-mode FIXED

is an effective workaround for me. On my Cosmic, I have never seen the dock again on the lock screen. I'm using vanilla Ubuntu docker with no dash-to-docker or any other customization to the dock.

Dom Hudson (domhudson) wrote :
Download full text (4.4 KiB)

Interesting, thanks I will try that fix. I do agree that it's not good that
it's still occurring as it's present on vanilla installs straight out of
the box

On Mon, 24 Dec 2018, 21:05 Yan Li <<email address hidden> wrote:

> While I wholeheartedly agree that we urgently need an official fix, I
> also want to point out that
>
> gsettings set org.gnome.shell.extensions.dash-to-dock transparency-mode
> FIXED
>
> is an effective workaround for me. On my Cosmic, I have never seen the
> dock again on the lock screen. I'm using vanilla Ubuntu docker with no
> dash-to-docker or any other customization to the dock.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1769383
>
> Title:
> Ubuntu dock/launcher is shown on the lock screen
>
> Status in gnome-shell package in Ubuntu:
> Invalid
> Status in gnome-shell-extension-ubuntu-dock package in Ubuntu:
> Fix Released
> Status in gnome-shell source package in Bionic:
> Invalid
> Status in gnome-shell-extension-ubuntu-dock source package in Bionic:
> In Progress
> Status in gnome-shell source package in Cosmic:
> Invalid
> Status in gnome-shell-extension-ubuntu-dock source package in Cosmic:
> In Progress
> Status in gnome-shell source package in Disco:
> Invalid
> Status in gnome-shell-extension-ubuntu-dock source package in Disco:
> Fix Released
>
> Bug description:
> [Impact]
> When entering the lock-screen mode, gnome-shell disables all the
> extensions. It can happen that under certain conditions ubuntu-dock
> re-enables itself, causing the ubuntu-dock to appear in the lock-screen,
> exposing sensitive information. One possible way to reproduce this is to
> enable dash-to-dock and ubuntu-dock at the same time.
>
> [Test Case]
> 1. Make sure ubuntu-dock is enabled
> 2. Enable dash-to-dock too
> 3. Lock the screen
> 4. Make sure the dock does not appear on the lock screen
> 5. Make sure there is no warning is the journal
>
> [Possible Regressions]
> Even if it's something we don't really support please make sure that you
> can use dash-to-dock without uninstalling ubuntu-dock.
>
> [Original Bug]
>
> After an update from ubuntu 16.04 to 18.04 the dock is aviable on the
> lockscreen after user login.
> I did not configure this knowingly. Also i can start every application
> which is available on the dock.
> Settings, virtual box, visualstudio code and so on.
>
> After the update to 18.04 i just configure the screen frequency to
> 144Hz and the night mode on. And attach the dock on bottom.
>
> I later undid these customizations back to configuration before, but
> the dock is stil aviable on lockscreen.
>
> ProblemType: Bug
> DistroRelease: Ubuntu 18.04
> Package: gnome-settings-daemon 3.28.1-0ubuntu1
> ProcVersionSignature: Ubuntu 4.15.0-20.21-generic 4.15.17
> Uname: Linux 4.15.0-20-generic x86_64
> NonfreeKernelModules: nvidia_modeset nvidia
> ApportVersion: 2.20.9-0ubuntu7
> Architecture: amd64
> CurrentDesktop: ubuntu:GNOME
> Date: Sat May 5 18:30:16 2018
> InstallationDate: Installed on 2018-04-08 (27 days ago)
> InstallationMedia: Ubuntu 16.04....

Read more...

Michael MacEachern (maceach-b) wrote :

Yea, while a simple command may fix it, it should not be present on an out of the box install. A security bug as serious as this, should never have been left to the administrators to find out the hard way that data may be compromised because there was nothing in known-issues demonstrating that this flaw even existed.

Simon P. (simpre) wrote :

It is quite concerning to see how long it takes to fix security-sensitive bugs like this in Ubuntu.

Anyways, what I wanted to add: To kind of make it worse, after the bug happens and after logging in, the dock is not working properly any more - when new programs are started that were not on the launcher before, the according symbol is not displayed in the launcher.

Wolf Rogner (war-rsb) wrote :

I long have given up on this.

However here are two more observations.

Confirming Simon P.'s (simpre) observation that applications are not docked.

Another issue: when clicking on the activities button once, it does not show the app overview. It requires a second click.

This is also true with any activation (like Meta-L to lock the machine).

Another anecdote:
Yesterday I did some programming. I locked the machine and put it to sleep (another function that used to work reliably and now is completely broken) but when I came back, it was up and running. The IDE was visible. I could position the cursor and enter text.

The text was not echoed on the screen but after unlocking the text was there. If this was crucial code anyone could render it unusable or add to it.

@Andrea Azzarone: This is a severe security issue to me and many others. I hope the proposed fix (as noted above) is really fixing this issue and comes out soon. It's a shame that something like this passes rollout (although I have some understanding for that) but even more so the initial ignorance and reluctance to trust hundreds of users that there is an issue that needs quick fixing (which I have no understanding for whatsoever).

Dom Hudson (domhudson) wrote :

I can confirm that I also see the following side effects*:

- Lockscreen shortcut (meta + L) requires two attempts to register.
- Activities button requires two attempts to register.
- Icons in dock resize by a few pixels when you put your cursor over them.
- Additional icons no longer appear in the dock (for applications which are not already in the favourites).

* These only present themselves after I have logged out, confirmed that the dock is displaying on the lock screen and then logged back in.

Benjamin Reich (chillfre4k) wrote :

There is only a fix released for disco. When can we expect a fix for Cosmic and Bionic?

moreje (j-redoute) wrote :

same behavior for me using Ubuntu 18.10

- Lockscreen shortcut (meta + L) requires two attempts to register.
- Activities button requires two attempts to register.
- Icons in dock resize by a few pixels when you put your cursor over them.

Hello Jenka, or anyone else affected,

Accepted gnome-shell-extension-ubuntu-dock into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/63ubuntu1.18.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-cosmic

I installed dash-to-dock to test this. I locked the PC and unlocked it without an issue. The dock didn't appear in the lock screen.

gnome-shell-extension-ubuntu-dock:
  Installed: 63ubuntu1.18.10.1
  Candidate: 63ubuntu1.18.10.1

tags: added: verification-done verification-done-cosmic
removed: verification-needed verification-needed-cosmic
Jesse (yavyash) wrote :

Efthimios, were you able to verify that the problem existed before you installed the new package? I've been experiencing this problem for months, but sporadically. I tried installing the new package and was fine most of the time, but did see a dock on the lock screen once (though it could be that I forgot to restart after installing).

Yes, the problem existed before installing the package. I too experienced this sporadically. I assume installing dash-to-dock causes the issue to appear consistently. I experienced the issue without dash-to-dock installed.

Jesse (yavyash) wrote :

Hmm...I'm not sure that's a good assumption. I also was experiencing the issue without dash-to-dock. I made sure I was on the old version and installed dash-to-dock, and still could not replicate the issue reliably. I'm hesitant to say the patch is verified until we've gone an extended period without seeing the problem under the new package. But I guess that's what the week waiting period is for. :)

Jesse (yavyash) wrote :

OK, I just experienced the issue again after resuming from suspend with the new package installed. (Not sure whether the package version number was updated for the candidate, but I'm using the one with SHA1 e51a7f3a77c2643714b9ca68b6707584c82784ce.)

I've attached the journalctl output.

There's a very faint chance I didn't restart yesterday after reinstalling this package, but I've certainly restarted gnome-shell quite a few times, so I'm fairly certain the problem is recurring even with the fix.

Devs: please let me know if there's something else I can do to help test or resolve this problem.

Jesse Running "apt-cache policy <Package name>" shows the version of the package installed

Jesse (yavyash) wrote :

Yes, it's version 63ubuntu1.18.10.1. I just couldn't remember if that was also the pre-update version number. But I guess it wouldn't have pulled in the update if the version number wasn't different.

Don't forget to change the tags to verification-failed if the new package doesn't fix the issue. From what you said it's still present, at least for you.

Jesse (yavyash) on 2019-01-11
tags: added: verification-failed verification-failed-cosmic
removed: verification-done verification-done-cosmic
Simon May (socob) wrote :

I can also confirm that this issue still occurs even with the version in -proposed. The only difference I’ve noticed with the new version is that the text on the keyboard layout indicator sometimes disappears.

I've noticed the text on the keyboard layout indicator disappear too.

Jesse (yavyash) wrote :

A bit more information potentially useful for debugging:

 * Once the bug occurs once, it keeps recurring every time the screen locks at least until gnome-shell is restarted. (It's possible it only occurs on idle; I forgot to test manual lock before restarting gnome-shell and losing the buggy behavior.)

 * I, too, get the problem where mousing over some dock icons (particularly ones that are not pinned) causes the icon spacing to expand, leading to a bit of sideways jitter. This does not happen every time. Strangely, when it does happen, I *don't* get the problem where my non-GNOME tray icons (Dropbox, Skype, etc.) disappear after unlocking.

 * With more careful experimentation, I was able to isolate some journalctl errors from the time of locking and the time of unlocking. I've attached the journalctl output.

Kilian Pfeiffer (k1l1) wrote :

I can also confirm with
gnome-shell-extension-ubuntu-dock:
  Installed: 63ubuntu1.18.10.1
  Candidate: 63ubuntu1.18.10.1
  Version table:
 *** 63ubuntu1.18.10.1 500
        500 http://de.archive.ubuntu.com/ubuntu cosmic-proposed/main amd64 Packages
        500 http://de.archive.ubuntu.com/ubuntu cosmic-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     63ubuntu1 500
        500 http://de.archive.ubuntu.com/ubuntu cosmic/main amd64 Packages
        500 http://de.archive.ubuntu.com/ubuntu cosmic/main i386 Packages

the bug still occurs.

Andrea Azzarone (azzar1) wrote :

I proposed a fix upstream here: https://github.com/micheleg/dash-to-dock/pull/868

Hopefully, this will be uploaded in Disco in the next few days and should be SRUed both in Cosmic and Bionic in the next few weeks. Thanks!

Ads20000 (ads20000) wrote :

In response to comments complaining about fix times etc, I do not think complaining in comments helps, it just creates noise. There's a button at the top to mark oneself as affected by the bug as a replacement for making that kind of comment (one can argue that it should been marked as Critical rather than High because this is a security issue, however). If you want to complain about bug response times, I suggest making a new topic on community.ubuntu.com/c/desktop and make practical suggestions about how they could be made faster.

Additionally, someone mentioned that this should have been in the release notes. I think you can mark this bug as affecting the ubuntu-release-notes project to flag up the fact that you believe that it should be in the release notes, though I can't remember if release notes can be amended post-release or not?

I recognize that I'm creating noise myself by posting this comment...

Daniel van Vugt (vanvugt) wrote :

This bug is certainly hotter than any other recent bug affecting 19.04 (for example) that I can find. So we should give it high priority as we have. And the fact that it's a security bug is already shown separately in the top right of the page.

Andrea has already mentioned in comment #86 that he has a fix, and it appears to have landed upstream only 5 hours ago: https://github.com/micheleg/dash-to-dock/pull/868

So fixes to 18.10 and 18.04 should follow soon.

P.S. The release notes are editable here:
https://wiki.ubuntu.com/BionicBeaver/ReleaseNotes
https://wiki.ubuntu.com/CosmicCuttlefish/ReleaseNotes

Andrea Azzarone (azzar1) wrote :

The fix has already been released in disco: https://launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/64ubuntu2

We're already working to backport (SRU) the fix in cosmic. The fix will hit cosmic-proposed soon and you'll be notified as soon this happens. Thanks!

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Cosmic):
status: Fix Committed → In Progress
Miakoda Combies (hellomiakoda) wrote :

The proposed work-around, setting dash-to-dock's opacity to fixed, does not accomplish anything on my system.
Ubuntu 18.10 - Gnome 3.30.2

To post a comment you must log in.