Allow launching more cumbersome than necessary

[corrado venturini]

Copied an app eg firefox.desktop from /usr/share/applications to desktop.
new icon on desktop is a gray rectangle with a gear.
right click on the icon on desktop.
click on 'Allow launching' - nothing happen
  - icon should change to Firefox icon and Firefox should start if clicked
click on Properties -> Permissions -> Allow executing: OK
problem both in Wayland and X11.
journalctl says:
feb 26 13:50:53 corrado-x5-hh-0107 systemd-resolved[614]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP.
feb 26 13:50:53 corrado-x5-hh-0107 systemd-resolved[614]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP.
feb 26 13:50:54 corrado-x5-hh-0107 systemd-resolved[614]: Server returned error NXDOMAIN, mitigating potential DNS violation DVE-2018-0001, retrying transaction with reduced feature level UDP.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 0.18.0-0ubuntu1

---------------
gnome-shell-extension-desktop-icons-ng (0.18.0-0ubuntu1) impish; urgency=medium

  * New upstream release
    - Fixed LP: #1917044 through e31c9df1 "Update desktop via dbus
      metadata change"
  * d/p/fileItem.js_Add_support_for_rendering_at_high_DPI_scales.patch:
    - Dropped, applied upstream
  * d/p/upstream-commits-until-20210712.patch
    - All upstream commits since the 0.18.0 release (LP: #1826056,
      LP: #1917010)
  * d/p/desktopGrid_Compare_rubberband_bounds_in_global_coord.patch:
    - Dropped, applied upstream

 -- Gunnar Hjalmarsson <email address hidden> Wed, 14 Jul 2021 19:31:45 +0200

[corrado venturini (corradoventu)]

Problem NOT fixed? I still need 'allow launching' PLUS change permissions
corrado@corrado-x2-ii-0713:~$ apt policy gnome-shell-extension-desktop-icons-ng
gnome-shell-extension-desktop-icons-ng:
  Installed: 0.18.0-0ubuntu2
  Candidate: 0.18.0-0ubuntu2
  Version table:
 *** 0.18.0-0ubuntu2 500
        500 http://archive.ubuntu.com/ubuntu impish/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu impish/main i386 Packages
        100 /var/lib/dpkg/status
corrado@corrado-x2-ii-0713:~$

[Gunnar Hjalmarsson (gunnarhj)]

@corrado: The discussion at

https://gitlab.com/rastersoft/desktop-icons-ng/-/issues/111

indicates that

https://gitlab.com/rastersoft/desktop-icons-ng/-/commit/e31c9df1

fixes it. But the upstream issue has not been closed; maybe there is more into it. I re-opened this bug for now.

[corrado venturini (corradoventu)]

Still having the problem with:
corrado@corrado-n3-jj-0103:~$ apt policy gnome-shell-extension-desktop-icons-ng
gnome-shell-extension-desktop-icons-ng:
  Installed: 35-1
  Candidate: 35-1
  Version table:
 *** 35-1 500
        500 http://archive.ubuntu.com/ubuntu jammy/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu jammy/main i386 Packages
        100 /var/lib/dpkg/status
corrado@corrado-n3-jj-0103:~$

[Gunnar Hjalmarsson (gunnarhj)]

Isn't that discussion finalized upstream by now? Yes, the execute bit needs to be set, and in addition to that you need to explicitly allow launching. What problem is it that remains?

[corrado venturini (corradoventu)]

In Ubuntu 20.04 with gnome-shell-extension-desktop-icons just allow launching is enough.

[Gunnar Hjalmarsson (gunnarhj)]

On 2022-01-14 09:34, corrado venturini wrote:
> In Ubuntu 20.04 with gnome-shell-extension-desktop-icons just allow
> launching is enough.

Confirmed. In 20.04 "Allow launching" seems to run "chmod u+x" or something in addition to the other stuff.

The 20.04 solution is more convenient. When reading the discussion at the upstream issue, I don't see that aspect being addressed at all.

So..

Any chance you can submit an upstream issue, and point at this specific regression compared to the original desktop icons project?

Thanks!

[Gunnar Hjalmarsson (gunnarhj)]

From the onAllowDisallowLaunchingClicked() function

https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-desktop-icons-ng/-/blob/debian/master/fileItem.js#L483

the apparent intention is that selecting "Allow launching" should be sufficient.

The equivalent function in gnome-shell-extension-desktop-icons (used in 20.04) differs in details:

https://salsa.debian.org/gnome-team/shell-extensions/gnome-shell-extension-desktop-icons/-/blob/debian/master/fileItem.js#L615

@Daniel: Can you see why the file permissions are not changed as intended?

[Gunnar Hjalmarsson (gunnarhj)]

Output when running ding.js from terminal and attempting "Allow Launching":

gunnar@gunnar-ubuntu-dev:/<email address hidden>$ ./ding.js
Gjs-Message: 00:26:38.815: JS LOG: Error connecting to Nautilus
GNOME nautilus 41.1

(gjs:4203): Gjs-CRITICAL **: 00:26:59.754: JS ERROR: TypeError: this._file.set_attributes is not a function
onAllowDisallowLaunchingClicked@/<email address hidden>/fileItem.js:495:24
showMenu/<@/<email address hidden>/fileItemMenu.js:184:37
@./ding.js:176:9

[Gunnar Hjalmarsson (gunnarhj)]

I submitted an upstream issue:

https://gitlab.com/rastersoft/desktop-icons-ng/-/issues/201

[Gunnar Hjalmarsson (gunnarhj)]

... and now fixed upstream:

https://gitlab.com/rastersoft/desktop-icons-ng/-/commit/6efde4c1

The fix will make it to Ubuntu next time we upgrade to a new upstream release.

@corrado: Thanks for your persistence on this matter, and sorry for being slow with understanding what you tried to say. :/

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell-extension-desktop-icons-ng - 39-1

---------------
gnome-shell-extension-desktop-icons-ng (39-1) unstable; urgency=medium

  * New upstream release (LP: #1917044)

 -- Gunnar Hjalmarsson <email address hidden> Thu, 10 Feb 2022 15:56:07 +0100