revert old behavoir of keyboard layout indicator: we wants use flags!

Bug #623435 reported by Sergey Klimov on 2010-08-24
This bug affects 33 people
Affects Status Importance Assigned to Milestone
gnome-settings-daemon (Ubuntu)
Karl Lattimer

Bug Description

Binary package hint: gnome-settings-daemon

please, add feature to new keyboard indicator - indicate keyboard layout with country flag, not ugly keyboard icon + country name.
i can draw monochrome flags for countries.
look at theme on russian's ubuntu forum: people enjoy this functionality
i think, this panel, for example, looks well

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: gnome-settings-daemon 2.30.2-0ubuntu4
ProcVersionSignature: Ubuntu 2.6.35-17.23-generic
Uname: Linux 2.6.35-17-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
Date: Tue Aug 24 18:12:30 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha amd64 (20100803.1)
 PATH=(custom, user)
SourcePackage: gnome-settings-daemon

Sergey Klimov (nbdarvin) wrote :
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, subscribing Karl who worked on the change, Karl how much work would that be to replace the icon by a flag as described? It's a wishlist but probably comes after some of the other indicator changes

Changed in gnome-settings-daemon (Ubuntu):
importance: Undecided → Wishlist
Karl Lattimer (karl-qdh) wrote :

The screenshot here is the desired outcome. However, the background rectangle and the two letter name for the layout are slightly more difficult. Requiring some investigation into all the available abbreviations and a solution to deal with the overall size of the text and an API change to libindicator to change the background, unless we can find a decent way to skin an icon only.

We decided to stick with just a label for now until we can get to exactly where we want it to be.

My question is, how were you changing the icon in the first place? From what I've seen of the code the text was extracted and applied directly, which is the behaviour we've tried to mimic here. There was no themable icon, or was there?

@Seb128, what might be possible is to set the flag icon which was used in the status icon menu to be used in place of the keyboard icon, then we've got flag + label. Still not 100% sure how easy that'll be but I can give it a go.

Related bug:

Karl Lattimer (karl-qdh) on 2010-08-25
Changed in gnome-settings-daemon (Ubuntu):
assignee: nobody → Karl Lattimer (karl-qdh)
Karl Lattimer (karl-qdh) wrote :

I've started working on a patch which will show the flag. If successful, we may be able to come up with something like [FLAG] 1,2,3,4 for different layouts.

Changed in gnome-settings-daemon (Ubuntu):
status: New → In Progress
Karl Lattimer (karl-qdh) wrote :

I have a working patch which I'll be uploading to bug soon.

This will show the flags adjacent to the full label.

Karl Lattimer (karl-qdh) on 2010-08-31
Changed in gnome-settings-daemon (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 2.31.91-0ubuntu2

gnome-settings-daemon (2.31.91-0ubuntu2) maverick; urgency=low

  * debian/patches/08_xrandr_command.patch:
    - still call gnome-display-properties to configure the display, the
      control center changes didn't land this cycle (lp: #631761)
  * 06_use_application_indicator.patch: updated version by Karl Lattimer
    - don't start using cpu when switching layout (lp: #624477)
    - respect the option to display flag icons (lp: #623435)
 -- Sebastien Bacher <email address hidden> Mon, 06 Sep 2010 19:38:10 +0200

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Mike (mike-fdb) wrote :

>respect the option to display flag icons
Does not work for me. I have "showFlags" config turned ON, and PNG files in ~/.icons/flags, us.png and ru.png
However, I've got "black sheet" icons instead of flags.

Karl Lattimer (karl-qdh) wrote :

If you're seeing a black square then the code is working, the problem therefore will be in the filenames.

Can you check the gnome screensaver login dialog and see if the icons appear there.

Unfortunately I'm away from home right now so I can't do any testing myself, will look into it further with you on monday if you'd like.

Mike (mike-fdb) wrote :

Karl, yes gnome login dialog shows flags and code works.
But prior to Ubuntu 10.10 beta, custom icons path was like ~/.icons/flags/us.png
So please have a look at new paths.

Mike (mike-fdb) wrote :

Well, ~/.icons/flags/us.png is a right path. Icons does work in login screen and if I remove these icons they replaced with red "stop" icon. However, there is a black in gnome tray.

Mike (mike-fdb) wrote :

Any news on this bug? Currently I have gnome-settings-daemon version 2.32.0-0ubuntu1 and still no (valid) icons.

Turbid (turbidit) wrote :

I confirm this bug

>Can you check the gnome screensaver login dialog and see if the icons appear there.

gnome screensaver shows flags

on panel - ugly box:

Karl Lattimer (karl-qdh) wrote :

flags are only working in the indicator applet, you're using the notification area.

Turbid (turbidit) wrote :

>flags are only working in the indicator applet, you're using the notification area.

And what if I do not want to use the indicator applet? I like standart gnome notification area.

waster (waster2007) wrote :

Yes, it shows flags if indicator applet is loaded only. But what if I don't want to use indicator applet? Is it possible to correct that?

hatul (amiadb) on 2010-10-20
description: updated
Pietro (pietro) wrote :

@waster, I think you can disable the appearance of the keyboard indicator applet entirely through gconf-editor:

gamar (gamar) wrote :

I join waster.
I don't want to use the crappy indicator applet (with huge spaces and no preferences control).
Still I appreciate keyboard notification in my notification area, but it the moment (10.10) it either shows the meaningless keyboard icon or if showFlags is true, then it shows only 'icon error';
p.s. mind that I am also using (apparently related) Typing monitor, which experience the same 'icon error' issue in the notification area.
I would like to have the old (9.10) functionality back!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints