gnome-screenshot crashes with core dump

[Blackbug]

gnome-screenshot crashes with core dump when incorrect filename is entered with '/'.
I guess a check for '/' is required, investigating further.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: gnome-screenshot 3.3.91-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-18.28-generic 3.2.9
Uname: Linux 3.2.0-18-generic x86_64
ApportVersion: 1.94-0ubuntu2
Architecture: amd64
Date: Thu Mar 8 00:31:38 2012
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
SourcePackage: gnome-screenshot
UpgradeStatus: Upgraded to precise on 2012-03-06 (1 days ago)
---
ApportVersion: 1.94-0ubuntu2
Architecture: amd64
DistroRelease: Ubuntu 12.04
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
Package: gnome-screenshot 3.3.91-0ubuntu1
PackageArchitecture: amd64
ProcVersionSignature: Ubuntu 3.2.0-18.28-generic 3.2.9
Tags: precise
Uname: Linux 3.2.0-18-generic x86_64
UpgradeStatus: Upgraded to precise on 2012-03-06 (1 days ago)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

[Blackbug (blackbug-nx)]

apport information

[Blackbug (blackbug-nx)]

apport information

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Benjamin Kerensa (bkerensa)]

Thanks for reporting this bug and any supporting documentation. Since this bug has enough information provided for a developer to begin work, I'm going to mark it as confirmed and let them handle it from here. Thanks for taking the time to make Ubuntu better!

[Benjamin Kerensa (bkerensa)]

I was able to reproduce and have attached a screenshot and updated the status of bug ^
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

[Blackbug (blackbug-nx)]

I guess the file "screenshot-dialog.c" in the source code should have a check to cater this problem, around line number 304 where it return gchar* which contains the file name string.
However i am not sure about '/' mechanism while saving files in ubuntu, because I could see at line number 276 of the same file (screenshot-dialog.c) another gchar* file, which converts the file name "kk/kk.png" to "kk%2Fkk.png" as %2F represents '/'.
I would appreciate some suggestions and hints on it.

[Blackbug (blackbug-nx)]

I have written a simple solution for this. Since, the filename with "/" results in coredump, which shouldnt be under any situation. I checked it for '/'. If filename contains '/' displayed a warning and changed the filename to default name ( which is also followed in case of any error ).
I wasnt very sure about how the application flow should be in this scenario, thus implemented this one.
Kindly let me know, in case of any better flow can be implemented.

Thanks.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch.txt" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Blackbug (blackbug-nx)]

Hi Reviewers,

Any updates on the patch and information requested.

Thanks!