Allow GTK theming for Ubuntu Budgie

Bug #1740150 reported by fossfreedom on 2017-12-26
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-screensaver (Ubuntu)
Wishlist
fossfreedom

Bug Description

Ubuntu Budgie uses gnome-screensaver for its lock-screen.

By default, gnome-screensaver does not provide a GTK+3 based style class - thus the lock screen is not themed by modern GTK+3 themes.

UB already has a patch (33_budgie_support.patch) that fixes a couple of issues.

I have updated this patch to allow GTK+3 theming via the style class "lock-dialog". This allows gnome-screensaver to the themed in the same way as the gnome-screensaver fork mate-screensaver which uses the same named style-class.

This has been tested using the GTK+3 theme adapta which has the MATE lock-screen style class "lock-dialog" .

I will be separately updating arc-theme (the theme used by Ubuntu Budgie) to provide theming for both mate-screensaver and gnome-screensaver (for Ubuntu Budgie).

Note - if its considered useful, I'm happy to rework this to move the style-class application to a separate patch to allow all desktops that use gnome-screensaver to be equally themed. However I've only tested this patch on Ubuntu Budgie and hence have restricted the style-class application to UB.

fossfreedom (fossfreedom) wrote :
tags: added: bionic patch
Changed in gnome-screensaver (Ubuntu):
assignee: nobody → fossfreedom (fossfreedom)
status: New → In Progress
Simon Quigley (tsimonq2) wrote :

I'm subscribing Jeremy Bicha for a review because he is the last uploader of this package.

Thanks, and sorry for the delay!

Tim Lunn (darkxst) wrote :

fossfreedom, your patch looks fine to me. It does seem more generally useful however not sure who is using gnome-screensaver anymore? probably just Unity as a fallback?

I was going to upload it to unblock you, but it has been dropped from the ubuntu-desktop package set with the move to gnome-shell, so alas I can't.

Changed in gnome-screensaver (Ubuntu):
importance: Undecided → Wishlist
Simon Quigley (tsimonq2) wrote :

Since Tim said the patch looks good, sponsoring.

Thanks!

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-screensaver - 3.6.1-8ubuntu3

---------------
gnome-screensaver (3.6.1-8ubuntu3) bionic; urgency=medium

  * Update 33_budgie_support.patch
    - Add lock-dialog stylecontext to allow theming (LP: #1740150)

 -- David Mohammed <email address hidden> Tue, 06 Mar 2018 23:55:34 -0600

Changed in gnome-screensaver (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers