Notification popup badly placed when no icon is shown.

[Mathieu Pillard]

Because of bug 32655 I had no icon displayed, but notification popup about the fact that I was now running on battery showed up (thanks to the patch in bug 32644). It was wrongly placed on the top left of my screen, with an arrow pointing to that direction; however, my panel and the notification area are in the bottom, so the notification area is badly placed, and so is its arrow.

This is still with latest dapper, using gnome-power-manager 2.13.91-0ubuntu2.

[Richard Hughes (richard-hughes)]

You got a screenshot please?

[Mathieu Pillard (diox)]

I didn't screenshot at that time, and I'm having trouble reproducing it. It might only happen with your patch from bug 326444, which I am not using right now, and was when I reported the bug.

[Richard Hughes (richard-hughes)]

This is the function for finding the center of the widget:

static gboolean
get_widget_position (GtkWidget *widget,
       int *x,
       int *y)
{
 g_assert (widget);

 gdk_window_get_origin (GDK_WINDOW (widget->window), x, y);

 *x += widget->allocation.x;
 *y += widget->allocation.y;
 *x += widget->allocation.width / 2;
 *y += widget->allocation.height;

 gpm_debug ("widget position x=%i, y=%i", *x, *y);

 return TRUE;
}

We probably need to add a test in there somehow, or maybe inprove the algorithm used.

[Mathieu Pillard (diox)]

I reproduced the problem while testing bug 32665. It seems the notification appears just before the icon and is wronly placed in consequence. I have a screenshot, no log yet though, I'll work on that.

[Mathieu Pillard (diox)]

This is a screenshot of the top left corner of my screen. The notification area is is at the bottom, towards the middle.

PS: if it's related to the icon being absent at the time of the notification, maybe you should just let the notification be "arrowless", like for instance gnome-volume-manager's disk full warnings. These appear at the bottom right of my screen, stacking.

[Richard Hughes (richard-hughes)]

>PS: if it's related to the icon being absent at the time of the notification,
>maybe you should just let the notification be "arrowless"

In CVS, I think this is what I've got:

if (tray->priv->is_visible) {
 get_widget_position (GTK_WIDGET (tray), &x, &y);
 notify_notification_set_hint_int32 (tray->priv->notify, "x", x);
 notify_notification_set_hint_int32 (tray->priv->notify, "y", y);
}

Richard.

[Mathieu Pillard (diox)]

Ah, looks good. I'll try to test out CVS as soon as I can.

[Matt Zimmerman (mdz)]

Any luck testing this further? Dapper should contain the relevant changes now.

[Mathieu Pillard (diox)]

Yes, it seems to be working fine now: when there is no icon the notification is simply put in the corner of the screen, without the arrow.

[Dennis Kaarsemaker (dennis)]

Thanks for following up!

 status FixReleased