Ubuntu

clean target doesn't work properly due to patch

Reported by jose on 2006-11-20
4
Affects Status Importance Assigned to Milestone
gnome-panel (Ubuntu)
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: gnome-panel

gnome-panel-2.16.1

when i compile for the first time the packge, it is ok. But, when i do the second compilation (in the debclean section) the 12_autoconf.patch crashed and any depends problems, and i have all depends install. The sources are the originals in the repositories and there isn't any changes in the code.

thanks.

Related branches

Sebastien Bacher (seb128) wrote :

Thank you for your bug

Changed in gnome-panel:
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: Unconfirmed → Confirmed
Yann Rouillard (yann-pleiades) wrote :

I manually launch the reverse patch command which failed during the debclean section:

$ cat debian/patches/12_autoreconf.patch | patch -d . -R -E --dry-run -p1
patching file aclocal.m4
patching file applets/clock/e-map/Makefile.in
patching file applets/clock/Makefile.in
patching file applets/fish/Makefile.in
patching file applets/Makefile.in
patching file applets/notification_area/Makefile.in
patching file applets/wncklet/Makefile.in
patching file config.h.in
The next patch, when reversed, would delete the file config.h.in~,
which does not exist! Ignore -R? [n] n

Just removes the config.h.in~ part from the patch, and it will be properly reversed during the clean target.
...
But the bug then happens again with the 11_panel_addto_dialog.patch and the gnome-panel/panel-addto.c.orig file.

I will clean the patches and provide a patch soon.

Yann Rouillard (yann-pleiades) wrote :

Here is a patch to apply in order to clean the patches from all ~ or .orig files which prevents to build twice in a row.

Sebastien Bacher (seb128) wrote :

Thank you for your work on the bug

Sebastien Bacher (seb128) wrote :

gnome-panel (1:2.20.0.1-0ubuntu3) gutsy; urgency=low

  * debian/patches/01_layout.patch, debian/patches/11_panel_addto_dialog.patch:
    - cleaning
  * debian/patches/12_autoreconf.patch:
    - don't list config.h.in~ in the package, fix build after clean target,
      change suggest by "Yann" (LP: #72570)
  * debian/patches/15_no_animation_if_composited.patch:
    - updated to modify the source and not the patches directory

 -- Sebastien Bacher <email address hidden> Tue, 25 Sep 2007 15:15:56 +0200

Changed in gnome-panel:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers