remote finger no longer work, local finger limited (pinky vs finger)

Bug #766862 reported by Shang Wu
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Nettool
Unknown
Unknown
OEM Priority Project
Fix Released
Medium
Chris Van Hoof
Oneiric
Fix Released
Medium
Ayan George
gnome-nettool (Ubuntu)
Fix Released
Medium
Ayan George

Bug Description

SRU Justificaiton
-----------------

Impact:

This update allows remote finger to work if a proper finger client is installed.

Fix:

A minor code change that has gnome-nettool attempt to use the 'finger' before falling back to 'pinky' instead of vice-versa.

Patch:

The changes have been applied to gnome-nettool git master branch in commit 89e0bb648e9e8bd96a5eb5e0284abf74fc244c95. I've attached a debdiff in comment #5.

Regression Potential:

There should be very little potential for regression.

Test Case:

* Install finger (sudo apt-get install finger)
* Run gnome-nettool
* Select the 'finger' tab.
* Enter the hostname of a machine running a finger server and the username of a properly configured account.

gnome-nettool should display the finger information returned by the remote host.

------------------------

Binary package hint: gnome-nettool

This is a duplicated entry for the gnome upstream bug#611408

Simon Paillard [reporter] 2010-02-28 15:20:55 UTC

Hello,

This has been reported intially in http://bugs.debian.org/550991

Remote finger no longer works.
It seems the switch from finger to pinky caused a regression in finger feature.

> gnome-nettool's finger functionality does not work. If I try to finger
> <email address hidden> or <email address hidden> (or anyone else, for
> that matter), it sends no packets, and produces only the output:
>
> Login Name TTY Idle When Where

This seems to be a regression since 2.22.1-1, after the switch to pinky
as finger program, introduced after the resolution of:
https://bugzilla.gnome.org/show_bug.cgi?id=549588
commit a9eaa17cdae8563e19e1afc2aebe64e534a4da85
2008-12-04 02:56 German Poo-Caamano Fixed #549588. Try to use pinky
instead of finger. Use finger as fallback.

$ pinky <email address hidden>
Login Name TTY Idle When Where

It doesn't seem pinky is able to do the same job as finger does.

Changed in gnome-nettool:
importance: Unknown → Medium
status: Unknown → New
Shang Wu (shangwu)
Changed in oem-priority:
importance: Undecided → Medium
Changed in oem-priority:
assignee: nobody → Canonical Platform QA Team (canonical-platform-qa)
Revision history for this message
john morimore (paradigmshifter1) wrote :

what does "remote finger" and "pinky" refer to?

Chris Van Hoof (vanhoof)
Changed in oem-priority:
assignee: Canonical Platform QA Team (canonical-platform-qa) → Chris Van Hoof (vanhoof)
status: New → Confirmed
Changed in gnome-nettool (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Ayan George (ayan)
Revision history for this message
Ayan George (ayan) wrote :

pinky does not use finger's network prototcol -- it only looks on the local machine.

gnome-nettool/src/finger.c seems to even prefer pinky:

  program = util_find_program_in_path ("pinky", NULL);

  if (program != NULL) {
    program_name = g_strdup ("pinky");
  } else {
    program = util_find_program_dialog ("finger", parent);
    program_name = g_strdup ("finger");
  }

So if both pink and finger exist, it'll still use pinky. Perhaps the logic should be:

  program = util_find_program_in_path ("finger", NULL);

  if (program != NULL) {
    program_name = g_strdup ("finger");
  } else {
    program = util_find_program_dialog ("pinky", parent);
    program_name = g_strdup ("pinky");
  }

Revision history for this message
Ayan George (ayan) wrote :

Created upstream bug and submitted patch:

https://bugzilla.gnome.org/show_bug.cgi?id=653637

Changed in gnome-nettool (Ubuntu):
status: New → In Progress
Revision history for this message
Ayan George (ayan) wrote :

Patch was reviewed and committed upstream.

Changed in gnome-nettool (Ubuntu):
status: In Progress → Fix Committed
Changed in gnome-nettool:
status: New → Invalid
Changed in gnome-nettool:
importance: Medium → Unknown
status: Invalid → Unknown
Chris Van Hoof (vanhoof)
Changed in oem-priority:
status: Confirmed → Fix Committed
Chris Van Hoof (vanhoof)
Changed in oem-priority:
status: Fix Committed → Confirmed
Ayan George (ayan)
Changed in gnome-nettool (Ubuntu):
milestone: none → oneiric-updates
Revision history for this message
Ayan George (ayan) wrote :
description: updated
Ayan George (ayan)
Changed in gnome-nettool (Ubuntu):
status: Fix Committed → Fix Released
Changed in oem-priority:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.