gnome-keyring reads unsafe SSH keys

[Kees Cook]

Binary package hint: gnome-keyring

OpenSSH enforces that one's keys must be mode 0700 so that unsafe permissions do not go unnoticed. gnome-keyring should perform this check as well. It looks like pkcs11/ssh-store/gkm-ssh-private-key.c gkm_ssh_private_key_parse() is the place to do it, or possibly pkcs11/ssh-store/gkm-ssh-module.c file_load() since it checks some aspects of the files already.

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: gnome-keyring 2.92.92.is.2.32.1-0ubuntu2
ProcVersionSignature: Ubuntu 2.6.37-12.26-generic 2.6.37
Uname: Linux 2.6.37-12-generic x86_64
Architecture: amd64
Date: Mon Feb 7 15:23:20 2011
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, user)
 LANG=en_US.UTF-8
 LC_MESSAGES=en_US.utf8
 SHELL=/bin/bash
SourcePackage: gnome-keyring

[Martin Pitt (pitti)]

Robert, do you have some time to look into this? If not, please bounce back to canonical-desktop-team, and I'll find someone else.

Thanks!

[Robert Ancell (robert-ancell)]

Forwarded upstream with a suggested solution:
https://bugzilla.gnome.org/show_bug.cgi?id=642008

[Robert Ancell (robert-ancell)]

This is unlikely to be complete for Natty due the the multiple layers and UI that have to be modified, reassigning for Oneiric

[Kees Cook (kees)]

I don't think UI work is needed for Natty -- just failing when the permissions are bad is sufficient.

[Robert Ancell (robert-ancell)]

This would be really bad behaviour without UI - keys that were rejected due to permissions would stop working with no indication to the user at all. Upstream is in agreement about this.

[dino99 (9d9)]

https://wiki.ubuntu.com/Releases

[dino99 (9d9)]

expired version, and openssl has been widely reworked lately.

[api.ng (hektve)]

Build info: cv1_lao_com-user 7.1.2 N2G47H 173411504b0cf release-keysSerial number: LMX210G29468a76

Sent from my MetroPCS 4G LTE Android device