Fix Ctrl+Shift and other modifier keys as input-sources switch shortcut

Bug #1797352 reported by Valentyna on 2018-10-11
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-flashback (Ubuntu)
Undecided
Unassigned

Bug Description

On Ubuntu 18.04 (bionic) I am not able to use Ctrl+Shift, Control+Alt and other combinations which include only modifier keys to switch input source (works in gnome shell).

I solved this problem by making patch for gnome-flashback.
The problem with function gtk_accelerator_valid(keyval, modifiers), which always return False for such combinations. So I`ve just removed this validation.

Patch also include fix for modifier release event.

This combinations can set using gsettings(or dconf-editor) for example:
gsettings set org.gnome.desktop.wm.keybindings switch-input-source "['<Control>Shift_R']" (does not work in gnome-control-center).

My OS is:
Description: Ubuntu 18.04.1 LTS
Release: 18.04

Package: gnome-flashback
Version: 3.28.0-1ubuntu1.2
Priority: optional
Section: gnome
Maintainer: Ubuntu Developers <email address hidden>
Original-Maintainer: Debian GNOME Maintainers <email address hidden>
Installed-Size: 921 kB
Provides: notification-daemon, polkit-1-auth-agent
Depends: gnome-flashback-common (= 3.28.0-1ubuntu1.2+switch+is~86), libatk1.0-0 (>= 1.12.4), libc6 (>= 2.4), libcairo2 (>= 1.10.0), libcanberra-gtk3-0 (>= 0.25), libgdk-pixbuf2.0-0 (>= 2.22.0), libglib2.0-0 (>= 2.55.2), libgnome-bluetooth13 (>= 3.12.0), libgnome-desktop-3-17 (>= 3.17.92), libgtk-3-0 (>= 3.22.0), libibus-1.0-5 (>= 1.5.2), libpango-1.0-0 (>= 1.14.0), libpangocairo-1.0-0 (>= 1.14.0), libpolkit-agent-1-0 (>= 0.99), libpolkit-gobject-1-0 (>= 0.99), libpulse-mainloop-glib0 (>= 0.99.1), libpulse0 (>= 0.99.1), libupower-glib3 (>= 0.99.0), libx11-6 (>= 2:1.2.99.901), libx11-xcb1, libxcb-randr0 (>= 1.1), libxext6, libxfixes3, libxi6 (>= 2:1.2.99.4), libxkbfile1, libxrandr2 (>= 2:1.5.0)
Recommends: dbus, gnome-settings-daemon (>= 3.26)
Suggests: gnome-power-manager
Homepage: https://wiki.gnome.org/Projects/GnomeFlashback
Download-Size: 261 kB
APT-Manual-Installed: yes
Description: helper application for the GNOME Flashback session
 This package provides a helper application for the GNOME Flashback
 desktop session. This application:
  - provides the Logout, Reboot and Shutdown dialogs;
  - provides the Sound, Bluetooth and Power tray applets;
  - implements screenshot and screencast functionality;
  - implements input source switching functionality;
  - draws desktop background;
  - implements other functionality which was previously handled by
    gnome-settings-daemon.

Valentyna (valia0906) wrote :
Valentyna (valia0906) on 2018-10-11
description: updated
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gnome-flashback (Ubuntu):
status: New → Confirmed
Valentyna (valia0906) on 2018-10-11
summary: - Fix Ctrl+Shift modifiers as input-sources switch shortcut
+ Fix Ctrl+Shift and other modifier keys as input-sources switch shortcut
description: updated

You should report problem upstream, or is this Ubuntu specific bug?

https://gitlab.gnome.org/GNOME/gnome-flashback/issues

The attachment "add-support-modifiers-only.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers