gnome-network-properties: put the cursor at the end of the proxy entry while typing

Bug #542001 reported by Jean-Baptiste Lallement on 2010-03-19
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gnome-control-center
Expired
Low
gnome-control-center (Ubuntu)
Low
Unassigned

Bug Description

Binary package hint: gnome-control-center

When entering the proxy address in the proxy tab, the hostname is automatically extracted and replace the current entry. But the cursor is then placed at the beginning of the entry, before the last character resulting in typo. It should be put after the last character.

exemple:
Go to HTTP Proxy and enter (without interruption):
http://localhost
the result is
ocalhostl

ProblemType: Bug
Architecture: i386
Date: Fri Mar 19 17:20:22 2010
DistroRelease: Ubuntu 10.04
EcryptfsInUse: Yes
Package: gnome-control-center 1:2.29.92-0ubuntu1
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-16.25-generic
SourcePackage: gnome-control-center
Uname: Linux 2.6.32-16-generic i686

Jean-Baptiste Lallement (jibel) wrote :
Victor Vargas (kamus) wrote :

It's strange but absolutely reproducible under fully upgraded Lucid.

Changed in gnome-control-center (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Jean-Baptiste Lallement (jibel) wrote :

BTW it doesn't respect HIG 2.2 according to http://library.gnome.org/devel/hig-book/stable/windows-utility.html.en#windows-instant-apply
"Do not make the user press an OK or Apply button to make the changes happen, unless either:
[...]
    * the changes in the window have to be applied simultaneously to prevent the system entering a potentially unstable state. For example, the hostname and proxy fields in a network properties window.
"

A compromised could be to rewrite the content of the entry when the field loses focus.

Jean-Baptiste Lallement (jibel) wrote :

A prototype of a solution to mitigate this usability issue.
It disables the gconf value update on entry change and add a focus-out event to do the update. It's a bit less surprising for the user.

tags: added: patch
Chris Coulson (chrisccoulson) wrote :

Thank you for the patch. I've not had a look in great detail yet, but I do have 1 comment so far:

+{
+ GConfClient *client;
+ client = gconf_client_get_default ();
+
+ char const *entered_text = gtk_entry_get_text(entry);

It seems that you're leaking the GConfClient here

Jean-Baptiste Lallement (jibel) wrote :

updated patch according to previous comment.

Changed in gnome-control-center (Ubuntu):
assignee: nobody → Jean-Baptiste Lallement (jibel)
Changed in gnome-control-center:
status: Unknown → In Progress
Changed in gnome-control-center:
importance: Unknown → Low
Changed in gnome-control-center:
status: In Progress → Expired
Sebastien Bacher (seb128) wrote :

This dialog got rewritten in GNOME3, closing

Changed in gnome-control-center (Ubuntu):
assignee: Jean-Baptiste Lallement (jibel) → nobody
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.