HIG problem with my previous fix

Bug #327465 reported by Bruce Cowan
2
Affects Status Importance Assigned to Milestone
gnome-control-center (Ubuntu)
Fix Released
Low
Michael Vogt

Bug Description

Binary package hint: gnome-control-center

My patch on bug #159996 desensitises the "Desktop Effects" tab if compiz isn't installed. According to GNOME HIG 6.3.1 (http://library.gnome.org/devel/hig-book/stable/controls-sensitivity.html.en), there should be an indication as to why something is insensitive. I will follow up with a patch that does this later.

Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

Debdiff for this. I haven't tested it, because I couldn't create a Jaunty pbuilder, but I will once it works.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your work, you should subscribe the sponsor team when you have changes that need a review, mvo what do you think about that one?

Changed in gnome-control-center:
assignee: nobody → mvo
importance: Undecided → Low
Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

Here is a debdiff which actually does something. However, the warning icon might be a bit large (I've set it to 48x48 like the effects icons. If this is too large, set the icon-size property of the icon to '4' in the glade file.

Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

Here's a screenshot of the large-icon version.

Revision history for this message
Michael Vogt (mvo) wrote :

The debdiff does not apply cleanly anymore, could you please give me the diff to the C file (or a updated debdiff)? The glade bits still apply fine.

Thanks,
 Michael

Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :

Hm, how did you generate the diff? When I try to apply it I get:
$ patch -p1 < /tmp/fix.debdiff
patching file debian/changelog
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file debian/changelog.rej
patching file debian/patches/95_desktop-effects-integration.patch
patch: **** malformed patch at line 116: @@ -1204,6 +1229,43 @@

Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

Here's another debdiff. Please apply it ASAP to not mess it up.

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the updated diff.

I applied it with a small modification:
-+ if (g_find_program_in_path ("compiz") != NULL) {
++ if (g_find_program_in_path ("compiz") == NULL) {

Could you please mail the translators list and tell them about the added string [1] ?

Thanks again,
 Michael

[1] see https://wiki.ubuntu.com/FreezeExceptionProcess#UserInterfaceFreeze Exceptions

Changed in gnome-control-center:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:2.25.92-0ubuntu4

---------------
gnome-control-center (1:2.25.92-0ubuntu4) jaunty; urgency=low

  * debian/patches/95_desktop-effects-integration.patch:
    - show warning at the top of the effects tab when compiz isn't
      installed (lp: #327465)

 -- Bruce Cowan <email address hidden> Tue, 10 Mar 2009 23:14:19 +0000

Changed in gnome-control-center:
status: Fix Committed → Fix Released
Revision history for this message
Bruce Cowan (bruce89-deactivatedaccount) wrote :

Thanks, but I'm now getting a huge number of e-mails about invalid translation uploads. Is there anything I can do to stop this?

Revision history for this message
Sebastien Bacher (seb128) wrote :

that's a rosetta bugs, you will just get a batch for all the translations imported from this upload once and that's all

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.