Rename "Pin to Dash" to "Pin to Dock"

Bug #1973474 reported by Gunnar Hjalmarsson
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-control-center (Ubuntu)
Invalid
Undecided
Unassigned
gnome-shell (Ubuntu)
New
Medium
Unassigned
gnome-shell-extension-ubuntu-dock (Ubuntu)
New
Medium
Unassigned
ubuntu-docs (Ubuntu)
New
Undecided
Unassigned

Bug Description

I noticed this commit:

https://github.com/micheleg/dash-to-dock/commit/8ee55c29

If I understand it correctly, it means that we will use the label "Pin to Dash" instead of "Add to Favorites" as from Ubuntu 22.10. To be consistent I suggest that we rename the thing in all contexts, and hence replace "Dock" with "Dash" in all affected strings in the Appearance section in g-c-c.

description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Gunnar. The reason the string was picked is to be able to reuse the translations from gnome-shell, which made sense at this point of the cycle, but is it really the best string to use for Ubuntu? Upstream doesn't have a dock but we do, perhaps we should use 'pin to dock' for our shell? Probably a question to ask to design

Changed in gnome-control-center (Ubuntu):
importance: Medium → Low
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Hmm.. Using "Pin to Dock" (via a gnome-shell patch I suppose) may be better. Doing so probably lets us keep the established "Dock" and still be consistent.

Changing this bug accordingly.

Changed in gnome-control-center (Ubuntu):
importance: Low → Undecided
status: New → Invalid
summary: - Rename "Dock" to "Dash" in Appearance
+ Rename "Pin to Dash" to "Pin to Dock"
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

The reason why I bring up this early is that we are about to document Ubuntu differences in the desktop guide. So for both docs and translation reasons: Let's do this soon, and avoid some last minute UIF break.

Changed in gnome-shell (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

If we go this route, we'll need yet another conditional in dash-to-dock. Adding gnome-shell-extension-ubuntu-dock as affected package.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I'm not sure I agree with this, but do appreciate the wording is confusing in a world of dash and dock.

* Regular users are less likely to understand "pinned" as much as "favourites".
* Power users may have no dock, only a dash, and so the existing wording is correct.
* It's a patch we would have to maintain.

Changed in gnome-shell (Ubuntu):
importance: Medium → Wishlist
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Daniel:

If you don't agree, what would you prefer? I have already mentioned two suggestions to address the inconsistency.

On 2022-05-17 05:03, Daniel van Vugt wrote:
> * Regular users are less likely to understand "pinned" as much as
> "favourites".

This is not about "Pinned" vs. "Favorites". It's about "Pin/Pinned" vs. "Add/Added" and "Dash" vs. "Dock".

My (latest) idea is to accept "Pin to Dock" as a minimum change given the current code. Another possible solution would be to keep the 22.04 solution, i.e. use the original Ubuntu terms all over also going forward.

> * Power users may have no dock, only a dash, and so the existing
> wording is correct.

Yes, for those who choose a GNOME session. My concern is the Ubuntu sessions.

* It's a patch we would have to maintain.

Something should be done. Getting rid of the the inconsistent terminology, in one way or another, is not a wishlist request. The inconsistency is a bug, which gets extra obvious when you deal with docs and translations.

Changed in gnome-shell (Ubuntu):
importance: Wishlist → Medium
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Ironically I'm dealing with ubuntu-dock code right now that mentions "dock.dash" as in the dash is a member of the Ubuntu dock. But that's an implementation detail...

Given how freely extensions might change things I would lean toward never mentioning "dash" or "dock" in menu items. Like "Move to favourites" since doing so removes the icon from the app grid.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

On 2022-05-17 11:35, Daniel van Vugt wrote:
> Given how freely extensions might change things I would lean toward
> never mentioning "dash" or "dock" in menu items. Like "Move to
> favourites" since doing so removes the icon from the app grid.

Sounds reasonable to me.

But please note that some other strings but the menu items are affected.

https://salsa.debian.org/gnome-team/gnome-shell/-/commit/fe0b3296

https://salsa.debian.org/gnome-team/gnome-shell/-/commit/f766fcaf

And an unfinished discussion on the topic can be found here:

https://salsa.debian.org/gnome-team/gnome-shell/-/merge_requests/61

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers