[SRU] can't adjust output volume through volume-slider after changing output-device

[Hui Wang]

[Impact]
On the machine with the legacy HDA audio driver, suppose the current output device is Speaker, users plug a HDMI monitor and select the HDMI audio as the current output device in the g-c-c, after that the output volume can't be adjusted through the volume-slider in the g-c-c. The UI of the volume-slider could be changed, but the output volume doesn't change.

[Fix]
Backport 1 upstream commit 0f18a662be6ee0d225249d1ad003dfef69294449. The root cause of this issue is the stream is not got when changing the output-device, the patch adds the getting stream in the update_sink callback, this could fix this bug.

[Test]
run the patches g-c-c, plug a hdmi monitor, select the HDMI audio from g-c-c, then change the output volume via volume-slider, play music, the sound could be changed with the adjustment with the volume-slider.

[Where problems will occur]
This patch brings the change to the output and input volume adjustment in the cc-sound-panel, this could make the output/input volume changing not work anymore, for example, the internal speaker or internal mic work well, after plugging a headset, the output device changes to headphone, the intput device changes to Mic, then the volume adjustment doesn't work on headphone and Mic anymore. But this possibility is very low since I tested the patch on different Lenovo and Dell machines, no regression found so far.

[Hui Wang (hui.wang)]

This is the debdiff for impish.

thx.

[Hui Wang (hui.wang)]

This is the debdiff for hirsute.

thx.

[Hui Wang (hui.wang)]

This is the debdiff for focal.

thx.

[Gunnar Hjalmarsson (gunnarhj)]

Sponsored impish to start with, since I had another thing pending in the VCS.

@Hui Wang: When proposing changes to packages which have a VCS, it's generally preferable to submit merge requests.

https://salsa.debian.org/gnome-team/gnome-control-center/-/tree/ubuntu/master

[Gunnar Hjalmarsson (gunnarhj)]

I have sponsored also hirsute and focal now, and they are waiting in respective queue for review by the SRU team.

@Hui Wang: Good if you unsubscribe ubuntu-sponsors.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:40.0-1ubuntu3

---------------
gnome-control-center (1:40.0-1ubuntu3) impish; urgency=medium

  [ Gunnar Hjalmarsson ]
  * Adapts-the-region-capplet-and-the-language-chooser-in-the.patch:
    - Revert the "Fix locales updates" commit
    - Drop update_region() call with NULL argument
  * d/p/u/Fix-volume-adjustment-failure-on-volume-slider.patch:
    - Added patch headers

  [ Hui Wang ]
  * d/p/u/Fix-volume-adjustment-failure-on-volume-slider.patch:
    - Can't adjust the output volume via volume-slider after changing
      the current output-device. (LP: #1938747)

 -- Gunnar Hjalmarsson <email address hidden> Tue, 03 Aug 2021 12:46:03 +0200

[Hui Wang (hui.wang)]

Thanks Gunnar, unsubscribe ubuntu-sponsors now.

[Robie Basak (racb)]

The Focal upload is missing the fix for bug 1795483 which there's a task for. The Hirsute upload includes fixes for both. Accepting the Hirsute upload. Before I accept the Focal upload, can I think if this intentional? I can accept the current upload if you want, but then the fix for bug 1795483 will get blocked until that SRU is done.

[Robie Basak (racb)]

Hello Hui, or anyone else affected,

Accepted gnome-control-center into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.38.5-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

> can I think if this intentional?

...can I *check* if this is intentional?

[Gunnar Hjalmarsson (gunnarhj)]

On 2021-08-04 15:11, Robie Basak wrote:
> The Focal upload is missing the fix for bug 1795483 which there's a
> task for. The Hirsute upload includes fixes for both. Accepting the
> Hirsute upload. Before I accept the Focal upload, can I think if
> this intentional? I can accept the current upload if you want, but
> then the fix for bug 1795483 will get blocked until that SRU is
> done.

I have asked Marco about this:

https://irclogs.ubuntu.com/2021/08/04/%23ubuntu-desktop.html#t11:24

(no reply yet)

The fix for hirsute was pushed to the repo on May 28. Since it hadn't been uploaded, I assumed that bug #1795483 is not so urgent. So my thinking when uploading was that the absence of a focal fix of bug #1795483 shouldn't delay the fix of this bug.

[Daniel van Vugt (vanvugt)]

> > can I think if this intentional?
>
> ...can I *check* if this is intentional?

Launchpad comments have an edit button now ;)

[Hui Wang (hui.wang)]

Verification for hirsute:

adding below 2 lines in the /etc/apt/sources.list:
deb http://cn.archive.ubuntu.com/ubuntu/ hirsute-proposed main restricted multiverse universe
deb-src http://cn.archive.ubuntu.com/ubuntu/ hirsute-proposed main restricted multiverse universe

sudo apt-get update
sudo apt install gnome-control-center

After version 1:3.38.5-1ubuntu2 is installed, reboot the machine, open the gnome-control-center sound, the speaker is the active output device, change the volume, the output volume could be changed with UI change, plug a HDMI monitor, select HDMI audio from UI, adjust the volume from volume-slider, the output volume could be changed with the volume-slider change.

Verification done on hirsute.

thx.

[Robie Basak (racb)]

Hello Hui, or anyone else affected,

Accepted gnome-control-center into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.36.5-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Hui Wang (hui.wang)]

Verification for focal:

adding below 2 lines in the /etc/apt/sources.list:
deb http://cn.archive.ubuntu.com/ubuntu/ focal-proposed main restricted multiverse universe
deb-src http://cn.archive.ubuntu.com/ubuntu/ focal-proposed main restricted multiverse universe

sudo apt-get update
sudo apt install gnome-control-center

After version 1:3.36.5-0ubuntu3 is installed, reboot the machine, open the gnome-control-center sound, the speaker is the active output device, change the volume, the output volume could be changed with UI change, plug a HDMI monitor, select HDMI audio from UI, adjust the volume from volume-slider, the output volume could be changed with the volume-slider change.

Verification done on focal.

thx.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.38.5-1ubuntu2

---------------
gnome-control-center (1:3.38.5-1ubuntu2) hirsute; urgency=medium

  [ Marco Trevisan (Treviño) ]
  * debian/control, debian/gbp.conf:
    Update references to ubuntu/hirsute branch
  * 0033-display-Ensure-we-list-available-scaling-values-keeping-t.patch:
    Ensure we list all the usable scaling values (LP: #1795483)

  [ Hui Wang ]
  * d/p/git-Fix-volume-adjustment-failure-on-volume-slider.patch:
    Can't adjust the output volume via volume-slider after changing
    the current output-device. (LP: #1938747)

 -- Gunnar Hjalmarsson <email address hidden> Tue, 03 Aug 2021 15:23:41 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-control-center - 1:3.36.5-0ubuntu3

---------------
gnome-control-center (1:3.36.5-0ubuntu3) focal; urgency=medium

  * d/p/git-Fix-volume-adjustment-failure-on-volume-slider.patch
    Can't adjust the output volume via volume-slider after changing
    the current output-device. (LP: #1938747)

 -- Hui Wang <email address hidden> Tue, 03 Aug 2021 16:53:47 +0800