[SRU] g-c-c: The hdmi/dp profiles are not set automatically in the combo list after selecting the hdmi/dp audio in the g-c-c

Bug #1896919 reported by Hui Wang on 2020-09-24
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Undecided
Unassigned
OEM Priority Project
High
Yuan-Chen Cheng
gnome-control-center (Ubuntu)
Critical
Hui Wang
Focal
Critical
Hui Wang
Groovy
Critical
Hui Wang

Bug Description

[Impact]
After we plugging a hdmi/dp monitor with audio capability, we could
select hdmi audio as output device in the g-c-c, but after we do
that, the profile combo list will show up in the g-c-c and this combo
list is empty, it should be stereo-hdmi by default according to 18.04

[Fix]
Backport a fix from g-c-c upstream, after applying this patch, the
combo list update signals will be recevied after the pa finishes the
changing active profile.

[Test Case]
Plug the hdmi/dp monitor with audio capability, then choose hdmi audio
as active output device from g-c-c, we will find the profile combo list
has hdmi-steoreo as the default profile. This is same as 18.04.

[Regression Risk]
It is possible to make the output and input device can't work after
applying this patch, that is because the active profile is not set as
our expected. But this possibility is very low, I tested this patch on
2 lenovo and 2 dell laptops, there is no regression.

Hui Wang (hui.wang) on 2020-09-24
Changed in pulseaudio (Ubuntu):
importance: Undecided → Critical
no longer affects: pulseaudio (Ubuntu)
Changed in gnome-control-center (Ubuntu):
importance: Undecided → Critical
assignee: nobody → Hui Wang (hui.wang)
summary: - [SRU] The hdmi/dp profiles are not set automatically in the combolist
+ [SRU] g-c-c: The hdmi/dp profiles are not set automatically in the combo
+ list after plugging a hdmi/dp monitor
Hui Wang (hui.wang) on 2020-09-24
summary: [SRU] g-c-c: The hdmi/dp profiles are not set automatically in the combo
- list after plugging a hdmi/dp monitor
+ list after selecting the hdmi/dp audio in the g-c-c
Hui Wang (hui.wang) wrote :

This is the debdiff for focal.

thx.

tags: added: oem-priority originate-from-1892168 somerville
description: updated
Changed in gnome-control-center (Ubuntu Focal):
importance: Undecided → Critical
assignee: nobody → Hui Wang (hui.wang)
Hui Wang (hui.wang) wrote :

This is the debdiff for groovy.

thx.

Sebastien Bacher (seb128) wrote :

@Hui, thanks, could you request upstream to cherry pick the fix to gnome-3-38, it would make the next SRU easier

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.38.0-1ubuntu2

---------------
gnome-control-center (1:3.38.0-1ubuntu2) groovy; urgency=medium

  * d/p/0033-sound-update-the-profile-list-after-getting-the-sign.patch
    - signal to update profile combo list after the PA changes the
      active profile, this patch fixes the empty profile combo list issue
      after selecting the hdmi/dp audio in the g-c-c. (LP: #1896919)

 -- Hui Wang <email address hidden> Thu, 24 Sep 2020 09:54:10 +0000

Changed in gnome-control-center (Ubuntu Groovy):
status: New → Fix Released
Hui Wang (hui.wang) wrote :

@seb,

Done, just added a comment in the MR to request to cherry-pick the patch to gnome-3-38.

Changed in oem-priority:
importance: Undecided → High
status: New → Confirmed
assignee: nobody → Yuan-Chen Cheng (ycheng-twn)
Sebastien Bacher (seb128) wrote :

Thanks, the SRU has been uploaded to focal queue

Changed in gnome-control-center (Ubuntu Focal):
status: New → Fix Committed

Hello Hui, or anyone else affected,

Accepted gnome-control-center into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-control-center/1:3.36.4-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
Hui Wang (hui.wang) wrote :

Tested on one Lenovo and one Dell machines, they all use legacy HDA audio driver. Upgraded the g-c-c to 0buntu2, plug a hdmi/dp monitor, we could see the hdmi-stereo from the configuration combo list and audio worked well. Without this SRU, users will see the empty configuration combo list and need users manually select profile.

Verified done on focal.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Yuan-Chen Cheng (ycheng-twn) wrote :

I install a dell machine (still not disclosed), upgrade everything from updates channel, and install from focal-proposed

Get:1 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 gnome-control-center-data all 1:3.36.4-0ubuntu2 [327 kB]
Get:2 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 gnome-control-center amd64 1:3.36.4-0ubuntu2 [1,718 kB]
Get:3 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 gnome-control-center-faces all 1:3.36.4-0ubuntu2 [1,216 kB]

After that, I reboot the machine, plug hdmi, make sure hdmi output is selected in g-c-c.

I still can see three items in the profile combo list.

tags: added: verification-failed verification-failed-focal
removed: verification-done verification-done-focal
Sebastien Bacher (seb128) wrote :

@Hui, could you check that verification failed comment, is that the same issue than is addressed here or a different one, the 'three items' description sounds a bit different

Hui Wang (hui.wang) wrote :

@YC,

This SRU is not to fix the 3 profiles in the combo list, it is to fix the issue of "no active profile in the combo list" after plugging the hdmi/dp monitor.

Without this SRU, after users plug a hdmi/dp monitor, the profile combo list is empty, need users manually to select profile from 3 ones.

After the SRU, an active profile will be shown automatically in the combo list after users plug a hdmi/dp monitor, no need users to manually select the profile, but there are still 3 profile options in the combo list. This is same as the 18.04.

Yuan-Chen Cheng (ycheng-twn) wrote :

Given the details in #11, yes with the new g-c-c, I can see the first profile auto-selected.
Without updated g-c-c, it's not auto-selected.

tags: added: verification-done verification-done-focal
removed: verification-failed verification-failed-focal
Changed in oem-priority:
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-control-center - 1:3.36.4-0ubuntu2

---------------
gnome-control-center (1:3.36.4-0ubuntu2) focal; urgency=medium

  * debian/patches/git_useraccount_segfault.patch:
    - don't segfault trying to get the user initials when accountsservice
      is not responding (lp: #1873378)
  * debian/patches/git_row_collide.patch:
    - backport a fix for items of the connection details colliding
      (lp: #1873184)

  [ Hui Wang ]
  * d/p/0033-sound-update-the-profile-list-after-getting-the-sign.patch
    - signal to update profile combo list after the PA changes the
      active profile, this patch fixes the empty profile combo list issue
      after selecting the hdmi/dp audio in the g-c-c. (LP: #1896919)

  [ Marco Trevisan (Treviño) ]
  * d/p/0008-Allow-tweaking-some-settings-for-Ubuntu-Dock.patch:
    - Don't try to fetch monitors if the config manager is not ready yet
    (lp: #1887731)
  * d/p/0019-display-Support-UI-scaled-logical-monitor-mode.patch,
    d/p/0024-display-Allow-fractional-scaling-to-be-enabled.patch:
    - Don't disable fractional scaling immediately on integer changes
    (lp: #1887707)

 -- Sebastien Bacher <email address hidden> Thu, 24 Sep 2020 17:03:01 +0200

Changed in gnome-control-center (Ubuntu Focal):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-control-center has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers