gnome-control-center segfaults when unit bolt.service is masked

[Simon Déziel]

I don't have any Thunderbolt devices so I masked the unused the bolt.service. This causes problem with gnome-control-center.

Steps to reproduce:

1) launch gnome-control-center
$ gnome-control-center

2) navigate to Thunderbolt section
go to Devices, then Thunderbolt and close gnome-control-center

3) mask bold.service
$ sudo systemctl stop bolt.service
$ sudo systemctl mask bolt.service

4) re-launch gnome-control-center
$ gnome-control-center

(gnome-control-center:21859): thunderbolt-cc-panel-WARNING **: 14:04:53.423: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.
Segmentation fault (core dumped)

Expected result: no segfault.

Additional information:

$ lsb_release -rd
Description: Ubuntu 18.04.1 LTS
Release: 18.04

$ apt-cache policy gnome-control-center bolt
gnome-control-center:
  Installed: 1:3.28.2-0ubuntu0.18.04.2
  Candidate: 1:3.28.2-0ubuntu0.18.04.2
  Version table:
 *** 1:3.28.2-0ubuntu0.18.04.2 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     1:3.28.1-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
bolt:
  Installed: 0.5-0ubuntu0.18.04.1
  Candidate: 0.5-0ubuntu0.18.04.1
  Version table:
 *** 0.5-0ubuntu0.18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     0.2-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: gnome-control-center 1:3.28.2-0ubuntu0.18.04.2
ProcVersionSignature: Ubuntu 4.15.0-43.46-generic 4.15.18
Uname: Linux 4.15.0-43-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.9-0ubuntu7.5
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Fri Dec 14 14:05:26 2018
InstallationDate: Installed on 2018-07-15 (152 days ago)
InstallationMedia: Ubuntu 18.04 LTS "Bionic Beaver" - Release amd64 (20180714)
ProcEnviron:
 LANG=en_CA.UTF-8
 TERM=xterm-256color
 SHELL=/bin/bash
 XDG_RUNTIME_DIR=<set>
 PATH=(custom, no user)
SourcePackage: gnome-control-center
UpgradeStatus: No upgrade log present (probably fresh install)

[dantepaoloni (dantepaoloni-redhat-bugs)]

Description of problem:
Hi! i open the Control Center after upgrading to F29.

All options worked perfect, but as soon i clicked in thunderbolt. CC Crash. Running from console gives:

Result -> CC Crash.
Expected -> CC Stating that ther is no Thunderbolt device in laptop (As F28 Said before).

Running from console:

pewpew  ~  gnome-control-center
(gnome-control-center:16183): thunderbolt-cc-panel-WARNING **: 22:47:43.173: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.
Segmentation fault (core dumped)
 pewpew  ~  gnome-control-center background
(gnome-control-center:16348): thunderbolt-cc-panel-WARNING **: 22:47:47.154: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.
Segmentation fault (core dumped)

Selecting Wifi (maybe another one works too?) allow me to enter the CC (after two times)

 pewpew  ~  gnome-control-center
(gnome-control-center:17228): thunderbolt-cc-panel-WARNING **: 22:48:45.103: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.
Segmentation fault (core dumped)

Result -> CC Crash

 pewpew  ~  gnome-control-center wifi
(gnome-control-center:17389): thunderbolt-cc-panel-WARNING **: 22:48:50.103: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.
Segmentation fault (core dumped)

Result -> CC Crash

 pewpew  ~  gnome-control-center wifi

Result -> CC opens.

Laptop UX410UAR with not thunderbolt device.

Version-Release number of selected component:
gnome-control-center-3.30.1-3.fc29

Additional info:
reporter: libreport-2.9.6
backtrace_rating: 4
cmdline: gnome-control-center
crash_function: g_object_notify_queue_thaw
executable: /usr/bin/gnome-control-center
journald_cursor: s=6f6ac97f9aca4e62a1e5f2446ea2204a;i=62e6c;b=fa084d2d635045558cc44b10485dd4fe;m=250d5fff;t=5797c5e5404d6;x=2fcc1bc094d469a7
kernel: 4.18.16-300.fc29.x86_64
rootdir: /
runlevel: N 5
type: CCpp
uid: 1000

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 g_object_notify_queue_thaw at gobject.c:289
 #1 g_object_new_internal at gobject.c:1862
 #2 g_object_new_valist at gobject.c:2128
 #4 gdk_pixbuf_new_from_data at ../gdk-pixbuf/gdk-pixbuf-data.c:70
 #5 symbolic_cache_get_proxy at gtkicontheme.c:4303
 #6 gtk_icon_info_load_symbolic_internal at gtkicontheme.c:4625
 #7 gtk_icon_info_load_symbolic at gtkicontheme.c:4726
 #8 ensure_surface_for_gicon at gtkiconhelper.c:466
 #9 gtk_icon_helper_load_surface at gtkiconhelper.c:566
 #10 gtk_icon_helper_ensure_surface at gtkiconhelper.c:603

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499179
File: backtrace

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499180
File: cgroup

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499181
File: core_backtrace

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499182
File: cpuinfo

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499183
File: dso_list

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499184
File: environ

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499185
File: exploitable

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499186
File: limits

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499187
File: maps

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499188
File: mountinfo

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499189
File: open_fds

[dantepaoloni (dantepaoloni-redhat-bugs)]

Created attachment 1499190
File: proc_pid_status

[Sebastien Bacher (seb128)]

Reported upstream on https://gitlab.gnome.org/GNOME/gnome-control-center/issues/318

[Sebastien Bacher (seb128)]

The bug has been fixed upstream now

[Sebastien Bacher (seb128)]

The new version including the fix is in disco

[John J. Szetela (john-szetela)]

So... How about a fix!
For Ubuntu 18.04.3 the bug happens when you inadvertently hit the gnome-control-center devices/thunderbolt section.
gnome-control-center segfaults and will not restart! Fault:
(gnome-control-center:8315): thunderbolt-cc-panel-WARNING **: 15:36:34.212: Could not create client: Error calling StartServiceByName for org.freedesktop.bolt: GDBus.Error:org.freedesktop.systemd1.UnitMasked: Unit bolt.service is masked.

Instead of waiting for a fix to this that happens upstream from Ubuntu18.04.3 you can just:
sudo systemctl unmask bolt.service
sudo systemctl stop bolt.service
sudo systemctl start bolt.service

The stop probably isn't necessary, but it doesn't hurt!