[snap] Broken link in theme directory

[Benjamin Tegge]

Reproduce steps
---------------
1. $ snap install gnome-characters communitheme
2. logoff and select communitheme session at the greeter (probably needs a reload of GDM or reboot, I'm running the wayland session but it also happened of X)
3. $ snap run gnome-characters

Affected snaps:
gnome-characters
gnome-calculator
gnome-logs
gnome-system-monitor
libreoffice
evince
gnome-contacts
eog

Symptoms
--------
I'm using the communitheme and gnome-characters snap on Ubuntu 18.04 which broke at some point about two month ago. Screenshots are here: https://askubuntu.com/q/1142291/40581

I found that ~/snap/gnome-characters/current/themes is a broken link even when removing the respective snap folder for the app, removing and then reinstalling the gnome-characters snap. This has worked before, please take a look at this.

In the meantime I fixed this with the following commands, according the the error message:

rm ~/snap/gnome-characters/current/.themes
cp -av /snap/communitheme/current/share/themes ~/snap/gnome-characters/current/.themes

Version
-------
```
$ snap info {gnome-characters,communitheme} | grep -vE "^(summary|license|contact|description|commands):"
name: gnome-characters
publisher: Canonical*
  Characters is a simple utility application to find and
  insert unusual characters.
  - gnome-characters
snap-id: qJcS3UjpF9AMJKWAiKwA5EWbm0y6Uduw
tracking: stable
refresh-date: heute um 04:19 CEST
channels:
  stable: v3.32.1+git1.2050bba 2019-05-01 (258) 15MB -
  candidate: v3.32.1+git1.2050bba 2019-05-01 (258) 15MB -
  beta: ^
  edge: v3.32.0+git9.4424d0f 2019-05-08 (260) 15MB -
installed: v3.32.1+git1.2050bba (258) 15MB -
---
name: communitheme
publisher: Didier Roche (didrocks)
  Yaru, formerly known as Communitheme, is the new Ubuntu theme built by the
  community. Yaru will become the default Ubuntu theme in Ubuntu 18.10. This
  package allows you to try out the theme on Ubuntu 18.04 LTS.

  To try out the theme, install this package on Ubuntu 18.04 LTS, restart
  your computer and select the "Ubuntu with communitheme snap" session from
  the login screen.

  More information is available at
  https://community.ubuntu.com/t/faq-ubuntu-new-theme/1930.
snap-id: Yd6CISPIf6tEf3ZEJ0cqSoEg9rG2VkRi
tracking: stable
refresh-date: 59 days ago, at 17:46 CET
channels:
  stable: 0.1 2019-03-13 (1768) 16MB -
  candidate: ^
  beta: ^
  edge: 0.1 2019-05-08 (1799) 17MB -
installed: 0.1 (1768) 16MB -
```

---

Further investigation
---------------------

I'm also seeing broken links on an 19.04 machine where I'm not using the Communitheme snap but the preinstalled Yaru packages. I'm trying out the dark theme but all snaps launch with Adwaita instead.

```
$ snap list
Name Version Rev Tracking Publisher Notes
android-studio 3.4.0.18 75 stable snapcrafters classic
canonical-livepatch 9.3.0 77 stable canonical* -
core 16-2.38.1 6818 stable canonical* core
core18 20190409 941 stable canonical* base
gedit 3.30.2+git14.bed83e929 89 stable canonical* -
gnome-3-26-1604 3.26.0.20190228 82 stable/… canonical* -
gnome-3-28-1804 3.28.0-10-gaa70833.aa70833 40 stable canonical* -
gnome-calculator 3.32.1 406 stable/… canonical* -
gnome-characters v3.32.1+git1.2050bba 258 stable canonical* -
gnome-logs 3.32.0-4-ge8f3f37ca8 61 stable/… canonical* -
gtk-common-themes 0.1-16-g2287c87 1198 stable/… canonical* -

$ find snap/gnome-characters -xtype l
snap/gnome-characters/common/.cache/immodules/im-fcitx.so
snap/gnome-characters/common/.cache/immodules/im-wayland.so
snap/gnome-characters/common/.cache/immodules/im-broadway.so
snap/gnome-characters/common/.cache/immodules/im-inuktitut.so
snap/gnome-characters/common/.cache/immodules/im-cedilla.so
snap/gnome-characters/common/.cache/immodules/im-ipa.so
snap/gnome-characters/common/.cache/immodules/im-xim.so
snap/gnome-characters/common/.cache/immodules/im-thai.so
snap/gnome-characters/common/.cache/immodules/im-multipress.so
snap/gnome-characters/common/.cache/immodules/im-ti-er.so
snap/gnome-characters/common/.cache/immodules/im-cyrillic-translit.so
snap/gnome-characters/common/.cache/immodules/im-ibus.so
snap/gnome-characters/common/.cache/immodules/im-am-et.so
snap/gnome-characters/common/.cache/immodules/im-viqr.so
snap/gnome-characters/common/.cache/immodules/im-ti-et.so
snap/gnome-characters/common/.cache/gio-modules/libgiognomeproxy.so
snap/gnome-characters/common/.cache/gio-modules/libdconfsettings.so
snap/gnome-characters/common/.cache/gio-modules/libgiognutls.so
snap/gnome-characters/common/.cache/gio-modules/libgiolibproxy.so
snap/gnome-characters/258/.local/share/icons/DMZ-Black/cursor.theme
snap/gnome-characters/258/.local/share/icons/DMZ-Black/index.theme
snap/gnome-characters/258/.local/share/icons/DMZ-Black/cursors
snap/gnome-characters/258/.local/share/icons/communitheme/index.theme
snap/gnome-characters/258/.local/share/icons/Suru/index.theme
snap/gnome-characters/258/.local/share/icons/hicolor/128x128
snap/gnome-characters/258/.local/share/icons/hicolor/32x32
snap/gnome-characters/258/.local/share/icons/hicolor/36x36
snap/gnome-characters/258/.local/share/icons/hicolor/96x96
snap/gnome-characters/258/.local/share/icons/hicolor/512x512
snap/gnome-characters/258/.local/share/icons/hicolor/192x192
snap/gnome-characters/258/.local/share/icons/hicolor/symbolic
snap/gnome-characters/258/.local/share/icons/hicolor/256x256
snap/gnome-characters/258/.local/share/icons/hicolor/48x48
snap/gnome-characters/258/.local/share/icons/hicolor/scalable
snap/gnome-characters/258/.local/share/icons/hicolor/22x22
snap/gnome-characters/258/.local/share/icons/hicolor/16x16
snap/gnome-characters/258/.local/share/icons/hicolor/72x72
snap/gnome-characters/258/.local/share/icons/hicolor/index.theme
snap/gnome-characters/258/.local/share/icons/hicolor/24x24
snap/gnome-characters/258/.local/share/icons/hicolor/64x64
snap/gnome-characters/258/.local/share/icons/DMZ-White/cursor.theme
snap/gnome-characters/258/.local/share/icons/DMZ-White/index.theme
snap/gnome-characters/258/.local/share/icons/DMZ-White/cursors
snap/gnome-characters/258/.local/share/themes
snap/gnome-characters/258/.themes
```

I also tried the following combinations, with no effect:

```
$ XDG_CURRENT_DESKTOP=dark:ubuntu:GNOME snap run gnome-characters
$ XDG_CURRENT_DESKTOP=ubuntu:GNOME snap run gnome-characters
$ XDG_CURRENT_DESKTOP=dark:GNOME snap run gnome-characters
```

In addition to that I'm using KDE's Breeze_cursors but I get the black fallback cursor instead. When I'm running Android Studio the Breeze_cursors are properly displayed.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Sean Davis (bluesabre)]

Also tagging snap since the issue is present on snaps that have run in the user session.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[John Lenton (chipaca)]

It's unclear to me why you've added snapd to this bug. I'm setting it as Invalid, but if you have a reasoning please explain it and set it back to New so our triage picks it up again.

[Sean Davis (bluesabre)]

@John

Which component is responsible for linking ~/snap/packagename/current/.themes? Is this a per snap functionality or snapd that would produce this? Currently it's broken for at least the snaps listed in the description.

[Maciej Borzecki (maciek-borzecki)]

@sean

The snap command (part of snapd) takes care of ~/snap/packagename/current/, anything below (including .themes) is handled by the actual snap package. I would look into desktop extensions added by snapcraft.