[MIR] gnome-bluetooth

[Alexander Sack]

Binary package hint: gnome-bluetooth

1. Availability: http://archive.ubuntu.com/ubuntu/pool/universe/g/gnome-bluetooth; available for all supported architectures or some subset ? all arches.

2. Rationale:
    * gnome default component
    * default bluetooth frontend for karmic

3. Security:
     * No open CVE/secunia issues reported/known
     * Any binaries running as root or suid/sgid ? Any daemons ? not running as root; no daemon
     * Network activity: does it open any port? Does it handle incoming network data? not opening a port and doesnt directly parse bluetooth data streams
     * Does it directly (not through a library) process binary (video, audio, etc) or structured (PDF, etc) data ?
          * Any source code review performed ? (The approver will do a quick and shallow check.)

4. Quality assurance:
     * In what situations does the package not work out of the box without configuration ?
     * Does the package ask any debconf questions higher than priority 'medium' ? no debconf.
     * Debian bugs: (mention any that are particularly relevant, and any showstoppers)
        * no showstoppers
      * Maintenance in Debian is frenetic/vigorous/calm/dead ? packaged in ubuntu until this obexd gets through NEW in debian.
      * Upstream is vigorous
      * Hardware: Does this package deal with hardware and if so how exotic is it ? does not directly deal with hardware
      * Is there a test suite in the upstream source or packaging ? Is it enabled to run in the build? no testsuite

5. UI standards:
    * User-visible strings are internationalized using standard gettext system ? yes.
    * Package with translatable strings builds a PO template during package build ?
    * End-user applications ship a desktop file ? yes (application & autostart)

6. Standards compliance:
    * FHS, Debian Policy compliance ? yes
    * Packaging system (debhelper/cdbs/dbs) ? Patch system ? Any packaging oddities ? simple patchsystem (but no patches atm); no addities

7. Dependencies:
    * Are these all in main ? no. obex-client (obexd sources) need promotion

8. Maintenance:
     * How much maintenance is this package likely to need ? no dedicated developer needed. asac and desktop team will keep this on the radar though.
     * Who is responsible for monitoring the quality of this package and fixing its bugs ? Are they Ubuntu or Debian developers ? asac (DD + ubuntu core dev), crevette, desktop team
     * Who is the package bug contact in Ubuntu? (Needs one if its a nontrivial package which does not fully maintain itself through Debian)

9. Background information:
     * What do upstream call this software ? Has it had different names in the past ? gnome.org bluez-gnome fork.

10. Internationalization:
     * Are graphical applications translatable? Do they support gettext? yes. gettext translatable.

[Alexander Sack (asac)]

we pre-promote this for alpha4 ... setting milestone to alpha 5 so it doesnt get lost.

[Loïc Minier (lool)]

I found a couple of things to fix in gnome-bluetooth; I'm attaching a debdiff for the things I could fix myself (not uploaded due to freeze):
gnome-bluetooth (2.27.8-0ubuntu2) UNRELEASED; urgency=low

  * Bump libdbus-glib-1-dev bdep to >= 0.74 to match configure.
  * Pass --disable-icon-update to configure by default as icon caches will be
    created by default if libgtk2.0-bin is present and might be shipped in the
    package.
  * Dont include autotools.mk as it's already included by gnome.mk.
  * Drop libgeoclue-dev bdep as it doesn't seem to be needed for the geoclue
    plugin.

 -- Loïc Minier <email address hidden> Tue, 01 Sep 2009 12:04:15 +0200

the other issues worth mentionning are:
- copyright doesn't list licensing for lib/* which seems to be LGPL; it would be good to clarify whether the whole lib is LGPL or at least under what license all files are
- there's this error during build:
Warning: cannot load module 'docbook', using automatic detection (-a).
xsltproc -o gnome-bluetooth-C.omf --stringparam db2omf.basename gnome-bluetooth --stringparam db2omf.format 'docbook' --stringparam db2omf.dtd "-//OASIS//DTD DocBook XML V4.1.2//EN" --stringparam db2omf.lang C --stringparam db2omf.omf_dir "/usr/share/omf" --stringparam db2omf.help_dir "/usr/share/gnome/help" --stringparam db2omf.omf_in "/build/buildd/gnome-bluetooth-2.27.8/help/gnome-bluetooth.omf.in" `/usr/bin/pkg-config --variable db2omf gnome-doc-utils` C/gnome-bluetooth.xml || { rm -f "gnome-bluetooth-C.omf"; exit 1; }
error : No such file or directory
I couldn't figure out what causes the error since the docbook packages are installed
- there's this warning during build:
dpkg-shlibdeps: warning: debian/gnome-bluetooth/usr/lib/gnome-bluetooth/plugins/libgbtgeoclue.so contains an unresolvable reference to symbol bluetooth_client_new: it's probably a plugin.
I wonder whether the plugin should be linked to the lib; perhaps not, I am not sure
- does upstream have a plan to move away of hal?
- I see the ~bluetooth team is sub-ed to bug mail, but not the desktop team nor Alexander

Would you mind merging the proposed debdiff and fixing copyright? Apart of that +1 from me

[Loïc Minier (lool)]

(Also FYI there's a new upstream version released)

[Loïc Minier (lool)]

On geoclue: there's no dependency in the binary packages on any geoclue package, you might want to manually add one?

[Martin Pitt (pitti)]

Loic, thanks for the extensive revieiw.

Alex, can you please incorporate Loic's feedback?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-bluetooth - 2.27.90-0ubuntu1

---------------
gnome-bluetooth (2.27.90-0ubuntu1) karmic; urgency=low

  * upstream release 2.27.90 (LP: #427665)
  * addressing MIR comments (LP: #409848)

  [ Loïc Minier <email address hidden> ]
  * Bump libdbus-glib-1-dev bdep to >= 0.74 to match configure.
  * Pass --disable-icon-update to configure by default as icon caches will be
    created by default if libgtk2.0-bin is present and might be shipped in the
    package.
  * Dont include autotools.mk as it's already included by gnome.mk.
  * Drop libgeoclue-dev bdep as it doesn't seem to be needed for the geoclue
    plugin.

  [ Alexander Sack <email address hidden> ]
  * debian/control: add geoclue to gnome-bluetooth Suggests
  * debian/copyright: clarify copyright for shipped packages
  * debian/rules: drop removal of -Bsymbolic-functions link flag; upstream
    fixed the way libcommon.la is linked into the various binaries
  * debian/control: add Vcs-Bzr info to ~ubuntu-desktop packaging branch

  [ Baptiste Mille-Mathias <email address hidden> ]
  * Fix rkill status (LP: #407962)

 -- Alexander Sack <email address hidden> Fri, 11 Sep 2009 05:08:01 +0200