Fish (Wanda) no longer customizable

Bug #958811 reported by komputes
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-panel (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Can't apply custom animation to Fish applet (formerly called Wanda).

The description of the applet says "Fish: Display a swiming fish or another creature"

Not able to display another creature. Please bring back the ability for each user to customize Fish applet animations.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: gnome-applets 3.2.1-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-19.30-generic-pae 3.2.11
Uname: Linux 3.2.0-19-generic-pae i686
ApportVersion: 1.94.1-0ubuntu2
Architecture: i386
Date: Sun Mar 18 17:04:22 2012
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha i386 (20120210)
ProcEnviron:
 LANGUAGE=en_CA:en
 TERM=xterm
 PATH=(custom, user)
 LANG=en_CA.UTF-8
 SHELL=/bin/bash
SourcePackage: gnome-applets
UpgradeStatus: Upgraded to precise on 2012-03-17 (1 days ago)

Revision history for this message
komputes (komputes) wrote :
affects: gnome-applets (Ubuntu) → gnome-panel (Ubuntu)
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I see two problems here:

1) the initial fish_applet_settings_changed() is called *before* setup_fish_widget(fish), so the widget cannot be updated;

2) g_settings_get_string (settings, "image") always returns "wanda.fish", even after running "gsettings set org.gnome.gnome-panel.applet.fish:/ image monkey.fish". This probably has something to do with the scheme being relocatable.

Changed in gnome-panel (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

1) This can be fixed by moving fish_applet_settings_changed() after setup_fish_widget().

2) Correct command to change it is:
gsettings set org.gnome.gnome-panel.applet.fish:/org/gnome/gnome-panel/layout/objects/[fish-applet]/instance-config/ image monkey.fish

[fish-applet] - name of applet in dconf. It could be fish-applet, fish-applet-1, fish-applet-2, fish-applet-0-0...

Best fix for this would be to restore option to change this in preferences dialog.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

I am not going to restore the preferences dialog, but here are some commits that make customizing work again:

https://github.com/mitya57/gnome-panel/commits/master

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Here is patch that restores option to change animation from preferences dialog. Currently only builtin animations are supported, but in future I might improve it to support custom animations loaded for example from ~/.config/gnome-panel/applets/fish/.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "0001-fish-restore-option-to-change-animation.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Fixed in gnome-panel 3.14.

tags: removed: patch
Changed in gnome-panel (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.