gmbrc misses line to activate albuminfo-plugin

Bug #1223808 reported by Simon Steinbeiß on 2013-09-11
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gmusicbrowser (Ubuntu)
Undecided
Unassigned

Bug Description

The default layout, Shimmer Desktop, uses the albuminfo plugin, but the tab for it remains empty by default because the plugin isn't activated.

The fix is simple, add the line "PLUGIN_ALBUMINFO: 1" here (after PLUGIN_ARTISTINFO: 1):
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/saucy/gmusicbrowser/saucy/view/head:/gmbrc.default#L12

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gmusicbrowser (Ubuntu):
status: New → Confirmed
Elfy (elfy) wrote :

Tried to enable the plugin.

Gmb then became unresponsive to keyboard and mouse - had to kill it.

Quentin Sculo (squentin) wrote :

I've fixed the freezing problem in albuminfo, the fix is in git.
As to enabling the plugin by default, I'm not sure. You're welcome to do it in the ubuntu package as it uses the shimmer layouts by default. gmbrc.default is intended for distributions to set up the default they want.
I'll think about a smarter fix for layouts that want to use plugins that are not enabled.

Simon Steinbeiß (ochosi) wrote :

I have successfully tested the patch just now in Saucy.
1) The plugin works as expected now
2) No more UI freezing

So the proposed path is to enable the plugin by default for Saucy (as it's part of our default layout) and re-think this implementation (see previous comment by Quentin) for 14.04.

Pasi Lallinaho (knome) on 2013-09-18
Changed in gmusicbrowser (Ubuntu):
assignee: nobody → Simon Steinbeiß (ochosi)
status: Confirmed → Fix Committed
status: Fix Committed → In Progress
Sean Davis (bluesabre) wrote :

Attaching a debdiff that includes the necessary changes to fix this bug.

Sean Davis (bluesabre) wrote :

Attaching better, more lintian-clean debdiff.

The attachment "debdiff with fixed gmbrc.default and updated plugin" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Sean Davis (bluesabre) wrote :

Lionel,

Here is another debdiff with less focus on lintian and a better description in the patch.

Hi Sean,

Your debdiff fails to apply for me:

asb@asb-laptop:~/Desktop/gmusicbrowser-1.1.10$ patch -p1 < ../gmb_v3.debdiff
patching file debian/patches/fix_albuminfo-plugin
patch: **** malformed patch at line 161: diff -Nru gmusicbrowser-1.1.10/debian/patches/series gmusicbrowser-1.1.10/debian/patches/series

Thanks for your work on this!

Pasi Lallinaho (knome) on 2013-10-10
Changed in gmusicbrowser (Ubuntu):
assignee: Simon Steinbeiß (ochosi) → nobody
Changed in gmusicbrowser (Ubuntu):
status: In Progress → Incomplete
Sebastien Bacher (seb128) wrote :

The patch is invalid indeed. Could you update it and add a link to the upstream change/commit/bug? Unsubscribing ubuntu-sponsors, please subscribe them back once you do that

Launchpad Janitor (janitor) wrote :

[Expired for gmusicbrowser (Ubuntu) because there has been no activity for 60 days.]

Changed in gmusicbrowser (Ubuntu):
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers