Please add the new rif_Ma locale

Bug #1926312 reported by Ilyahoo Proshel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GLibC
Fix Released
Wishlist
glibc (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Dear maintainers,

Please find attached the locale definition for rif_Ma to be considered for addition in Ubuntu.

Thanks!

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Created attachment 13401
rif_MA locale file

Dear maintainers,

Please find attached the locale definition for "Tarifit language locale for Morocco" to be considered for inclusion in glibc.

Thanks!

Revision history for this message
Ilyahoo Proshel (ipshel) wrote :
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks for your suggested locale. Ubuntu uses the locales provided by glibc, though, so the right place to request a new locale is here:

https://sourceware.org/bugzilla/enter_bug.cgi?product=glibc;component=localedata

If you submit a request to upstream glibc, please post the URL to it here for tracking purposes.

I saw that you have requested that Tarifit is added to the Launchpad languages. Some hints before you proceed:

You should keep in mind that translating Ubuntu is not only about Ubuntu. It's about translating free software for Linux, i.e. a huge undertaking.

Would there be enough translators to translate tens of thousands of strings (at least) into Tarifit and then maintain those translations when software is upgraded or replaced? And how many users would find it useful to have menus and windows displayed in Tarifit?

I'm not suggesting it can't be done, but I'm trying to make sure that you understand the scope of the project.

affects: langpack-locales (Ubuntu) → glibc (Ubuntu)
Changed in glibc (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Ilyahoo Proshel (ipshel) wrote :

Thank you for your reply.

Honestly I did not submit the request through launchpad. I post it using the link you provide. And you will find my request here :

https://sourceware.org/bugzilla/show_bug.cgi?id=27781

And yes, we are aware that we are translating not just Ubuntu. But we will translate as much as we can. And there will be translators. I just start preparing the working environment.

Thank you.

Revision history for this message
Ilyahoo Proshel (ipshel) wrote :

I am very sorry. It was a mistake from my side. I did not remembering that I submit a bug here.
I did actually. and I submit it in Sourceware too.
I am really sorry for my lack of attention.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

No problem. Actually it's apparent from your series of steps that you did pay a lot of attention and have studied the related documentation.

As regards the request to approve your team, I will take care of it but only when the language has been registered at Launchpad.

Balint Reczey (rbalint)
Changed in glibc (Ubuntu):
status: New → Triaged
Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Created attachment 13620
rif_MA updated locale file

We update the names and text in the locale file

Changed in glibc:
importance: Unknown → Wishlist
status: Unknown → New
Revision history for this message
In , Carlos-0 (carlos-0) wrote :

(In reply to Ilyahoo Proshel from comment #1)
> Created attachment 13620 [details]
> rif_MA updated locale file
>
> We update the names and text in the locale file

This needs to be posted to <email address hidden> for review.

Along with that review it would be good if you could include a test case for Tarifit:

- Add localedata/rif_MA.UTF-8.in with expected sort order for data.
- Add rif_MA.UTF-8 to test-input

This should add rif_MA.UTF-8 testing to glibc to ensure the sorting matches your expectations and stays this way going forward. This prevents accidental breakage in collation when refactoring during ISO 14651 updates.

Changed in glibc:
status: New → Confirmed
Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Created attachment 13921
updated rif_MA locale

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Created attachment 13922
test input for rif_MA

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Dear maintainers,

I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I modified the original locale to prevent some errors.

make localedata/tests has been done without any errors.

Please find attached files.

Revision history for this message
In , Adhemerval Zanella (adhemerval-zanella) wrote :

(In reply to Ilyahoo Proshel from comment #5)
> Dear maintainers,
>
> I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I
> modified the original locale to prevent some errors.
>
> make localedata/tests has been done without any errors.
>
> Please find attached files.

Please send any patch to libc-alpha [1], here are some links on how to contribute [2]. Patches are only reviewed on the maillist.

[1] https://sourceware.org/mailman/listinfo/libc-alpha
[2] https://sourceware.org/glibc/wiki/Contribution%20checklist

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

Created attachment 14051
Slighly improved rif_MA

I used ASCII characters directly instead of <U...>, for example:

abday "L<U1E25>e";/
                "Let";/
                "Ttl";/
                "Lar";/
                "Lex";/
                "Jje";/
                "Sbt"

Only for non ASCII characters we are still using the <U....> code point notation, using the ASCII characters directly makes it a lot more readable.

I also added:

lang_name "Tmazi<U0263>t"

Does that look OK to you?

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

(In reply to Mike FABIAN from comment #7)
> Created attachment 14051 [details]
> Slighly improved rif_MA
>
> I used ASCII characters directly instead of <U...>, for example:
>
> abday "L<U1E25>e";/
> "Let";/
> "Ttl";/
> "Lar";/
> "Lex";/
> "Jje";/
> "Sbt"
>
> Only for non ASCII characters we are still using the <U....> code point
> notation, using the ASCII characters directly makes it a lot more readable.
>
> I also added:
>
> lang_name "Tmazi<U0263>t"
>
> Does that look OK to you?

Thank you for you help and your work on improving the locale.
everything seems to be ok. Just the name. it's a locale for "Tarifit", and not "Tmazi<U0263>t". because the last one is another language.

And by the way. we did send the patch for the unmodified locale. and it pass the build successfully, if you want to take a look here:
https://patchwork<email address hidden>/

Thank you a lot.

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

https://en.wikipedia.org/wiki/Tarifit

The wikipedia article said that the endonym (The name of the language in itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first one.

According to Wikipedia, “Tarifit” is the name of the language in English.

lang_name should contain the endonym whereas

language "Tarifit"

should contain the English name.

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

> And by the way. we did send the patch for the unmodified locale. and it pass
> the build successfully, if you want to take a look here:
> https://patchwork.sourceware.org/project/glibc/patch/20220125172555.2527278-
> <email address hidden>/

Yes, I read your mail and the attached patch and I took the
the test input file from the patch in the mail because the one
attached to the bug report here does not work (i.e. sorting the test file
attached to the bug does not reproduce the test input).

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

(In reply to Mike FABIAN from comment #9)
> https://en.wikipedia.org/wiki/Tarifit
>
> The wikipedia article said that the endonym (The name of the language in
> itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> one.
>
> According to Wikipedia, “Tarifit” is the name of the language in English.
>
> lang_name should contain the endonym whereas
>
> language "Tarifit"
>
> should contain the English name.

Wikipedia> Its own speakers simply call it "Tamazight", a term also often applied Wikipedia> in a broader sense to the Berber language across North Africa in Wikipedia> general.

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

(In reply to Mike FABIAN from comment #11)
> (In reply to Mike FABIAN from comment #9)
> > https://en.wikipedia.org/wiki/Tarifit
> >
> > The wikipedia article said that the endonym (The name of the language in
> > itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> > one.
> >
> > According to Wikipedia, “Tarifit” is the name of the language in English.
> >
> > lang_name should contain the endonym whereas
> >
> > language "Tarifit"
> >
> > should contain the English name.
>
> Wikipedia> Its own speakers simply call it "Tamazight", a term also often
> applied Wikipedia> in a broader sense to the Berber language across North
> Africa in Wikipedia> general.

Tamazight is the mother language where multiple other languages inherited from it. Including Tarifit.
And what’s apply for Tarifit does mean that can apply for another sub-tamazight languages, and vice versa. So we believe that lang_name should be “Tarifit”.

Should we resend the patch by email with your improvements?
Thank you very much for your time.

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

> Tamazight is the mother language where multiple other languages inherited
> from it. Including Tarifit.
> And what’s apply for Tarifit does mean that can apply for another
> sub-tamazight languages, and vice versa. So we believe that lang_name should
> be “Tarifit”.
>
> Should we resend the patch by email with your improvements?
> Thank you very much for your time.

No, you don’t need to resend the patch, I just change lang_name to “Tarifit” and then I can commit it, I think.

Revision history for this message
In , Cvs-commit (cvs-commit) wrote :

The master branch has been updated by Mike Fabian <email address hidden>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=189906b68742e8b26bca7103a7f3c221de36d0fd

commit 189906b68742e8b26bca7103a7f3c221de36d0fd
Author: Ilyahoo Proshel <email address hidden>
Date: Tue Apr 5 13:23:16 2022 +0200

    Add rif_MA locale [BZ #27781]

    Resolves: BZ #27781

Revision history for this message
In , Mike FABIAN (mike-fabian) wrote :

Fixed in glibc master.

Revision history for this message
In , Ilyahoo Proshel (ipshel) wrote :

Thank you, We really appreciate your time and your contribution.(In reply to Mike FABIAN from comment #15)
> Fixed in glibc master.

Changed in glibc:
status: Confirmed → Fix Released
Revision history for this message
Ilyahoo Proshel (ipshel) wrote :

Dear maintainers,

what is the next here? Since the bug is fixed in glibc upstream.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Ilyahoo: That means that the rif_MA locale will be available in Ubuntu 22.10, so I mark this bug as fixed also in Ubuntu.

Next step is to translate, I suppose. :) Maybe with the goal to provide a decent Tarifit experience in next LTS, i.e. Ubuntu 24.04.

If you haven't already, please subscribe to this mailing list:

https://lists.ubuntu.com/mailman/listinfo/ubuntu-translators

It's a good place to ask for clarifications, and important translation related announcements are also made there.

Changed in glibc (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.