git-review defaults to refs/publish/* which is deprecated

[Derek Waldner]

git-review 1.25.0 defaults to refs/publish/* when pushing changes without any command line options instead of refs/for/* as current gerrit 2.15.2 documentation indicates should be used. Shouldn't the default be to push to refs/for/* and have the --compatible option use the deprecated refs/publish/*?

ie. Shouldn't this line, https://github.com/openstack-infra/git-review/blob/ed3c79e45289a73e5645be316ef9e39b08bb79c9/git_review/cmd.py#L1615, read 'ref = for'?

[Simon Quigley (tsimonq2)]

I'm not clearly understanding if this is an issue with the latest version (and thus, an upstream issue) or if there is a patch we can put in a stable release.

Could you try 18.04 (which contains the same version as Cosmic) and see if the issue still stands there? An easy way to do this is to use something like Multipass or LXD.

Thanks for reporting the bug; I hope we can get this solved.

[Derek Waldner (derek.waldner.os)]

Thanks for the quick response; I do see the same behavior in latest Ubuntu (18.04) as well.

[Simon Quigley (tsimonq2)]

Please file a bug here: https://storyboard.openstack.org/#!/project/719

Once that's done, put a link here and I can link it to the bug. I'll be happy to cherry-pick it into Ubuntu if it's fixed upstream.

Thanks!

[Derek Waldner (derek.waldner.os)]

Thanks for the help, link to bug here, https://storyboard.openstack.org/#!/story/2002897

[Simon Quigley (tsimonq2)]

Hm, it seems I can't link the bug here.

It would be great if you could shoot a reply here when it's good to go.

Additionally, if you think it should go in a stable release, please edit the bug description to follow the Stable Release Update format: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Thanks again!

[Derek Waldner (derek.waldner.os)]

My review, https://review.openstack.org/#/c/584607/, has been submitted. I ended up removing the 'compatible' option from git-review as well because the original 'refs/for/*' was reverted back to as the namespace and 'refs/publish/*' was deprecated in favor of the original. I've updated the status here to reflect the change being committed.