ValueError: too many values to unpack

[Nick Barcet]

Version 1.21-0ubuntu1 on Raring

Trying to have a commit reviewed on openstack gerrit causes git-review to crash with the following trace back

$ git-review -s
Traceback (most recent call last):
  File "/usr/bin/git-review", line 1168, in <module>
    main()
  File "/usr/bin/git-review", line 951, in main
    (top_dir, git_dir) = git_directories()
ValueError: too many values to unpack

Steps to reproduce
$ cd /opt/stack
$ git clone https://github.com/openstack/ceilometer.git
$ cd ./ceilometer
$ git remote add gerrit ssh://<username>@review.openstack.org:29418/openstack/ceilometer.git
$ git-review -s

Same exact steps on Quantal with version 1.17-1 works like a charm.

[Nick Barcet (nijaba)]

Downgrading to 1.17-1 on Raring works like a charm too.

[Ed Cranford (ed--cranford)]

I have a directory with a space in the name, and attempted git review -s and got the same error.
The problem is in git_directories(), line 193. I changed out.split() to out.split('\n') in git-review and the error was resolved.

The output from "git rev-parse --show-toplevel --git-dir" outputs two lines: the current directory, and .git. Splitting on whitespace created three items, which caused the Too Many Values error.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.